Feat/lw 9092 rework wallet manager #1012

AngelCastilloB · 2023-12-07T05:25:34Z

Context

Existing WalletManager api supports only a single wallet. It has to be re-designed for multi-wallet support.
This task connects most of the SDK pieces together.

Proposed Solution

Re-designed WalletManager api to supports multi-wallet.

github-actions · 2023-12-07T05:38:05Z

Standard DiffPost

This PR would generate the following kubectl diff:

Preview

diff -u -N /tmp/LIVE-2289571751/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-3705664509/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-2289571751/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2023-12-20 10:40:49.949033288 +0000
+++ /tmp/MERGED-3705664509/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2023-12-20 10:40:49.949033288 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "93"
   creationTimestamp: "2023-08-11T18:16:12Z"
-  generation: 93
+  generation: 94
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 71bce07b34cd3a77ce737bf09ee6882eae38b94e
+    app.kubernetes.io/version: 76c2a3aeaf01ea19fcad24a7e25f0faea07f98ac
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
@@ -89,7 +89,7 @@
           value: "false"
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:1wb97mmbajnnar140dyxjrlmyiq5y9yn
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:r4g1h67dlyx4zjy5gzawm1xjxkgl8a9m
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2289571751/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-3705664509/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-2289571751/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-12-20 10:40:50.153031536 +0000
+++ /tmp/MERGED-3705664509/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-12-20 10:40:50.153031536 +0000
@@ -8,7 +8,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 71bce07b34cd3a77ce737bf09ee6882eae38b94e
+    app.kubernetes.io/version: 76c2a3aeaf01ea19fcad24a7e25f0faea07f98ac
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-2289571751/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector /tmp/MERGED-3705664509/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector
--- /tmp/LIVE-2289571751/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2023-12-20 10:40:50.353029815 +0000
+++ /tmp/MERGED-3705664509/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2023-12-20 10:40:50.353029815 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "93"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 93
+  generation: 94
   labels:
     app: handle-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 71bce07b34cd3a77ce737bf09ee6882eae38b94e
+    app.kubernetes.io/version: 76c2a3aeaf01ea19fcad24a7e25f0faea07f98ac
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-projector
@@ -73,7 +73,7 @@
               name: handle-owner-user.dev-preview-dbsync-db.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: handle
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:1wb97mmbajnnar140dyxjrlmyiq5y9yn
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:r4g1h67dlyx4zjy5gzawm1xjxkgl8a9m
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2289571751/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-3705664509/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-2289571751/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2023-12-20 10:40:50.557028066 +0000
+++ /tmp/MERGED-3705664509/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2023-12-20 10:40:50.557028066 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "60"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 60
+  generation: 61
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 71bce07b34cd3a77ce737bf09ee6882eae38b94e
+    app.kubernetes.io/version: 76c2a3aeaf01ea19fcad24a7e25f0faea07f98ac
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
@@ -81,7 +81,7 @@
           value: handle
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:1wb97mmbajnnar140dyxjrlmyiq5y9yn
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:r4g1h67dlyx4zjy5gzawm1xjxkgl8a9m
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2289571751/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker /tmp/MERGED-3705664509/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker
--- /tmp/LIVE-2289571751/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2023-12-20 10:40:50.761026309 +0000
+++ /tmp/MERGED-3705664509/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2023-12-20 10:40:50.761026309 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "93"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 93
+  generation: 94
   labels:
     app: pg-boss-worker
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 71bce07b34cd3a77ce737bf09ee6882eae38b94e
+    app.kubernetes.io/version: 76c2a3aeaf01ea19fcad24a7e25f0faea07f98ac
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-pg-boss-worker
@@ -95,7 +95,7 @@
           value: pool-delist-schedule,pool-metadata,pool-metrics,pool-rewards
         - name: STAKE_POOL_PROVIDER_URL
           value: http://dev-preview-cardanojs-backend.dev-preview.svc.cluster.local
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:1wb97mmbajnnar140dyxjrlmyiq5y9yn
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:r4g1h67dlyx4zjy5gzawm1xjxkgl8a9m
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2289571751/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector /tmp/MERGED-3705664509/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector
--- /tmp/LIVE-2289571751/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2023-12-20 10:40:50.965024554 +0000
+++ /tmp/MERGED-3705664509/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2023-12-20 10:40:50.965024554 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "93"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 93
+  generation: 94
   labels:
     app: stake-pool-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 71bce07b34cd3a77ce737bf09ee6882eae38b94e
+    app.kubernetes.io/version: 76c2a3aeaf01ea19fcad24a7e25f0faea07f98ac
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-projector
@@ -73,7 +73,7 @@
               name: stakepool-owner-user.dev-preview-dbsync-db.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: stake-pool,stake-pool-metadata-job,stake-pool-metrics-job,stake-pool-rewards-job
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:1wb97mmbajnnar140dyxjrlmyiq5y9yn
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:r4g1h67dlyx4zjy5gzawm1xjxkgl8a9m
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2289571751/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-3705664509/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-2289571751/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2023-12-20 10:40:51.189022628 +0000
+++ /tmp/MERGED-3705664509/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2023-12-20 10:40:51.189022628 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "90"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 90
+  generation: 91
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 71bce07b34cd3a77ce737bf09ee6882eae38b94e
+    app.kubernetes.io/version: 76c2a3aeaf01ea19fcad24a7e25f0faea07f98ac
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider
@@ -83,7 +83,7 @@
           value: http://dev-preview-cardano-stack-metadata.dev-preview.svc.cluster.local
         - name: USE_TYPEORM_STAKE_POOL_PROVIDER
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:1wb97mmbajnnar140dyxjrlmyiq5y9yn
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:r4g1h67dlyx4zjy5gzawm1xjxkgl8a9m
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2289571751/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor /tmp/MERGED-3705664509/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor
--- /tmp/LIVE-2289571751/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2023-12-20 10:40:51.501019953 +0000
+++ /tmp/MERGED-3705664509/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2023-12-20 10:40:51.501019953 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 71bce07b34cd3a77ce737bf09ee6882eae38b94e
+    app.kubernetes.io/version: 76c2a3aeaf01ea19fcad24a7e25f0faea07f98ac
     instance: primary
   name: lace-backend-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-2289571751/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor /tmp/MERGED-3705664509/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor
--- /tmp/LIVE-2289571751/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2023-12-20 10:40:51.709018162 +0000
+++ /tmp/MERGED-3705664509/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2023-12-20 10:40:51.709018162 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 71bce07b34cd3a77ce737bf09ee6882eae38b94e
+    app.kubernetes.io/version: 76c2a3aeaf01ea19fcad24a7e25f0faea07f98ac
     instance: primary
   name: lace-handle-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-2289571751/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor /tmp/MERGED-3705664509/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor
--- /tmp/LIVE-2289571751/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2023-12-20 10:40:51.917016371 +0000
+++ /tmp/MERGED-3705664509/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2023-12-20 10:40:51.917016371 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 71bce07b34cd3a77ce737bf09ee6882eae38b94e
+    app.kubernetes.io/version: 76c2a3aeaf01ea19fcad24a7e25f0faea07f98ac
     instance: primary
   name: lace-stake-pool-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-2289571751/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-3705664509/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-2289571751/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2023-12-20 10:40:52.125014590 +0000
+++ /tmp/MERGED-3705664509/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2023-12-20 10:40:52.129014556 +0000
@@ -19,7 +19,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 71bce07b34cd3a77ce737bf09ee6882eae38b94e
+    app.kubernetes.io/version: 76c2a3aeaf01ea19fcad24a7e25f0faea07f98ac
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-2289571751/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-3705664509/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-2289571751/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-12-20 10:40:52.333012814 +0000
+++ /tmp/MERGED-3705664509/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-12-20 10:40:52.333012814 +0000
@@ -16,7 +16,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 71bce07b34cd3a77ce737bf09ee6882eae38b94e
+    app.kubernetes.io/version: 76c2a3aeaf01ea19fcad24a7e25f0faea07f98ac
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-2289571751/v1.Service.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-3705664509/v1.Service.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-2289571751/v1.Service.dev-preview.dev-preview-cardanojs-backend	2023-12-20 10:40:49.149040163 +0000
+++ /tmp/MERGED-3705664509/v1.Service.dev-preview.dev-preview-cardanojs-backend	2023-12-20 10:40:49.149040163 +0000
@@ -5,7 +5,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 71bce07b34cd3a77ce737bf09ee6882eae38b94e
+    app.kubernetes.io/version: 76c2a3aeaf01ea19fcad24a7e25f0faea07f98ac
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-2289571751/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-3705664509/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-2289571751/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-12-20 10:40:49.349038445 +0000
+++ /tmp/MERGED-3705664509/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-12-20 10:40:49.349038445 +0000
@@ -5,7 +5,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 71bce07b34cd3a77ce737bf09ee6882eae38b94e
+    app.kubernetes.io/version: 76c2a3aeaf01ea19fcad24a7e25f0faea07f98ac
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-2289571751/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-3705664509/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-2289571751/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2023-12-20 10:40:49.545036760 +0000
+++ /tmp/MERGED-3705664509/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2023-12-20 10:40:49.545036760 +0000
@@ -5,7 +5,7 @@
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 71bce07b34cd3a77ce737bf09ee6882eae38b94e
+    app.kubernetes.io/version: 76c2a3aeaf01ea19fcad24a7e25f0faea07f98ac
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
diff -u -N /tmp/LIVE-2289571751/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-3705664509/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-2289571751/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2023-12-20 10:40:49.745035041 +0000
+++ /tmp/MERGED-3705664509/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2023-12-20 10:40:49.745035041 +0000
@@ -5,7 +5,7 @@
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 71bce07b34cd3a77ce737bf09ee6882eae38b94e
+    app.kubernetes.io/version: 76c2a3aeaf01ea19fcad24a7e25f0faea07f98ac
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider

packages/e2e/test/web-extension/extension/background/walletManager.ts

packages/e2e/test/web-extension/extension/ui.ts

packages/key-management/src/types.ts

packages/web-extension/src/walletManager/walletManager.types.ts

packages/web-extension/src/walletManager/walletManagerWorker.ts

packages/e2e/test/web-extension/extension/background/walletManager.ts

packages/web-extension/test/walletManager/walletManagerWorker.test.ts

package.json

…nsaction BREAKING CHANGE: Witnesser witness method now takes a complete serializable Transaction

mkazlauskas

Great work! 💪 I would reword last commit when squashing to something more generic, like feat!: rework WalletManager and then detail it in commit body, because it's doing a lot more than just changing type of the argument

packages/web-extension/src/walletManager/types.ts

packages/e2e/package.json

packages/web-extension/src/walletManager/walletManager.ts

mirceahasegan

Great job, @AngelCastilloB ! 🚀

packages/web-extension/src/walletManager/walletManager.ts

mkazlauskas

Great work! 🚀

packages/web-extension/src/walletManager/walletManager.ts

packages/web-extension/src/walletManager/walletManager.types.ts

mkazlauskas

Nice work!

- web-extension e2e was updated to use the new wallet manager API - The e2e package now has as a dependency the chromedriver package - Wallet manager now has a new method switchNetwork which allows to activate the same wallet in a different network - Wallet manager now exposes a new observable activeWalletId$ which emits the currently active wallet id (id, account index and chain id) BREAKING CHANGE: Wallet manager activate method now takes an WalletManagerActivateProps object rather than just a wallet id - Wallet manager now takes signer manager api as a dependency - Wallet manager no longer exposes the observable wallet API, this now has to be done by application - Wallet manager destroy method was renamed destroyData and now will destroy any storage with the same wallet id

mirceahasegan

🥇

AngelCastilloB marked this pull request as draft December 7, 2023 05:26

AngelCastilloB changed the title ~~Feat/lw 9092 rework wallet manager~~ [WIP] Feat/lw 9092 rework wallet manager Dec 7, 2023

AngelCastilloB force-pushed the feat/lw-9092-rework-wallet-manager branch from 074f97e to 42c8521 Compare December 8, 2023 09:09

AngelCastilloB changed the base branch from master to feat/signer-manager December 8, 2023 09:10

mkazlauskas force-pushed the feat/signer-manager branch from 52a27e2 to 2b1e05c Compare December 11, 2023 08:53

AngelCastilloB force-pushed the feat/lw-9092-rework-wallet-manager branch 6 times, most recently from 8c0d56d to ceacac1 Compare December 12, 2023 13:18

mkazlauskas force-pushed the feat/signer-manager branch 2 times, most recently from 5cd283d to 88c4cb6 Compare December 12, 2023 14:35

AngelCastilloB force-pushed the feat/lw-9092-rework-wallet-manager branch 2 times, most recently from b092cf5 to 14c913e Compare December 12, 2023 16:19

mkazlauskas force-pushed the feat/signer-manager branch from a2b88eb to f902ba6 Compare December 13, 2023 06:29

AngelCastilloB force-pushed the feat/lw-9092-rework-wallet-manager branch 2 times, most recently from 9184ad3 to 14c23af Compare December 13, 2023 07:19

mkazlauskas force-pushed the feat/signer-manager branch from 4c94981 to 51647eb Compare December 13, 2023 11:25

Base automatically changed from feat/signer-manager to master December 13, 2023 12:44

feat(web-extension): wallet id type changed to just string

89f8a31

mkazlauskas force-pushed the feat/lw-9092-rework-wallet-manager branch 2 times, most recently from 47845a7 to 888e248 Compare December 13, 2023 18:21

AngelCastilloB force-pushed the feat/lw-9092-rework-wallet-manager branch from 9bcfd19 to c29a7f8 Compare December 14, 2023 09:14

AngelCastilloB marked this pull request as ready for review December 14, 2023 09:14

mkazlauskas requested changes Dec 14, 2023

View reviewed changes

mkazlauskas reviewed Dec 14, 2023

View reviewed changes

package.json Outdated Show resolved Hide resolved

feat!: witnesser witness method now takes a complete serializable Tra…

07a7305

…nsaction BREAKING CHANGE: Witnesser witness method now takes a complete serializable Transaction

AngelCastilloB force-pushed the feat/lw-9092-rework-wallet-manager branch from a048f61 to 8f57ec7 Compare December 15, 2023 04:39

AngelCastilloB force-pushed the feat/lw-9092-rework-wallet-manager branch 2 times, most recently from ee77543 to 66a4295 Compare December 16, 2023 07:05

mkazlauskas previously approved these changes Dec 18, 2023

View reviewed changes

mkazlauskas requested a review from a team December 18, 2023 07:58

AngelCastilloB force-pushed the feat/lw-9092-rework-wallet-manager branch 4 times, most recently from 84a5a76 to 1985d62 Compare December 18, 2023 08:38

mirceahasegan reviewed Dec 18, 2023

View reviewed changes

packages/web-extension/src/walletManager/types.ts Show resolved Hide resolved

mirceahasegan reviewed Dec 18, 2023

View reviewed changes

packages/e2e/package.json Show resolved Hide resolved

mirceahasegan reviewed Dec 18, 2023

View reviewed changes

packages/web-extension/src/walletManager/walletManager.ts Show resolved Hide resolved

AngelCastilloB dismissed mkazlauskas’s stale review via aba0583 December 19, 2023 00:21

mirceahasegan previously approved these changes Dec 19, 2023

View reviewed changes

mkazlauskas requested changes Dec 19, 2023

View reviewed changes

packages/web-extension/src/walletManager/walletManager.ts Outdated Show resolved Hide resolved

AngelCastilloB dismissed mirceahasegan’s stale review via 0b6f25e December 19, 2023 10:12

AngelCastilloB force-pushed the feat/lw-9092-rework-wallet-manager branch from 0b6f25e to d8a92b3 Compare December 19, 2023 10:13

mkazlauskas previously approved these changes Dec 19, 2023

View reviewed changes

mirceahasegan previously approved these changes Dec 19, 2023

View reviewed changes

michalrus dismissed stale reviews from mirceahasegan and mkazlauskas via ccbe550 December 19, 2023 11:45

mkazlauskas requested changes Dec 19, 2023

View reviewed changes

packages/web-extension/src/walletManager/walletManager.ts Outdated Show resolved Hide resolved

packages/web-extension/src/walletManager/walletManager.types.ts Outdated Show resolved Hide resolved

mkazlauskas approved these changes Dec 20, 2023

View reviewed changes

mkazlauskas requested a review from mirceahasegan December 20, 2023 06:05

AngelCastilloB and others added 3 commits December 20, 2023 12:35

doc: update chromedriver dependency instalation instructions

65ecaf8

fix: prefetch chromedriver

44a47cc

mkazlauskas force-pushed the feat/lw-9092-rework-wallet-manager branch from da8d5e2 to 44a47cc Compare December 20, 2023 10:36

mirceahasegan approved these changes Dec 20, 2023

View reviewed changes

mkazlauskas merged commit b9dfbe0 into master Dec 20, 2023

mkazlauskas deleted the feat/lw-9092-rework-wallet-manager branch December 20, 2023 12:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/lw 9092 rework wallet manager #1012

Feat/lw 9092 rework wallet manager #1012

AngelCastilloB commented Dec 7, 2023 •

edited

Loading

github-actions bot commented Dec 7, 2023 •

edited

Loading

mkazlauskas left a comment

mirceahasegan left a comment

mkazlauskas left a comment

mkazlauskas left a comment

mirceahasegan left a comment

Feat/lw 9092 rework wallet manager #1012

Feat/lw 9092 rework wallet manager #1012

Conversation

AngelCastilloB commented Dec 7, 2023 • edited Loading

Context

Proposed Solution

github-actions bot commented Dec 7, 2023 • edited Loading

Standard DiffPost

mkazlauskas left a comment

Choose a reason for hiding this comment

mirceahasegan left a comment

Choose a reason for hiding this comment

mkazlauskas left a comment

Choose a reason for hiding this comment

mkazlauskas left a comment

Choose a reason for hiding this comment

mirceahasegan left a comment

Choose a reason for hiding this comment

AngelCastilloB commented Dec 7, 2023 •

edited

Loading

github-actions bot commented Dec 7, 2023 •

edited

Loading