Skip to content

feat: track cip30 method call origin #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2023
Merged

feat: track cip30 method call origin #1013

merged 1 commit into from
Dec 11, 2023

Conversation

mkazlauskas
Copy link
Member

@mkazlauskas mkazlauskas commented Dec 7, 2023 •
edited
Loading

Context

Current setup loses information about the sender/origin of cip30 method calls

LW-7832

Proposed Solution

  • add a context argument to all cip30 implementation methods and map sender via messaging transformer
  • (BREAKING) replace authenticator 'origin' argument to 'sender'
  • (BREAKING) hoist 'senderOrigin' util to dapp-connector package

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023 •
edited
Loading

Standard DiffPost

This PR would generate the following kubectl diff:

Preview 
diff -u -N /tmp/LIVE-2162394495/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-1754588923/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-2162394495/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2023-12-08 16:19:23.673564138 +0000
+++ /tmp/MERGED-1754588923/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2023-12-08 16:19:23.673564138 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "83"
   creationTimestamp: "2023-08-11T18:16:12Z"
-  generation: 83
+  generation: 84
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2499b5c49563d9870dd2c6bab687bcb1a2fe7427
+    app.kubernetes.io/version: c0044653dbf9d25ee501e0035de42232be4173c6
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
@@ -89,7 +89,7 @@
           value: "false"
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:zpyqxwg0yrjaxldycbgnn3l43gpqb75f
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:1dddr9rh4bd2kp6rfd68qns95p942g1j
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2162394495/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-1754588923/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-2162394495/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-12-08 16:19:23.913564623 +0000
+++ /tmp/MERGED-1754588923/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-12-08 16:19:23.913564623 +0000
@@ -8,7 +8,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2499b5c49563d9870dd2c6bab687bcb1a2fe7427
+    app.kubernetes.io/version: c0044653dbf9d25ee501e0035de42232be4173c6
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-2162394495/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector /tmp/MERGED-1754588923/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector
--- /tmp/LIVE-2162394495/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2023-12-08 16:19:24.149565103 +0000
+++ /tmp/MERGED-1754588923/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2023-12-08 16:19:24.149565103 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "83"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 83
+  generation: 84
   labels:
     app: handle-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2499b5c49563d9870dd2c6bab687bcb1a2fe7427
+    app.kubernetes.io/version: c0044653dbf9d25ee501e0035de42232be4173c6
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-projector
@@ -73,7 +73,7 @@
               name: handle-owner-user.dev-preview-dbsync-db.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: handle
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:zpyqxwg0yrjaxldycbgnn3l43gpqb75f
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:1dddr9rh4bd2kp6rfd68qns95p942g1j
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2162394495/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-1754588923/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-2162394495/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2023-12-08 16:19:24.389565590 +0000
+++ /tmp/MERGED-1754588923/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2023-12-08 16:19:24.389565590 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "50"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 50
+  generation: 51
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2499b5c49563d9870dd2c6bab687bcb1a2fe7427
+    app.kubernetes.io/version: c0044653dbf9d25ee501e0035de42232be4173c6
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
@@ -81,7 +81,7 @@
           value: handle
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:zpyqxwg0yrjaxldycbgnn3l43gpqb75f
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:1dddr9rh4bd2kp6rfd68qns95p942g1j
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2162394495/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker /tmp/MERGED-1754588923/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker
--- /tmp/LIVE-2162394495/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2023-12-08 16:19:24.629566075 +0000
+++ /tmp/MERGED-1754588923/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2023-12-08 16:19:24.629566075 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "83"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 83
+  generation: 84
   labels:
     app: pg-boss-worker
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2499b5c49563d9870dd2c6bab687bcb1a2fe7427
+    app.kubernetes.io/version: c0044653dbf9d25ee501e0035de42232be4173c6
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-pg-boss-worker
@@ -95,7 +95,7 @@
           value: pool-delist-schedule,pool-metadata,pool-metrics,pool-rewards
         - name: STAKE_POOL_PROVIDER_URL
           value: http://dev-preview-cardanojs-backend.dev-preview.svc.cluster.local
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:zpyqxwg0yrjaxldycbgnn3l43gpqb75f
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:1dddr9rh4bd2kp6rfd68qns95p942g1j
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2162394495/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector /tmp/MERGED-1754588923/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector
--- /tmp/LIVE-2162394495/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2023-12-08 16:19:24.877566577 +0000
+++ /tmp/MERGED-1754588923/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2023-12-08 16:19:24.877566577 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "83"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 83
+  generation: 84
   labels:
     app: stake-pool-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2499b5c49563d9870dd2c6bab687bcb1a2fe7427
+    app.kubernetes.io/version: c0044653dbf9d25ee501e0035de42232be4173c6
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-projector
@@ -73,7 +73,7 @@
               name: stakepool-owner-user.dev-preview-dbsync-db.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: stake-pool,stake-pool-metadata-job,stake-pool-metrics-job,stake-pool-rewards-job
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:zpyqxwg0yrjaxldycbgnn3l43gpqb75f
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:1dddr9rh4bd2kp6rfd68qns95p942g1j
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2162394495/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-1754588923/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-2162394495/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2023-12-08 16:19:25.113567058 +0000
+++ /tmp/MERGED-1754588923/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2023-12-08 16:19:25.113567058 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "80"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 80
+  generation: 81
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2499b5c49563d9870dd2c6bab687bcb1a2fe7427
+    app.kubernetes.io/version: c0044653dbf9d25ee501e0035de42232be4173c6
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider
@@ -83,7 +83,7 @@
           value: http://dev-preview-cardano-stack-metadata.dev-preview.svc.cluster.local
         - name: USE_TYPEORM_STAKE_POOL_PROVIDER
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:zpyqxwg0yrjaxldycbgnn3l43gpqb75f
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:1dddr9rh4bd2kp6rfd68qns95p942g1j
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2162394495/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor /tmp/MERGED-1754588923/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor
--- /tmp/LIVE-2162394495/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2023-12-08 16:19:25.353567542 +0000
+++ /tmp/MERGED-1754588923/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2023-12-08 16:19:25.353567542 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2499b5c49563d9870dd2c6bab687bcb1a2fe7427
+    app.kubernetes.io/version: c0044653dbf9d25ee501e0035de42232be4173c6
     instance: primary
   name: lace-backend-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-2162394495/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor /tmp/MERGED-1754588923/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor
--- /tmp/LIVE-2162394495/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2023-12-08 16:19:25.593568026 +0000
+++ /tmp/MERGED-1754588923/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2023-12-08 16:19:25.593568026 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2499b5c49563d9870dd2c6bab687bcb1a2fe7427
+    app.kubernetes.io/version: c0044653dbf9d25ee501e0035de42232be4173c6
     instance: primary
   name: lace-handle-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-2162394495/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor /tmp/MERGED-1754588923/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor
--- /tmp/LIVE-2162394495/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2023-12-08 16:19:25.829568505 +0000
+++ /tmp/MERGED-1754588923/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2023-12-08 16:19:25.829568505 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2499b5c49563d9870dd2c6bab687bcb1a2fe7427
+    app.kubernetes.io/version: c0044653dbf9d25ee501e0035de42232be4173c6
     instance: primary
   name: lace-stake-pool-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-2162394495/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-1754588923/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-2162394495/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2023-12-08 16:19:26.073568999 +0000
+++ /tmp/MERGED-1754588923/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2023-12-08 16:19:26.073568999 +0000
@@ -19,7 +19,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2499b5c49563d9870dd2c6bab687bcb1a2fe7427
+    app.kubernetes.io/version: c0044653dbf9d25ee501e0035de42232be4173c6
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-2162394495/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-1754588923/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-2162394495/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-12-08 16:19:26.329569517 +0000
+++ /tmp/MERGED-1754588923/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-12-08 16:19:26.329569517 +0000
@@ -16,7 +16,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2499b5c49563d9870dd2c6bab687bcb1a2fe7427
+    app.kubernetes.io/version: c0044653dbf9d25ee501e0035de42232be4173c6
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-2162394495/v1.Service.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-1754588923/v1.Service.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-2162394495/v1.Service.dev-preview.dev-preview-cardanojs-backend	2023-12-08 16:19:22.733562235 +0000
+++ /tmp/MERGED-1754588923/v1.Service.dev-preview.dev-preview-cardanojs-backend	2023-12-08 16:19:22.733562235 +0000
@@ -5,7 +5,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2499b5c49563d9870dd2c6bab687bcb1a2fe7427
+    app.kubernetes.io/version: c0044653dbf9d25ee501e0035de42232be4173c6
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-2162394495/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-1754588923/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-2162394495/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-12-08 16:19:22.965562707 +0000
+++ /tmp/MERGED-1754588923/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-12-08 16:19:22.965562707 +0000
@@ -5,7 +5,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2499b5c49563d9870dd2c6bab687bcb1a2fe7427
+    app.kubernetes.io/version: c0044653dbf9d25ee501e0035de42232be4173c6
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-2162394495/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-1754588923/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-2162394495/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2023-12-08 16:19:23.201563183 +0000
+++ /tmp/MERGED-1754588923/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2023-12-08 16:19:23.201563183 +0000
@@ -5,7 +5,7 @@
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2499b5c49563d9870dd2c6bab687bcb1a2fe7427
+    app.kubernetes.io/version: c0044653dbf9d25ee501e0035de42232be4173c6
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
diff -u -N /tmp/LIVE-2162394495/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-1754588923/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-2162394495/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2023-12-08 16:19:23.433563652 +0000
+++ /tmp/MERGED-1754588923/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2023-12-08 16:19:23.433563652 +0000
@@ -5,7 +5,7 @@
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 2499b5c49563d9870dd2c6bab687bcb1a2fe7427
+    app.kubernetes.io/version: c0044653dbf9d25ee501e0035de42232be4173c6
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider

AngelCastilloB
AngelCastilloB previously approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@AngelCastilloB AngelCastilloB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @mkazlauskas 🚀

@mkazlauskas
feat: track cip30 method call origin & update Authenticator api
75c8af6 
add optional 'sender' properties to sign method props,
as well as cip30 callbacks

BREAKING CHANGE: replace authenticator 'origin' argument to 'sender'
- hoist 'senderOrigin' util to dapp-connector package
@mkazlauskas mkazlauskas force-pushed the feat/track-cip30-origin branch from e316698 to 75c8af6 Compare December 8, 2023 16:06
@mkazlauskas mkazlauskas merged commit 6c96c83 into master Dec 11, 2023
@mkazlauskas mkazlauskas deleted the feat/track-cip30-origin branch December 11, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchappell mchappell mchappell approved these changes

@AngelCastilloB AngelCastilloB AngelCastilloB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkazlauskas @mchappell @AngelCastilloB