Skip to content

chore: consistent object create and remove todo #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2023
Merged

chore: consistent object create and remove todo #1020

merged 1 commit into from
Dec 15, 2023

Conversation

mirceahasegan
Copy link
Contributor

Context

Two comments were not addressed in the original PR,
so I am addressing them here.

@mirceahasegan mirceahasegan requested review from mkazlauskas, a team and iccicci December 12, 2023 15:56
iccicci
iccicci approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@iccicci iccicci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions GitHub Actions
Copy link

Standard DiffPost

This PR would generate the following kubectl diff:

Preview 
diff -u -N /tmp/LIVE-987951461/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-1965874075/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-987951461/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2023-12-12 16:09:44.420934344 +0000
+++ /tmp/MERGED-1965874075/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2023-12-12 16:09:44.420934344 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "84"
   creationTimestamp: "2023-08-11T18:16:12Z"
-  generation: 84
+  generation: 85
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 6c96c835f2578492c96e137ac3d9d5e33b9c390b
+    app.kubernetes.io/version: 365a7519a6b223624d171c938e0978c162ac8c5b
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
@@ -89,7 +89,7 @@
           value: "false"
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:mh29mcjnfw1b41n00gxjvylfwpmhax25
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:l46cn68mmyp5znr50agb32nadmv5qxf2
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-987951461/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-1965874075/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-987951461/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-12-12 16:09:44.624934548 +0000
+++ /tmp/MERGED-1965874075/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-12-12 16:09:44.624934548 +0000
@@ -8,7 +8,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 6c96c835f2578492c96e137ac3d9d5e33b9c390b
+    app.kubernetes.io/version: 365a7519a6b223624d171c938e0978c162ac8c5b
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-987951461/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector /tmp/MERGED-1965874075/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector
--- /tmp/LIVE-987951461/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2023-12-12 16:09:44.824934749 +0000
+++ /tmp/MERGED-1965874075/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2023-12-12 16:09:44.824934749 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "84"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 84
+  generation: 85
   labels:
     app: handle-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 6c96c835f2578492c96e137ac3d9d5e33b9c390b
+    app.kubernetes.io/version: 365a7519a6b223624d171c938e0978c162ac8c5b
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-projector
@@ -73,7 +73,7 @@
               name: handle-owner-user.dev-preview-dbsync-db.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: handle
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:mh29mcjnfw1b41n00gxjvylfwpmhax25
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:l46cn68mmyp5znr50agb32nadmv5qxf2
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-987951461/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-1965874075/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-987951461/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2023-12-12 16:09:45.036934962 +0000
+++ /tmp/MERGED-1965874075/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2023-12-12 16:09:45.036934962 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "51"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 51
+  generation: 52
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 6c96c835f2578492c96e137ac3d9d5e33b9c390b
+    app.kubernetes.io/version: 365a7519a6b223624d171c938e0978c162ac8c5b
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
@@ -81,7 +81,7 @@
           value: handle
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:mh29mcjnfw1b41n00gxjvylfwpmhax25
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:l46cn68mmyp5znr50agb32nadmv5qxf2
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-987951461/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker /tmp/MERGED-1965874075/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker
--- /tmp/LIVE-987951461/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2023-12-12 16:09:45.244935169 +0000
+++ /tmp/MERGED-1965874075/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2023-12-12 16:09:45.244935169 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "84"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 84
+  generation: 85
   labels:
     app: pg-boss-worker
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 6c96c835f2578492c96e137ac3d9d5e33b9c390b
+    app.kubernetes.io/version: 365a7519a6b223624d171c938e0978c162ac8c5b
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-pg-boss-worker
@@ -95,7 +95,7 @@
           value: pool-delist-schedule,pool-metadata,pool-metrics,pool-rewards
         - name: STAKE_POOL_PROVIDER_URL
           value: http://dev-preview-cardanojs-backend.dev-preview.svc.cluster.local
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:mh29mcjnfw1b41n00gxjvylfwpmhax25
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:l46cn68mmyp5znr50agb32nadmv5qxf2
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-987951461/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector /tmp/MERGED-1965874075/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector
--- /tmp/LIVE-987951461/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2023-12-12 16:09:45.452935378 +0000
+++ /tmp/MERGED-1965874075/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2023-12-12 16:09:45.452935378 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "84"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 84
+  generation: 85
   labels:
     app: stake-pool-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 6c96c835f2578492c96e137ac3d9d5e33b9c390b
+    app.kubernetes.io/version: 365a7519a6b223624d171c938e0978c162ac8c5b
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-projector
@@ -73,7 +73,7 @@
               name: stakepool-owner-user.dev-preview-dbsync-db.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: stake-pool,stake-pool-metadata-job,stake-pool-metrics-job,stake-pool-rewards-job
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:mh29mcjnfw1b41n00gxjvylfwpmhax25
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:l46cn68mmyp5znr50agb32nadmv5qxf2
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-987951461/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-1965874075/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-987951461/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2023-12-12 16:09:45.656935581 +0000
+++ /tmp/MERGED-1965874075/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2023-12-12 16:09:45.656935581 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "81"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 81
+  generation: 82
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 6c96c835f2578492c96e137ac3d9d5e33b9c390b
+    app.kubernetes.io/version: 365a7519a6b223624d171c938e0978c162ac8c5b
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider
@@ -83,7 +83,7 @@
           value: http://dev-preview-cardano-stack-metadata.dev-preview.svc.cluster.local
         - name: USE_TYPEORM_STAKE_POOL_PROVIDER
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:mh29mcjnfw1b41n00gxjvylfwpmhax25
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:l46cn68mmyp5znr50agb32nadmv5qxf2
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-987951461/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor /tmp/MERGED-1965874075/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor
--- /tmp/LIVE-987951461/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2023-12-12 16:09:45.864935789 +0000
+++ /tmp/MERGED-1965874075/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2023-12-12 16:09:45.864935789 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 6c96c835f2578492c96e137ac3d9d5e33b9c390b
+    app.kubernetes.io/version: 365a7519a6b223624d171c938e0978c162ac8c5b
     instance: primary
   name: lace-backend-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-987951461/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor /tmp/MERGED-1965874075/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor
--- /tmp/LIVE-987951461/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2023-12-12 16:09:46.068935991 +0000
+++ /tmp/MERGED-1965874075/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2023-12-12 16:09:46.068935991 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 6c96c835f2578492c96e137ac3d9d5e33b9c390b
+    app.kubernetes.io/version: 365a7519a6b223624d171c938e0978c162ac8c5b
     instance: primary
   name: lace-handle-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-987951461/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor /tmp/MERGED-1965874075/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor
--- /tmp/LIVE-987951461/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2023-12-12 16:09:46.272936194 +0000
+++ /tmp/MERGED-1965874075/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2023-12-12 16:09:46.272936194 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 6c96c835f2578492c96e137ac3d9d5e33b9c390b
+    app.kubernetes.io/version: 365a7519a6b223624d171c938e0978c162ac8c5b
     instance: primary
   name: lace-stake-pool-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-987951461/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-1965874075/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-987951461/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2023-12-12 16:09:46.488936414 +0000
+++ /tmp/MERGED-1965874075/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2023-12-12 16:09:46.488936414 +0000
@@ -19,7 +19,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 6c96c835f2578492c96e137ac3d9d5e33b9c390b
+    app.kubernetes.io/version: 365a7519a6b223624d171c938e0978c162ac8c5b
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-987951461/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-1965874075/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-987951461/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-12-12 16:09:46.692936619 +0000
+++ /tmp/MERGED-1965874075/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-12-12 16:09:46.692936619 +0000
@@ -16,7 +16,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 6c96c835f2578492c96e137ac3d9d5e33b9c390b
+    app.kubernetes.io/version: 365a7519a6b223624d171c938e0978c162ac8c5b
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-987951461/v1.Service.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-1965874075/v1.Service.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-987951461/v1.Service.dev-preview.dev-preview-cardanojs-backend	2023-12-12 16:09:43.616933540 +0000
+++ /tmp/MERGED-1965874075/v1.Service.dev-preview.dev-preview-cardanojs-backend	2023-12-12 16:09:43.616933540 +0000
@@ -5,7 +5,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 6c96c835f2578492c96e137ac3d9d5e33b9c390b
+    app.kubernetes.io/version: 365a7519a6b223624d171c938e0978c162ac8c5b
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-987951461/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-1965874075/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-987951461/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-12-12 16:09:43.812933736 +0000
+++ /tmp/MERGED-1965874075/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-12-12 16:09:43.812933736 +0000
@@ -5,7 +5,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 6c96c835f2578492c96e137ac3d9d5e33b9c390b
+    app.kubernetes.io/version: 365a7519a6b223624d171c938e0978c162ac8c5b
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-987951461/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-1965874075/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-987951461/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2023-12-12 16:09:44.016933940 +0000
+++ /tmp/MERGED-1965874075/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2023-12-12 16:09:44.016933940 +0000
@@ -5,7 +5,7 @@
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 6c96c835f2578492c96e137ac3d9d5e33b9c390b
+    app.kubernetes.io/version: 365a7519a6b223624d171c938e0978c162ac8c5b
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
diff -u -N /tmp/LIVE-987951461/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-1965874075/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-987951461/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2023-12-12 16:09:44.212934137 +0000
+++ /tmp/MERGED-1965874075/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2023-12-12 16:09:44.212934137 +0000
@@ -5,7 +5,7 @@
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 6c96c835f2578492c96e137ac3d9d5e33b9c390b
+    app.kubernetes.io/version: 365a7519a6b223624d171c938e0978c162ac8c5b
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider

@mirceahasegan mirceahasegan merged commit bafa161 into master Dec 15, 2023
@mirceahasegan mirceahasegan deleted the feat/lw-9128-leftovers branch December 15, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iccicci iccicci iccicci approved these changes

@mkazlauskas mkazlauskas mkazlauskas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mirceahasegan @iccicci @mkazlauskas