Skip to content

LW-8949 rework cli argument parsing and relative tests #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2024
Merged

LW-8949 rework cli argument parsing and relative tests #1098

merged 1 commit into from
Feb 19, 2024

Conversation

iccicci
Copy link
Collaborator

@iccicci iccicci commented Feb 15, 2024

Context

CLI tests was using a mock ogmios server. The introduction of ogmios 6 made our mock server no longer compatible so CLI tests was disabled.

Proposed Solution

Reworked the CLI tests to just dump the result of argument parsing (except from some few cases) so they no longer require the ogmios mock server.

Important Changes Introduced

  • refactored/added some validators to increase output verbosity;
  • moved healthCheckCacheTtl from withCommonOptions to start-provider-server being dedicated to the latter;
  • fixed the description for tokenMetadataRequestTimeout;
  • removed a couple of checks at runtime as they was checking for required options;
  • excluded cli.test.ts from yarn test;
  • added yarn test:cli to run cli.test.ts (added to CI as well);

@github-actions GitHub Actions
Copy link

Standard DiffPost

This PR would generate the following kubectl diff:

Preview 
diff -u -N /tmp/LIVE-1872567518/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-2240008625/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-1872567518/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2024-02-15 15:43:39.608449129 +0000
+++ /tmp/MERGED-2240008625/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2024-02-15 15:43:39.608449129 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "9"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 9
+  generation: 10
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 02d17d4feab580f08d9e1428c8552f02c69dbd02
+    app.kubernetes.io/version: 4da905d438abfc7dcd9cb7c3acb5e9c18fcc719c
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
@@ -89,7 +89,7 @@
           value: http://dev-preview-cardano-stack-metadata.dev-preview.svc.cluster.local
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:1aif03mbdzd4mry2p9cvnzjhxdw8cy1r
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:hfkd5m2p9ymq91l9jmg5mv50cniq4xkj
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-1872567518/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker /tmp/MERGED-2240008625/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker
--- /tmp/LIVE-1872567518/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker	2024-02-15 15:43:39.736449611 +0000
+++ /tmp/MERGED-2240008625/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker	2024-02-15 15:43:39.736449611 +0000
@@ -8,7 +8,7 @@
   labels:
     app: blockfrost-worker
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 02d17d4feab580f08d9e1428c8552f02c69dbd02
+    app.kubernetes.io/version: 4da905d438abfc7dcd9cb7c3acb5e9c18fcc719c
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-blockfrost-worker
diff -u -N /tmp/LIVE-1872567518/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-2240008625/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-1872567518/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-15 15:43:39.864450093 +0000
+++ /tmp/MERGED-2240008625/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-15 15:43:39.864450093 +0000
@@ -8,7 +8,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 02d17d4feab580f08d9e1428c8552f02c69dbd02
+    app.kubernetes.io/version: 4da905d438abfc7dcd9cb7c3acb5e9c18fcc719c
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-1872567518/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector /tmp/MERGED-2240008625/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector
--- /tmp/LIVE-1872567518/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2024-02-15 15:43:39.992450574 +0000
+++ /tmp/MERGED-2240008625/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2024-02-15 15:43:39.992450574 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "9"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 9
+  generation: 10
   labels:
     app: handle-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 02d17d4feab580f08d9e1428c8552f02c69dbd02
+    app.kubernetes.io/version: 4da905d438abfc7dcd9cb7c3acb5e9c18fcc719c
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-projector
@@ -73,7 +73,7 @@
               name: handle-owner-user.dev-preview-postgresql.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: handle
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:1aif03mbdzd4mry2p9cvnzjhxdw8cy1r
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:hfkd5m2p9ymq91l9jmg5mv50cniq4xkj
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-1872567518/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-2240008625/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-1872567518/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-15 15:43:40.120451056 +0000
+++ /tmp/MERGED-2240008625/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-15 15:43:40.124451072 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "9"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 9
+  generation: 10
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 02d17d4feab580f08d9e1428c8552f02c69dbd02
+    app.kubernetes.io/version: 4da905d438abfc7dcd9cb7c3acb5e9c18fcc719c
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
@@ -81,7 +81,7 @@
           value: handle
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:1aif03mbdzd4mry2p9cvnzjhxdw8cy1r
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:hfkd5m2p9ymq91l9jmg5mv50cniq4xkj
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-1872567518/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker /tmp/MERGED-2240008625/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker
--- /tmp/LIVE-1872567518/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2024-02-15 15:43:40.252451552 +0000
+++ /tmp/MERGED-2240008625/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2024-02-15 15:43:40.252451552 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "9"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 9
+  generation: 10
   labels:
     app: pg-boss-worker
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 02d17d4feab580f08d9e1428c8552f02c69dbd02
+    app.kubernetes.io/version: 4da905d438abfc7dcd9cb7c3acb5e9c18fcc719c
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-pg-boss-worker
@@ -97,7 +97,7 @@
           value: https://smash.cardano-mainnet.iohk.io/api/v1
         - name: STAKE_POOL_PROVIDER_URL
           value: http://dev-preview-cardanojs-backend.dev-preview.svc.cluster.local
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:1aif03mbdzd4mry2p9cvnzjhxdw8cy1r
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:hfkd5m2p9ymq91l9jmg5mv50cniq4xkj
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-1872567518/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector /tmp/MERGED-2240008625/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector
--- /tmp/LIVE-1872567518/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2024-02-15 15:43:40.376452019 +0000
+++ /tmp/MERGED-2240008625/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2024-02-15 15:43:40.380452034 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "9"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 9
+  generation: 10
   labels:
     app: stake-pool-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 02d17d4feab580f08d9e1428c8552f02c69dbd02
+    app.kubernetes.io/version: 4da905d438abfc7dcd9cb7c3acb5e9c18fcc719c
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-projector
@@ -73,7 +73,7 @@
               name: stakepool-owner-user.dev-preview-postgresql.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: stake-pool,stake-pool-metadata-job,stake-pool-metrics-job,stake-pool-rewards-job
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:1aif03mbdzd4mry2p9cvnzjhxdw8cy1r
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:hfkd5m2p9ymq91l9jmg5mv50cniq4xkj
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-1872567518/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-2240008625/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-1872567518/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-15 15:43:40.508452517 +0000
+++ /tmp/MERGED-2240008625/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-15 15:43:40.508452517 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "9"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 9
+  generation: 10
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 02d17d4feab580f08d9e1428c8552f02c69dbd02
+    app.kubernetes.io/version: 4da905d438abfc7dcd9cb7c3acb5e9c18fcc719c
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider
@@ -83,7 +83,7 @@
           value: http://dev-preview-cardano-stack-metadata.dev-preview.svc.cluster.local
         - name: USE_TYPEORM_STAKE_POOL_PROVIDER
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:1aif03mbdzd4mry2p9cvnzjhxdw8cy1r
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:hfkd5m2p9ymq91l9jmg5mv50cniq4xkj
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-1872567518/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor /tmp/MERGED-2240008625/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor
--- /tmp/LIVE-1872567518/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2024-02-15 15:43:40.636452998 +0000
+++ /tmp/MERGED-2240008625/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2024-02-15 15:43:40.636452998 +0000
@@ -5,7 +5,7 @@
   generation: 1
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 02d17d4feab580f08d9e1428c8552f02c69dbd02
+    app.kubernetes.io/version: 4da905d438abfc7dcd9cb7c3acb5e9c18fcc719c
     instance: primary
   name: lace-backend-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-1872567518/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor /tmp/MERGED-2240008625/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor
--- /tmp/LIVE-1872567518/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2024-02-15 15:43:40.760453464 +0000
+++ /tmp/MERGED-2240008625/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2024-02-15 15:43:40.760453464 +0000
@@ -5,7 +5,7 @@
   generation: 1
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 02d17d4feab580f08d9e1428c8552f02c69dbd02
+    app.kubernetes.io/version: 4da905d438abfc7dcd9cb7c3acb5e9c18fcc719c
     instance: primary
   name: lace-handle-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-1872567518/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor /tmp/MERGED-2240008625/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor
--- /tmp/LIVE-1872567518/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2024-02-15 15:43:40.888453945 +0000
+++ /tmp/MERGED-2240008625/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2024-02-15 15:43:40.888453945 +0000
@@ -5,7 +5,7 @@
   generation: 1
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 02d17d4feab580f08d9e1428c8552f02c69dbd02
+    app.kubernetes.io/version: 4da905d438abfc7dcd9cb7c3acb5e9c18fcc719c
     instance: primary
   name: lace-stake-pool-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-1872567518/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-2240008625/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-1872567518/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2024-02-15 15:43:41.020454442 +0000
+++ /tmp/MERGED-2240008625/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2024-02-15 15:43:41.020454442 +0000
@@ -20,7 +20,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 02d17d4feab580f08d9e1428c8552f02c69dbd02
+    app.kubernetes.io/version: 4da905d438abfc7dcd9cb7c3acb5e9c18fcc719c
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-1872567518/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-2240008625/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-1872567518/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-15 15:43:41.148454925 +0000
+++ /tmp/MERGED-2240008625/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-15 15:43:41.148454925 +0000
@@ -18,7 +18,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 02d17d4feab580f08d9e1428c8552f02c69dbd02
+    app.kubernetes.io/version: 4da905d438abfc7dcd9cb7c3acb5e9c18fcc719c
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-1872567518/v1.Service.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-2240008625/v1.Service.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-1872567518/v1.Service.dev-preview.dev-preview-cardanojs-backend	2024-02-15 15:43:39.108447247 +0000
+++ /tmp/MERGED-2240008625/v1.Service.dev-preview.dev-preview-cardanojs-backend	2024-02-15 15:43:39.108447247 +0000
@@ -5,7 +5,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 02d17d4feab580f08d9e1428c8552f02c69dbd02
+    app.kubernetes.io/version: 4da905d438abfc7dcd9cb7c3acb5e9c18fcc719c
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-1872567518/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-2240008625/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-1872567518/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-15 15:43:39.232447714 +0000
+++ /tmp/MERGED-2240008625/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-15 15:43:39.232447714 +0000
@@ -5,7 +5,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 02d17d4feab580f08d9e1428c8552f02c69dbd02
+    app.kubernetes.io/version: 4da905d438abfc7dcd9cb7c3acb5e9c18fcc719c
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-1872567518/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-2240008625/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-1872567518/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-15 15:43:39.356448180 +0000
+++ /tmp/MERGED-2240008625/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-15 15:43:39.356448180 +0000
@@ -5,7 +5,7 @@
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 02d17d4feab580f08d9e1428c8552f02c69dbd02
+    app.kubernetes.io/version: 4da905d438abfc7dcd9cb7c3acb5e9c18fcc719c
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
diff -u -N /tmp/LIVE-1872567518/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-2240008625/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-1872567518/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-15 15:43:39.476448634 +0000
+++ /tmp/MERGED-2240008625/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-15 15:43:39.476448634 +0000
@@ -5,7 +5,7 @@
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 02d17d4feab580f08d9e1428c8552f02c69dbd02
+    app.kubernetes.io/version: 4da905d438abfc7dcd9cb7c3acb5e9c18fcc719c
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider

mirceahasegan
mirceahasegan approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@mirceahasegan mirceahasegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work , @iccicci ! 🚀

mkazlauskas
mkazlauskas approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@mkazlauskas mkazlauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀

@iccicci iccicci merged commit 3e440ab into master Feb 19, 2024
@iccicci iccicci deleted the test/LW-8949-rework-cli-tests branch February 19, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkazlauskas mkazlauskas mkazlauskas approved these changes

@mirceahasegan mirceahasegan mirceahasegan approved these changes

@rhyslbw rhyslbw Awaiting requested review from rhyslbw

@mchappell mchappell Awaiting requested review from mchappell

@pczeglik-iohk pczeglik-iohk Awaiting requested review from pczeglik-iohk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iccicci @mkazlauskas @mirceahasegan