Skip to content

feat(tx-construction): add customizeCb to GenericTxBuilder #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2024
Merged

feat(tx-construction): add customizeCb to GenericTxBuilder #1099

merged 2 commits into from
Feb 20, 2024

Conversation

mirceahasegan
Copy link
Contributor

Context

Implement a method that would allow users of TxBuilder to update the transaction body.
For example, a user could build and insert a certificate, allowing the user to leverage the input selection, fee calculation, etc, even if TxBuilder does not have a high-level API to support adding that certificate.

Non-goal: guard users against malformed/incorrect transactions.
For example: users could potentially modify the certificates already added by the txbuilder for staking distribution.

Proposed Solution

Add a customize method to TxBuilder. The callback passed into customize will be called on transaction build, before input selection is performed.

Important Changes Introduced

@mirceahasegan mirceahasegan marked this pull request as draft February 19, 2024 14:33
@mirceahasegan mirceahasegan marked this pull request as ready for review February 19, 2024 14:34
@mirceahasegan mirceahasegan self-assigned this Feb 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 19, 2024 •
edited
Loading

Standard DiffPost

This PR would generate the following kubectl diff:

Preview 
diff -u -N /tmp/LIVE-2464423933/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-4259646781/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-2464423933/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2024-02-20 14:46:21.988772844 +0000
+++ /tmp/MERGED-4259646781/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2024-02-20 14:46:21.988772844 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "10"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 10
+  generation: 11
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 3e440ab2cc2c399bece5fe4c29805da1fe3ca669
+    app.kubernetes.io/version: 598724fd3dd3f48e35603329e9a22a9d71970ea0
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
@@ -89,7 +89,7 @@
           value: http://dev-preview-cardano-stack-metadata.dev-preview.svc.cluster.local
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:rigkcpf0nickcrp9yf95qlrbh23lgas7
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:z2mlm1cbsiaxcvzlp8vxbr5dx5pbcx4p
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2464423933/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker /tmp/MERGED-4259646781/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker
--- /tmp/LIVE-2464423933/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker	2024-02-20 14:46:22.012772833 +0000
+++ /tmp/MERGED-4259646781/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker	2024-02-20 14:46:22.016772830 +0000
@@ -8,7 +8,7 @@
   labels:
     app: blockfrost-worker
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 3e440ab2cc2c399bece5fe4c29805da1fe3ca669
+    app.kubernetes.io/version: 598724fd3dd3f48e35603329e9a22a9d71970ea0
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-blockfrost-worker
diff -u -N /tmp/LIVE-2464423933/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-4259646781/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-2464423933/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-20 14:46:22.044772817 +0000
+++ /tmp/MERGED-4259646781/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-20 14:46:22.044772817 +0000
@@ -8,7 +8,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 3e440ab2cc2c399bece5fe4c29805da1fe3ca669
+    app.kubernetes.io/version: 598724fd3dd3f48e35603329e9a22a9d71970ea0
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-2464423933/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector /tmp/MERGED-4259646781/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector
--- /tmp/LIVE-2464423933/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2024-02-20 14:46:22.072772804 +0000
+++ /tmp/MERGED-4259646781/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2024-02-20 14:46:22.072772804 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "10"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 10
+  generation: 11
   labels:
     app: handle-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 3e440ab2cc2c399bece5fe4c29805da1fe3ca669
+    app.kubernetes.io/version: 598724fd3dd3f48e35603329e9a22a9d71970ea0
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-projector
@@ -73,7 +73,7 @@
               name: handle-owner-user.dev-preview-postgresql.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: handle
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:rigkcpf0nickcrp9yf95qlrbh23lgas7
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:z2mlm1cbsiaxcvzlp8vxbr5dx5pbcx4p
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2464423933/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-4259646781/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-2464423933/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-20 14:46:22.100772790 +0000
+++ /tmp/MERGED-4259646781/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-20 14:46:22.104772788 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "10"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 10
+  generation: 11
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 3e440ab2cc2c399bece5fe4c29805da1fe3ca669
+    app.kubernetes.io/version: 598724fd3dd3f48e35603329e9a22a9d71970ea0
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
@@ -81,7 +81,7 @@
           value: handle
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:rigkcpf0nickcrp9yf95qlrbh23lgas7
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:z2mlm1cbsiaxcvzlp8vxbr5dx5pbcx4p
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2464423933/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker /tmp/MERGED-4259646781/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker
--- /tmp/LIVE-2464423933/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2024-02-20 14:46:22.132772775 +0000
+++ /tmp/MERGED-4259646781/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2024-02-20 14:46:22.132772775 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "10"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 10
+  generation: 11
   labels:
     app: pg-boss-worker
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 3e440ab2cc2c399bece5fe4c29805da1fe3ca669
+    app.kubernetes.io/version: 598724fd3dd3f48e35603329e9a22a9d71970ea0
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-pg-boss-worker
@@ -97,7 +97,7 @@
           value: https://smash.cardano-mainnet.iohk.io/api/v1
         - name: STAKE_POOL_PROVIDER_URL
           value: http://dev-preview-cardanojs-backend.dev-preview.svc.cluster.local
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:rigkcpf0nickcrp9yf95qlrbh23lgas7
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:z2mlm1cbsiaxcvzlp8vxbr5dx5pbcx4p
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2464423933/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector /tmp/MERGED-4259646781/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector
--- /tmp/LIVE-2464423933/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2024-02-20 14:46:22.160772762 +0000
+++ /tmp/MERGED-4259646781/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2024-02-20 14:46:22.160772762 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "10"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 10
+  generation: 11
   labels:
     app: stake-pool-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 3e440ab2cc2c399bece5fe4c29805da1fe3ca669
+    app.kubernetes.io/version: 598724fd3dd3f48e35603329e9a22a9d71970ea0
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-projector
@@ -73,7 +73,7 @@
               name: stakepool-owner-user.dev-preview-postgresql.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: stake-pool,stake-pool-metadata-job,stake-pool-metrics-job,stake-pool-rewards-job
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:rigkcpf0nickcrp9yf95qlrbh23lgas7
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:z2mlm1cbsiaxcvzlp8vxbr5dx5pbcx4p
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2464423933/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-4259646781/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-2464423933/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-20 14:46:22.184772750 +0000
+++ /tmp/MERGED-4259646781/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-20 14:46:22.188772748 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "10"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 10
+  generation: 11
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 3e440ab2cc2c399bece5fe4c29805da1fe3ca669
+    app.kubernetes.io/version: 598724fd3dd3f48e35603329e9a22a9d71970ea0
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider
@@ -83,7 +83,7 @@
           value: http://dev-preview-cardano-stack-metadata.dev-preview.svc.cluster.local
         - name: USE_TYPEORM_STAKE_POOL_PROVIDER
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:rigkcpf0nickcrp9yf95qlrbh23lgas7
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:z2mlm1cbsiaxcvzlp8vxbr5dx5pbcx4p
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2464423933/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor /tmp/MERGED-4259646781/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor
--- /tmp/LIVE-2464423933/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2024-02-20 14:46:22.216772735 +0000
+++ /tmp/MERGED-4259646781/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2024-02-20 14:46:22.216772735 +0000
@@ -5,7 +5,7 @@
   generation: 1
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 3e440ab2cc2c399bece5fe4c29805da1fe3ca669
+    app.kubernetes.io/version: 598724fd3dd3f48e35603329e9a22a9d71970ea0
     instance: primary
   name: lace-backend-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-2464423933/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor /tmp/MERGED-4259646781/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor
--- /tmp/LIVE-2464423933/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2024-02-20 14:46:22.244772722 +0000
+++ /tmp/MERGED-4259646781/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2024-02-20 14:46:22.244772722 +0000
@@ -5,7 +5,7 @@
   generation: 1
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 3e440ab2cc2c399bece5fe4c29805da1fe3ca669
+    app.kubernetes.io/version: 598724fd3dd3f48e35603329e9a22a9d71970ea0
     instance: primary
   name: lace-handle-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-2464423933/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor /tmp/MERGED-4259646781/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor
--- /tmp/LIVE-2464423933/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2024-02-20 14:46:22.268772710 +0000
+++ /tmp/MERGED-4259646781/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2024-02-20 14:46:22.268772710 +0000
@@ -5,7 +5,7 @@
   generation: 1
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 3e440ab2cc2c399bece5fe4c29805da1fe3ca669
+    app.kubernetes.io/version: 598724fd3dd3f48e35603329e9a22a9d71970ea0
     instance: primary
   name: lace-stake-pool-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-2464423933/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-4259646781/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-2464423933/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2024-02-20 14:46:22.312772690 +0000
+++ /tmp/MERGED-4259646781/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2024-02-20 14:46:22.312772690 +0000
@@ -20,7 +20,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 3e440ab2cc2c399bece5fe4c29805da1fe3ca669
+    app.kubernetes.io/version: 598724fd3dd3f48e35603329e9a22a9d71970ea0
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-2464423933/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-4259646781/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-2464423933/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-20 14:46:22.340772676 +0000
+++ /tmp/MERGED-4259646781/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-20 14:46:22.340772676 +0000
@@ -18,7 +18,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 3e440ab2cc2c399bece5fe4c29805da1fe3ca669
+    app.kubernetes.io/version: 598724fd3dd3f48e35603329e9a22a9d71970ea0
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-2464423933/v1.Service.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-4259646781/v1.Service.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-2464423933/v1.Service.dev-preview.dev-preview-cardanojs-backend	2024-02-20 14:46:21.880772895 +0000
+++ /tmp/MERGED-4259646781/v1.Service.dev-preview.dev-preview-cardanojs-backend	2024-02-20 14:46:21.880772895 +0000
@@ -5,7 +5,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 3e440ab2cc2c399bece5fe4c29805da1fe3ca669
+    app.kubernetes.io/version: 598724fd3dd3f48e35603329e9a22a9d71970ea0
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-2464423933/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-4259646781/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-2464423933/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-20 14:46:21.904772883 +0000
+++ /tmp/MERGED-4259646781/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-20 14:46:21.904772883 +0000
@@ -5,7 +5,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 3e440ab2cc2c399bece5fe4c29805da1fe3ca669
+    app.kubernetes.io/version: 598724fd3dd3f48e35603329e9a22a9d71970ea0
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-2464423933/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-4259646781/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-2464423933/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-20 14:46:21.932772870 +0000
+++ /tmp/MERGED-4259646781/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-20 14:46:21.932772870 +0000
@@ -5,7 +5,7 @@
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 3e440ab2cc2c399bece5fe4c29805da1fe3ca669
+    app.kubernetes.io/version: 598724fd3dd3f48e35603329e9a22a9d71970ea0
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
diff -u -N /tmp/LIVE-2464423933/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-4259646781/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-2464423933/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-20 14:46:21.960772856 +0000
+++ /tmp/MERGED-4259646781/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-20 14:46:21.960772856 +0000
@@ -5,7 +5,7 @@
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 3e440ab2cc2c399bece5fe4c29805da1fe3ca669
+    app.kubernetes.io/version: 598724fd3dd3f48e35603329e9a22a9d71970ea0
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider

iccicci
iccicci previously approved these changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@iccicci iccicci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!

I couldn't refrain from some comments... but feel free to ignore my fanaticism 😉

@AngelCastilloB AngelCastilloB force-pushed the feat/lw-9795-txbuilder-patch-functionality branch from b5e7e66 to fa1e555 Compare February 20, 2024 11:16
mkazlauskas
mkazlauskas approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@mkazlauskas mkazlauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀

@mirceahasegan mirceahasegan force-pushed the feat/lw-9795-txbuilder-patch-functionality branch from 083a766 to 8ec646a Compare February 20, 2024 14:41
@mirceahasegan mirceahasegan merged commit 8afbd79 into master Feb 20, 2024
@mirceahasegan mirceahasegan deleted the feat/lw-9795-txbuilder-patch-functionality branch February 20, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iccicci iccicci iccicci approved these changes

@mkazlauskas mkazlauskas mkazlauskas approved these changes

@rhyslbw rhyslbw Awaiting requested review from rhyslbw

@AngelCastilloB AngelCastilloB Awaiting requested review from AngelCastilloB

Assignees

@mirceahasegan mirceahasegan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mirceahasegan @iccicci @mkazlauskas @AngelCastilloB