Skip to content

fix(core): transaction body can now serializes bodies with no inputs correctly #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 29, 2024
Merged

fix(core): transaction body can now serializes bodies with no inputs correctly #1117

merged 1 commit into from
Feb 29, 2024

Conversation

AngelCastilloB
Copy link
Member

@AngelCastilloB AngelCastilloB commented Feb 29, 2024 •
edited
Loading

Context

There is a bug in the transaction body serialization logic which causes incorrect CBOR to be produced if there are no inputs in the transaction.

Proposed Solution

Fix the bug

@AngelCastilloB AngelCastilloB requested a review from a team February 29, 2024 04:49
@github-actions GitHub Actions
Copy link

Standard DiffPost

This PR would generate the following kubectl diff:

Preview 
diff -u -N /tmp/LIVE-741892705/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-650451629/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-741892705/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2024-02-29 05:07:40.576706486 +0000
+++ /tmp/MERGED-650451629/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2024-02-29 05:07:40.576706486 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "14"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 14
+  generation: 15
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: b9880480745ed23edaf686c1f77b7c6904b015a0
+    app.kubernetes.io/version: d5b269162a7eab9e8d7b13298f953e91378d0505
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
@@ -90,8 +90,8 @@
         - name: USE_KORA_LABS
           value: "true"
         - name: BUILD_INFO
-          value: '{"extra":{"narHash":"sha256-YhTMPD39gcCVPuygV2d0vroeeBvR1P/8LOh/xjbcsMo=","path":"/nix/store/0d9hwrcapkvpl2g8r3z089a2lkddanw1-source","sourceInfo":"/nix/store/0d9hwrcapkvpl2g8r3z089a2lkddanw1-source"},"lastModified":1708688536,"lastModifiedDate":"20240223114216","rev":"b9880480745ed23edaf686c1f77b7c6904b015a0","shortRev":"b988048"}'
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:4mr99h0dkq2zy5jjsh2dvv3p18n90qkp
+          value: '{"extra":{"narHash":"sha256-1ghy5vdVhVlEhKelD09sGUQ3KtXuPzG8eiE17fr/gKs=","path":"/nix/store/cpgw4jf9yaczlz0c9i8qnqxgm8p5gs0c-source","sourceInfo":"/nix/store/cpgw4jf9yaczlz0c9i8qnqxgm8p5gs0c-source"},"lastModified":1709182119,"lastModifiedDate":"20240229044839","rev":"d5b269162a7eab9e8d7b13298f953e91378d0505","shortRev":"d5b2691"}'
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:fjm71ad0m4czv2kjyw8mrwndm8pkh4fh
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-741892705/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker /tmp/MERGED-650451629/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker
--- /tmp/LIVE-741892705/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker	2024-02-29 05:07:40.720705805 +0000
+++ /tmp/MERGED-650451629/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-blockfrost-worker	2024-02-29 05:07:40.724705786 +0000
@@ -8,7 +8,7 @@
   labels:
     app: blockfrost-worker
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: b9880480745ed23edaf686c1f77b7c6904b015a0
+    app.kubernetes.io/version: d5b269162a7eab9e8d7b13298f953e91378d0505
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-blockfrost-worker
diff -u -N /tmp/LIVE-741892705/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-650451629/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-741892705/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-29 05:07:40.864705124 +0000
+++ /tmp/MERGED-650451629/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-29 05:07:40.864705124 +0000
@@ -8,7 +8,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: b9880480745ed23edaf686c1f77b7c6904b015a0
+    app.kubernetes.io/version: d5b269162a7eab9e8d7b13298f953e91378d0505
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-741892705/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector /tmp/MERGED-650451629/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector
--- /tmp/LIVE-741892705/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2024-02-29 05:07:41.012704423 +0000
+++ /tmp/MERGED-650451629/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2024-02-29 05:07:41.012704423 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "14"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 14
+  generation: 15
   labels:
     app: handle-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: b9880480745ed23edaf686c1f77b7c6904b015a0
+    app.kubernetes.io/version: d5b269162a7eab9e8d7b13298f953e91378d0505
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-projector
@@ -74,8 +74,8 @@
         - name: PROJECTION_NAMES
           value: handle
         - name: BUILD_INFO
-          value: '{"extra":{"narHash":"sha256-YhTMPD39gcCVPuygV2d0vroeeBvR1P/8LOh/xjbcsMo=","path":"/nix/store/0d9hwrcapkvpl2g8r3z089a2lkddanw1-source","sourceInfo":"/nix/store/0d9hwrcapkvpl2g8r3z089a2lkddanw1-source"},"lastModified":1708688536,"lastModifiedDate":"20240223114216","rev":"b9880480745ed23edaf686c1f77b7c6904b015a0","shortRev":"b988048"}'
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:4mr99h0dkq2zy5jjsh2dvv3p18n90qkp
+          value: '{"extra":{"narHash":"sha256-1ghy5vdVhVlEhKelD09sGUQ3KtXuPzG8eiE17fr/gKs=","path":"/nix/store/cpgw4jf9yaczlz0c9i8qnqxgm8p5gs0c-source","sourceInfo":"/nix/store/cpgw4jf9yaczlz0c9i8qnqxgm8p5gs0c-source"},"lastModified":1709182119,"lastModifiedDate":"20240229044839","rev":"d5b269162a7eab9e8d7b13298f953e91378d0505","shortRev":"d5b2691"}'
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:fjm71ad0m4czv2kjyw8mrwndm8pkh4fh
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-741892705/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-650451629/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-741892705/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-29 05:07:41.160703724 +0000
+++ /tmp/MERGED-650451629/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-29 05:07:41.160703724 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "14"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 14
+  generation: 15
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: b9880480745ed23edaf686c1f77b7c6904b015a0
+    app.kubernetes.io/version: d5b269162a7eab9e8d7b13298f953e91378d0505
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
@@ -82,8 +82,8 @@
         - name: USE_KORA_LABS
           value: "true"
         - name: BUILD_INFO
-          value: '{"extra":{"narHash":"sha256-YhTMPD39gcCVPuygV2d0vroeeBvR1P/8LOh/xjbcsMo=","path":"/nix/store/0d9hwrcapkvpl2g8r3z089a2lkddanw1-source","sourceInfo":"/nix/store/0d9hwrcapkvpl2g8r3z089a2lkddanw1-source"},"lastModified":1708688536,"lastModifiedDate":"20240223114216","rev":"b9880480745ed23edaf686c1f77b7c6904b015a0","shortRev":"b988048"}'
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:4mr99h0dkq2zy5jjsh2dvv3p18n90qkp
+          value: '{"extra":{"narHash":"sha256-1ghy5vdVhVlEhKelD09sGUQ3KtXuPzG8eiE17fr/gKs=","path":"/nix/store/cpgw4jf9yaczlz0c9i8qnqxgm8p5gs0c-source","sourceInfo":"/nix/store/cpgw4jf9yaczlz0c9i8qnqxgm8p5gs0c-source"},"lastModified":1709182119,"lastModifiedDate":"20240229044839","rev":"d5b269162a7eab9e8d7b13298f953e91378d0505","shortRev":"d5b2691"}'
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:fjm71ad0m4czv2kjyw8mrwndm8pkh4fh
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-741892705/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker /tmp/MERGED-650451629/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker
--- /tmp/LIVE-741892705/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2024-02-29 05:07:41.308703023 +0000
+++ /tmp/MERGED-650451629/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2024-02-29 05:07:41.308703023 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "14"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 14
+  generation: 15
   labels:
     app: pg-boss-worker
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: b9880480745ed23edaf686c1f77b7c6904b015a0
+    app.kubernetes.io/version: d5b269162a7eab9e8d7b13298f953e91378d0505
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-pg-boss-worker
@@ -98,8 +98,8 @@
         - name: STAKE_POOL_PROVIDER_URL
           value: http://dev-preview-cardanojs-backend.dev-preview.svc.cluster.local
         - name: BUILD_INFO
-          value: '{"extra":{"narHash":"sha256-YhTMPD39gcCVPuygV2d0vroeeBvR1P/8LOh/xjbcsMo=","path":"/nix/store/0d9hwrcapkvpl2g8r3z089a2lkddanw1-source","sourceInfo":"/nix/store/0d9hwrcapkvpl2g8r3z089a2lkddanw1-source"},"lastModified":1708688536,"lastModifiedDate":"20240223114216","rev":"b9880480745ed23edaf686c1f77b7c6904b015a0","shortRev":"b988048"}'
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:4mr99h0dkq2zy5jjsh2dvv3p18n90qkp
+          value: '{"extra":{"narHash":"sha256-1ghy5vdVhVlEhKelD09sGUQ3KtXuPzG8eiE17fr/gKs=","path":"/nix/store/cpgw4jf9yaczlz0c9i8qnqxgm8p5gs0c-source","sourceInfo":"/nix/store/cpgw4jf9yaczlz0c9i8qnqxgm8p5gs0c-source"},"lastModified":1709182119,"lastModifiedDate":"20240229044839","rev":"d5b269162a7eab9e8d7b13298f953e91378d0505","shortRev":"d5b2691"}'
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:fjm71ad0m4czv2kjyw8mrwndm8pkh4fh
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-741892705/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector /tmp/MERGED-650451629/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector
--- /tmp/LIVE-741892705/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2024-02-29 05:07:41.452702342 +0000
+++ /tmp/MERGED-650451629/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2024-02-29 05:07:41.452702342 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "14"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 14
+  generation: 15
   labels:
     app: stake-pool-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: b9880480745ed23edaf686c1f77b7c6904b015a0
+    app.kubernetes.io/version: d5b269162a7eab9e8d7b13298f953e91378d0505
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-projector
@@ -74,8 +74,8 @@
         - name: PROJECTION_NAMES
           value: stake-pool,stake-pool-metadata-job,stake-pool-metrics-job,stake-pool-rewards-job
         - name: BUILD_INFO
-          value: '{"extra":{"narHash":"sha256-YhTMPD39gcCVPuygV2d0vroeeBvR1P/8LOh/xjbcsMo=","path":"/nix/store/0d9hwrcapkvpl2g8r3z089a2lkddanw1-source","sourceInfo":"/nix/store/0d9hwrcapkvpl2g8r3z089a2lkddanw1-source"},"lastModified":1708688536,"lastModifiedDate":"20240223114216","rev":"b9880480745ed23edaf686c1f77b7c6904b015a0","shortRev":"b988048"}'
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:4mr99h0dkq2zy5jjsh2dvv3p18n90qkp
+          value: '{"extra":{"narHash":"sha256-1ghy5vdVhVlEhKelD09sGUQ3KtXuPzG8eiE17fr/gKs=","path":"/nix/store/cpgw4jf9yaczlz0c9i8qnqxgm8p5gs0c-source","sourceInfo":"/nix/store/cpgw4jf9yaczlz0c9i8qnqxgm8p5gs0c-source"},"lastModified":1709182119,"lastModifiedDate":"20240229044839","rev":"d5b269162a7eab9e8d7b13298f953e91378d0505","shortRev":"d5b2691"}'
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:fjm71ad0m4czv2kjyw8mrwndm8pkh4fh
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-741892705/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-650451629/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-741892705/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-29 05:07:41.600701644 +0000
+++ /tmp/MERGED-650451629/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-29 05:07:41.600701644 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "14"
   creationTimestamp: "2024-01-25T22:08:02Z"
-  generation: 14
+  generation: 15
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: b9880480745ed23edaf686c1f77b7c6904b015a0
+    app.kubernetes.io/version: d5b269162a7eab9e8d7b13298f953e91378d0505
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider
@@ -84,8 +84,8 @@
         - name: USE_TYPEORM_STAKE_POOL_PROVIDER
           value: "true"
         - name: BUILD_INFO
-          value: '{"extra":{"narHash":"sha256-YhTMPD39gcCVPuygV2d0vroeeBvR1P/8LOh/xjbcsMo=","path":"/nix/store/0d9hwrcapkvpl2g8r3z089a2lkddanw1-source","sourceInfo":"/nix/store/0d9hwrcapkvpl2g8r3z089a2lkddanw1-source"},"lastModified":1708688536,"lastModifiedDate":"20240223114216","rev":"b9880480745ed23edaf686c1f77b7c6904b015a0","shortRev":"b988048"}'
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:4mr99h0dkq2zy5jjsh2dvv3p18n90qkp
+          value: '{"extra":{"narHash":"sha256-1ghy5vdVhVlEhKelD09sGUQ3KtXuPzG8eiE17fr/gKs=","path":"/nix/store/cpgw4jf9yaczlz0c9i8qnqxgm8p5gs0c-source","sourceInfo":"/nix/store/cpgw4jf9yaczlz0c9i8qnqxgm8p5gs0c-source"},"lastModified":1709182119,"lastModifiedDate":"20240229044839","rev":"d5b269162a7eab9e8d7b13298f953e91378d0505","shortRev":"d5b2691"}'
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:fjm71ad0m4czv2kjyw8mrwndm8pkh4fh
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-741892705/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor /tmp/MERGED-650451629/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor
--- /tmp/LIVE-741892705/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2024-02-29 05:07:41.744700960 +0000
+++ /tmp/MERGED-650451629/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2024-02-29 05:07:41.744700960 +0000
@@ -5,7 +5,7 @@
   generation: 1
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: b9880480745ed23edaf686c1f77b7c6904b015a0
+    app.kubernetes.io/version: d5b269162a7eab9e8d7b13298f953e91378d0505
     instance: primary
   name: lace-backend-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-741892705/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor /tmp/MERGED-650451629/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor
--- /tmp/LIVE-741892705/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2024-02-29 05:07:41.888700280 +0000
+++ /tmp/MERGED-650451629/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2024-02-29 05:07:41.888700280 +0000
@@ -5,7 +5,7 @@
   generation: 1
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: b9880480745ed23edaf686c1f77b7c6904b015a0
+    app.kubernetes.io/version: d5b269162a7eab9e8d7b13298f953e91378d0505
     instance: primary
   name: lace-handle-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-741892705/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor /tmp/MERGED-650451629/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor
--- /tmp/LIVE-741892705/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2024-02-29 05:07:42.032699599 +0000
+++ /tmp/MERGED-650451629/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2024-02-29 05:07:42.032699599 +0000
@@ -5,7 +5,7 @@
   generation: 1
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: b9880480745ed23edaf686c1f77b7c6904b015a0
+    app.kubernetes.io/version: d5b269162a7eab9e8d7b13298f953e91378d0505
     instance: primary
   name: lace-stake-pool-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-741892705/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-650451629/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-741892705/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2024-02-29 05:07:42.184698878 +0000
+++ /tmp/MERGED-650451629/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2024-02-29 05:07:42.184698878 +0000
@@ -20,7 +20,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: b9880480745ed23edaf686c1f77b7c6904b015a0
+    app.kubernetes.io/version: d5b269162a7eab9e8d7b13298f953e91378d0505
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-741892705/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-650451629/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-741892705/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-29 05:07:42.332698179 +0000
+++ /tmp/MERGED-650451629/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-29 05:07:42.332698179 +0000
@@ -18,7 +18,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: b9880480745ed23edaf686c1f77b7c6904b015a0
+    app.kubernetes.io/version: d5b269162a7eab9e8d7b13298f953e91378d0505
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-741892705/v1.Service.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-650451629/v1.Service.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-741892705/v1.Service.dev-preview.dev-preview-cardanojs-backend	2024-02-29 05:07:40.004709193 +0000
+++ /tmp/MERGED-650451629/v1.Service.dev-preview.dev-preview-cardanojs-backend	2024-02-29 05:07:40.004709193 +0000
@@ -5,7 +5,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: b9880480745ed23edaf686c1f77b7c6904b015a0
+    app.kubernetes.io/version: d5b269162a7eab9e8d7b13298f953e91378d0505
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-741892705/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-650451629/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-741892705/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-29 05:07:40.144708529 +0000
+++ /tmp/MERGED-650451629/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2024-02-29 05:07:40.144708529 +0000
@@ -5,7 +5,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: b9880480745ed23edaf686c1f77b7c6904b015a0
+    app.kubernetes.io/version: d5b269162a7eab9e8d7b13298f953e91378d0505
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-741892705/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-650451629/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-741892705/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-29 05:07:40.288707850 +0000
+++ /tmp/MERGED-650451629/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2024-02-29 05:07:40.288707850 +0000
@@ -5,7 +5,7 @@
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: b9880480745ed23edaf686c1f77b7c6904b015a0
+    app.kubernetes.io/version: d5b269162a7eab9e8d7b13298f953e91378d0505
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
diff -u -N /tmp/LIVE-741892705/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-650451629/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-741892705/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-29 05:07:40.428707188 +0000
+++ /tmp/MERGED-650451629/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2024-02-29 05:07:40.428707188 +0000
@@ -5,7 +5,7 @@
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: b9880480745ed23edaf686c1f77b7c6904b015a0
+    app.kubernetes.io/version: d5b269162a7eab9e8d7b13298f953e91378d0505
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider

mkazlauskas
mkazlauskas approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@mkazlauskas mkazlauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🕵️

@mkazlauskas mkazlauskas requested a review from a team February 29, 2024 05:48
iccicci
iccicci approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@iccicci iccicci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is coherent with the code in the same context, but seems to be not so much coherent with subject and description of the PR; I read:
bodies with no inputs
but reading at the code I would have expected
bodies with no outputs.
Maybe this is just a minor refuse...

@AngelCastilloB
Copy link
Member Author

AngelCastilloB commented Feb 29, 2024 •
edited
Loading

The change is coherent with the code in the same context, but seems to be not so much coherent with subject and description of the PR; I read: bodies with no inputs but reading at the code I would have expected bodies with no outputs. Maybe this is just a minor refuse...

The error was caused when the transaction body had no inputs. Because we were using the inputs presence to account for both inputs and outputs during the computation of the map size. When the inputs were missing, the size of the map was reduced by 2 (rather than 1) as if when there were no inputs, there weren't also any outputs (even when outputs were present)

@AngelCastilloB AngelCastilloB merged commit e85871e into master Feb 29, 2024
@AngelCastilloB AngelCastilloB deleted the feat/lw-9901-transactionBody-serializes-incorrectly-if-no-inputs branch February 29, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iccicci iccicci iccicci approved these changes

@mkazlauskas mkazlauskas mkazlauskas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AngelCastilloB @iccicci @mkazlauskas