-
Notifications
You must be signed in to change notification settings - Fork 63
feat(hardware-ledger): miscellaneous improvements to establishing ledger connection #1161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hardware-ledger): miscellaneous improvements to establishing ledger connection #1161
Conversation
|
@szymonmaslowski Tests in the wallet package are failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@szymonmaslowski I left 2 comments. Could you please take a look
@tomislavhoracek Thanks for pointing me there. I will handle it. |
31a05e2
to
bc8bcc8
Compare
bc8bcc8
to
61bc53e
Compare
8541115
to
2d52af4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Please squash into 1 commit before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
a63795a
a63795a ✅ |
…tablish connection with - testing matching remembered connection before returning it - doing cleanup on a transport disconnection event - reorganized hardware-ledger tests in the wallet package BREAKING CHANGE: replace LedgerKeyAgent webhid transport with webusb - make some of the LedgerKeyAgent methods private - remove activeTransport parameter from the LedgerKeyAgent.createTransport method
…senting remembered connection
a63795a
to
1e6287b
Compare
Context
There is an ongoing lace onboarding flows revamp work. Changes in this PR are part of the improvements to the HW connection implementation
Proposed Solution
Important Changes Introduced
navigator.usb
Web API. Trezor supports only WebUSB API, so this way we will be able to show both device types in a single native picker.USBDevice
|HID
depending on theConnectionType
) object and establish the connection using it.