-
Notifications
You must be signed in to change notification settings - Fork 62
fix: remove redundant, uninitialized logger from TypeormService #1392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually we use context for commit messages of changes impacting only one package.
More, we use fix
for commits which actually fix a bug; removing unused code is more a refactor
...
refactor(cardano-services): remove ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @will-break-it !
Context
Reason for the change? If an issue exists, reference it here using a keyword
Proposed Solution
Important Changes Introduced