-
Notifications
You must be signed in to change notification settings - Fork 62
feat!: replace updateWitness with addSignatures in observable wallet #1411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: replace updateWitness with addSignatures in observable wallet #1411
Conversation
5ffc7f1
to
4005cbe
Compare
|
4005cbe
to
16b6d52
Compare
16b6d52
to
79a721a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 🚀
BREAKING CHANGE: remove updateWitness method from observable wallet - add addSignatures method to observable wallet
892c1e9
to
d0bdffa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @AngelCastilloB 🚀
Context
The base wallet currently have a updateWitness method that adds signatures to a given transaction, however, this method does not preserve the original CBOR, we must modify this method to correctly preserve CBOR of the transaction.
Proposed Solution
Modify updateWitness to take the CBOR of the transaction, add signatures to it, and return the transaction with the new signatures encoded as CBOR.