Feat/transaction history gap issue #1568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirceahasegan
requested review from
AngelCastilloB,
mkazlauskas,
rhyslbw,
mchappell,
vetalcore and
przemyslaw-wlodek
rhyslbw
approved these changes
Jan 25, 2025
…equentially fetchSequentially page was specified in 2 places (paging options and a positional page parameter). Calling it with `page` in PaginationOptions ignores the page, leading to fetch of page: 1 infinitely. Removed the positional `page` arg to avoid confusion, and use the one from paginationOptions
mirceahasegan
force-pushed
the
feat/transaction-history-gap-issue
branch
from
b718bbb to
f2a815f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fetching a limited number of transactions from all addresses and displaying them aggregated could lead to gaps in the tx history when one transaction has been very active (i.e. 100 transactions in the past year, with 10 of them in the past day), and another transaction is less active (one transaction one year ago).
Fetching 10 per addres and aggregating the results will lead to a history of one transaction one year ago, and 10 transactions in the past day, having a gap of 90 transactions from the active address.
Proposed Solution
Update
fetchInitialTransactions:historicalTransactionsFetchLimit.Important Changes Introduced
Fixed an issue with fetchSequentially which ignored the
PagingOptions.pagearg, leading to an infinite loop.Removing the positional arg
pageis a breaking change.