LW-12164 Feat/cache data from blockfrost locally #1569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirceahasegan
suggested changes
Jan 27, 2025
packages/cardano-services-client/src/ChainHistoryProvider/BlockfrostChainHistoryProvider.ts
Outdated
Show resolved
Hide resolved
mirceahasegan
approved these changes
Jan 27, 2025
mkazlauskas
approved these changes
Jan 27, 2025
| @@ -34,6 +34,7 @@ type BlockfrostTx = Pick<Responses['address_transactions_content'][0], 'block_he | |||
| const compareTx = (a: BlockfrostTx, b: BlockfrostTx) => a.block_height - b.block_height || a.tx_index - b.tx_index; | |||
|
|
|||
| export class BlockfrostChainHistoryProvider extends BlockfrostProvider implements ChainHistoryProvider { | |||
| private readonly cache: Map<string, Cardano.HydratedTx> = new Map(); | |||
There was a problem hiding this comment.
It would be better if cache objects were injected (e.g. type Cache<K, V> = { get: (key: K) => Promise<T>, set: (key: K, value: V) => Promise<void> }), then it would be easier to update/swap it with a more sophisticated cache (lru, persistent etc.) and control it with FFs. Anyway happy to merge as-is to mitigate the current issue quickly.
AngelCastilloB
force-pushed
the
feat/cache-data-from-blockfrost-locally
branch
from
4dce93b to
8cb0dac
Compare
rhyslbw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We want to reduce the amount of request we make to blockfrost. Now ChainHistoryProvider and UtxoProvider use a local volatile cache to reuse when requesting the same data several times.