Skip to content

fix: reject PRs without @esbuild/linux-x64@npm in yarn-project.nix & fix the NixBuild.net integration #1614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 18, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 34 additions & 9 deletions .github/workflows/std.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,24 @@ concurrency:
group: std-${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
jobs:
check-yarn-project-nix:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
- run: |
if ! grep -qF '"@esbuild/linux-x64@npm:' yarn-project.nix ; then
echo ' '
echo "Please, make sure that the 'yarn-project.nix' on $(git rev-parse HEAD) still contains '@esbuild/linux-x64@npm' (see your diff)."
echo ' '
echo "Its accidental removal can be caused by running 'yarn install' on macOS."
echo ' '
exit 1
fi

discover:
needs: check-yarn-project-nix
# Don’t run on PRs from forks (no access to secrets):
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository
outputs:
Expand Down Expand Up @@ -161,12 +178,12 @@ jobs:
if: matrix.target != 'dummy-target'
id: login-ecr
uses: aws-actions/amazon-ecr-login@v1
- uses: nixbuild/nix-quick-install-action@v25
- uses: nixbuild/nix-quick-install-action@v30
if: matrix.target != 'dummy-target'
- uses: nixbuild/nixbuild-action@v17
- uses: nixbuild/nixbuild-action@v20
if: matrix.target != 'dummy-target'
with:
nixbuild_ssh_key: ${{ secrets.SSH_PRIVATE_KEY }}
nixbuild_token: ${{ secrets.NIXBUILD_TOKEN }}
generate_summary_for: job
- uses: divnix/std-action/setup-discovery-ssh@main
if: matrix.target != 'dummy-target'
Expand All @@ -178,6 +195,14 @@ jobs:
shell: bash
run: |
echo commit: ${{ github.sha }}
- name: Manual NixBuild.net
if: matrix.target != 'dummy-target'
shell: bash
run: |
# We trigger this manually, because some integration has broken between std-action and nixbuild.net:
nix build --no-link --print-build-logs --log-format raw-with-logs \
--eval-store auto --builders "''" --store ssh-ng://eu.nixbuild.net \
github:input-output-hk/cardano-js-sdk/${{ github.sha }}#__std.actions.x86_64-linux.cardano-services.oci-images.cardano-services.publish
- uses: divnix/std-action/run@main
if: matrix.target != 'dummy-target'
with: { ffBuildInstructions: true, remoteStore: 'ssh-ng://eu.nixbuild.net' }
Expand All @@ -192,10 +217,10 @@ jobs:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
- uses: nixbuild/nix-quick-install-action@v25
- uses: nixbuild/nixbuild-action@v17
- uses: nixbuild/nix-quick-install-action@v30
- uses: nixbuild/nixbuild-action@v20
with:
nixbuild_ssh_key: ${{ secrets.SSH_PRIVATE_KEY }}
nixbuild_token: ${{ secrets.NIXBUILD_TOKEN }}
generate_summary_for: job
# Further steps assume AWS_PROFILE=lw, while the official action has no way to specify that profile:
- name: Set up AWS credentials
Expand Down Expand Up @@ -297,10 +322,10 @@ jobs:
url: ${{ matrix.url }}
steps:
- uses: actions/checkout@v4
- uses: nixbuild/nix-quick-install-action@v25
- uses: nixbuild/nixbuild-action@v17
- uses: nixbuild/nix-quick-install-action@v30
- uses: nixbuild/nixbuild-action@v20
with:
nixbuild_ssh_key: ${{ secrets.SSH_PRIVATE_KEY }}
nixbuild_token: ${{ secrets.NIXBUILD_TOKEN }}
generate_summary_for: job
# Further steps assume AWS_PROFILE=lw, while the official action has no way to specify that profile:
- name: Set up AWS credentials
Expand Down
Loading