Refactor cache invalidation test #796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhyslbw
requested changes
Jul 3, 2023
iccicci
force-pushed
the
refactor/LW-7113-cache-invalidation
branch
from
930423e to
bc473a8
Compare
mkazlauskas
approved these changes
Jul 4, 2023
rhyslbw
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Recently we changed the
DISABLE_DB_CACHEsetting of our test local-network totruewhile the cache invalidation tests requires it tofalse: it needs a cache to check it is invalidated.Proposed Solution
Changed the test in order to start its own provider-server with the setting configured as it needs.
Important Changes Introduced
Also refactored the main
Dockerfileto take more advantage from docker build cache