feat: no stability window buffer til volatile #947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkazlauskas
force-pushed
the
feat/no-stability-window-buffer-til-volatile
branch
from
ae701e7 to
e549b96
Compare
Standard DiffPostThis PR would generate the following Preview |
restructure observable DataSource utils for easier re-use as preparation for new StabilityWindowBuffer interface that will require it's own connection during Bootstrap
hoist from wallet TipTracker tests
It's implemented by splitting StabilityWindowBuffer into 2 pieces: - Tip observable, which is used to determine local tip - StabilityWindowBuffer is now simplified to just 'getBlock' method BREAKING CHANGE: simplify StabilityWindowBuffer interface to just 'getBlock' - Bootstrap.fromCardanoNode now requires Tip observable parameter
mkazlauskas
force-pushed
the
feat/no-stability-window-buffer-til-volatile
branch
from
e549b96 to
b2244ea
Compare
Merged
rhyslbw
reviewed
Oct 19, 2023
rhyslbw
reviewed
Oct 19, 2023
There was a problem hiding this comment.
Have you done a performance test @mkazlauskas ? I'm curios to know the gains we're getting here Edit: It's in the description 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Projector is inserting block data into the database even when it's far away from the tip and there is no chance of a fork/rollback happening.
LW-6953
Proposed Solution
Projector no longer inserts block data until it reaches
tip-securityParameterblock height. This is implemented by extracting Tip tracking capabilities out of StabilityWindowBuffer interface.Preliminary performance testing of utxo projection on my computer resulted in
Important Changes Introduced
See commit log