Skip to content

fix(hardware-trezor): trezor tx signing LW-6522 #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2023
Merged

fix(hardware-trezor): trezor tx signing LW-6522 #956

merged 1 commit into from
Oct 19, 2023

Conversation

DominikGuzei
Copy link
Member

Context

This PR fixes the Trezor transaction signing which was failing due to an invalid fee calculation.

Proposed Solution

Filter the Trezor signatures to those with the expected public keys (based on ownSignatureKeyPaths), so that the fees calculation (which is based on the number of signatures) is correct.

Important Changes Introduced

none

@DominikGuzei DominikGuzei added the bug Something isn't working label Oct 19, 2023
@DominikGuzei DominikGuzei self-assigned this Oct 19, 2023
iccicci
iccicci approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@iccicci iccicci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkazlauskas mkazlauskas merged commit 608a3c1 into master Oct 19, 2023
@mkazlauskas mkazlauskas deleted the fix/lw-6522-fix-trezor-tx-signing branch October 19, 2023 15:40
@github-actions
Copy link

Standard DiffPost

This PR would generate the following kubectl diff:

Preview 
diff -u -N /tmp/LIVE-2077394216/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-2614640865/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-2077394216/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2023-10-20 10:15:51.772003860 +0000
+++ /tmp/MERGED-2614640865/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2023-10-20 10:15:51.772003860 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "48"
   creationTimestamp: "2023-08-11T18:16:12Z"
-  generation: 48
+  generation: 49
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 608a3c17653eb6730fb8b7ac1dbbed1b61c74ee0
+    app.kubernetes.io/version: 458492394c2ad35964ff535cdb1756a24705e740
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
@@ -89,7 +89,7 @@
           value: "false"
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:mw9i9xz2qn4arwp3qksivq9kgdr5cdhx
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:9xhyl3zd5kfwwgk0l1vc9jbifj1plxb7
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2077394216/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-2614640865/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-2077394216/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-10-20 10:15:51.968018804 +0000
+++ /tmp/MERGED-2614640865/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-10-20 10:15:51.968018804 +0000
@@ -8,7 +8,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 608a3c17653eb6730fb8b7ac1dbbed1b61c74ee0
+    app.kubernetes.io/version: 458492394c2ad35964ff535cdb1756a24705e740
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-2077394216/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector /tmp/MERGED-2614640865/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector
--- /tmp/LIVE-2077394216/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2023-10-20 10:15:52.164033749 +0000
+++ /tmp/MERGED-2614640865/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2023-10-20 10:15:52.168034054 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "48"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 48
+  generation: 49
   labels:
     app: handle-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 608a3c17653eb6730fb8b7ac1dbbed1b61c74ee0
+    app.kubernetes.io/version: 458492394c2ad35964ff535cdb1756a24705e740
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-projector
@@ -73,7 +73,7 @@
               name: handle-owner-user.dev-preview-dbsync-db.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: handle
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:mw9i9xz2qn4arwp3qksivq9kgdr5cdhx
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:9xhyl3zd5kfwwgk0l1vc9jbifj1plxb7
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2077394216/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-2614640865/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-2077394216/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2023-10-20 10:15:52.364048998 +0000
+++ /tmp/MERGED-2614640865/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2023-10-20 10:15:52.364048998 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "15"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 15
+  generation: 16
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 608a3c17653eb6730fb8b7ac1dbbed1b61c74ee0
+    app.kubernetes.io/version: 458492394c2ad35964ff535cdb1756a24705e740
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
@@ -81,7 +81,7 @@
           value: handle
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:mw9i9xz2qn4arwp3qksivq9kgdr5cdhx
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:9xhyl3zd5kfwwgk0l1vc9jbifj1plxb7
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2077394216/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker /tmp/MERGED-2614640865/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker
--- /tmp/LIVE-2077394216/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2023-10-20 10:15:52.560063943 +0000
+++ /tmp/MERGED-2614640865/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2023-10-20 10:15:52.560063943 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "48"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 48
+  generation: 49
   labels:
     app: pg-boss-worker
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 608a3c17653eb6730fb8b7ac1dbbed1b61c74ee0
+    app.kubernetes.io/version: 458492394c2ad35964ff535cdb1756a24705e740
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-pg-boss-worker
@@ -93,7 +93,7 @@
           value: pool-metadata,pool-metrics
         - name: STAKE_POOL_PROVIDER_URL
           value: http://dev-preview-cardanojs-backend.dev-preview.svc.cluster.local
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:mw9i9xz2qn4arwp3qksivq9kgdr5cdhx
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:9xhyl3zd5kfwwgk0l1vc9jbifj1plxb7
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2077394216/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector /tmp/MERGED-2614640865/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector
--- /tmp/LIVE-2077394216/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2023-10-20 10:15:52.756078888 +0000
+++ /tmp/MERGED-2614640865/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2023-10-20 10:15:52.756078888 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "48"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 48
+  generation: 49
   labels:
     app: stake-pool-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 608a3c17653eb6730fb8b7ac1dbbed1b61c74ee0
+    app.kubernetes.io/version: 458492394c2ad35964ff535cdb1756a24705e740
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-projector
@@ -71,7 +71,7 @@
               name: stakepool-owner-user.dev-preview-dbsync-db.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: stake-pool,stake-pool-metadata-job,stake-pool-metrics-job
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:mw9i9xz2qn4arwp3qksivq9kgdr5cdhx
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:9xhyl3zd5kfwwgk0l1vc9jbifj1plxb7
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2077394216/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-2614640865/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-2077394216/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2023-10-20 10:15:52.960094442 +0000
+++ /tmp/MERGED-2614640865/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2023-10-20 10:15:52.960094442 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "45"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 45
+  generation: 46
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 608a3c17653eb6730fb8b7ac1dbbed1b61c74ee0
+    app.kubernetes.io/version: 458492394c2ad35964ff535cdb1756a24705e740
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider
@@ -83,7 +83,7 @@
           value: http://dev-preview-cardano-stack-metadata.dev-preview.svc.cluster.local
         - name: USE_TYPEORM_STAKE_POOL_PROVIDER
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:mw9i9xz2qn4arwp3qksivq9kgdr5cdhx
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:9xhyl3zd5kfwwgk0l1vc9jbifj1plxb7
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2077394216/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor /tmp/MERGED-2614640865/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor
--- /tmp/LIVE-2077394216/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2023-10-20 10:15:53.156109387 +0000
+++ /tmp/MERGED-2614640865/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2023-10-20 10:15:53.156109387 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 608a3c17653eb6730fb8b7ac1dbbed1b61c74ee0
+    app.kubernetes.io/version: 458492394c2ad35964ff535cdb1756a24705e740
     instance: primary
   name: lace-backend-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-2077394216/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor /tmp/MERGED-2614640865/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor
--- /tmp/LIVE-2077394216/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2023-10-20 10:15:53.352124331 +0000
+++ /tmp/MERGED-2614640865/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2023-10-20 10:15:53.352124331 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 608a3c17653eb6730fb8b7ac1dbbed1b61c74ee0
+    app.kubernetes.io/version: 458492394c2ad35964ff535cdb1756a24705e740
     instance: primary
   name: lace-handle-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-2077394216/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor /tmp/MERGED-2614640865/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor
--- /tmp/LIVE-2077394216/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2023-10-20 10:15:53.552139581 +0000
+++ /tmp/MERGED-2614640865/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2023-10-20 10:15:53.552139581 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 608a3c17653eb6730fb8b7ac1dbbed1b61c74ee0
+    app.kubernetes.io/version: 458492394c2ad35964ff535cdb1756a24705e740
     instance: primary
   name: lace-stake-pool-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-2077394216/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-2614640865/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-2077394216/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2023-10-20 10:15:53.748154525 +0000
+++ /tmp/MERGED-2614640865/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2023-10-20 10:15:53.748154525 +0000
@@ -19,7 +19,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 608a3c17653eb6730fb8b7ac1dbbed1b61c74ee0
+    app.kubernetes.io/version: 458492394c2ad35964ff535cdb1756a24705e740
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-2077394216/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-2614640865/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-2077394216/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-10-20 10:15:53.952170080 +0000
+++ /tmp/MERGED-2614640865/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-10-20 10:15:53.952170080 +0000
@@ -16,7 +16,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 608a3c17653eb6730fb8b7ac1dbbed1b61c74ee0
+    app.kubernetes.io/version: 458492394c2ad35964ff535cdb1756a24705e740
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-2077394216/v1.Service.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-2614640865/v1.Service.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-2077394216/v1.Service.dev-preview.dev-preview-cardanojs-backend	2023-10-20 10:15:50.991944387 +0000
+++ /tmp/MERGED-2614640865/v1.Service.dev-preview.dev-preview-cardanojs-backend	2023-10-20 10:15:50.991944387 +0000
@@ -5,7 +5,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 608a3c17653eb6730fb8b7ac1dbbed1b61c74ee0
+    app.kubernetes.io/version: 458492394c2ad35964ff535cdb1756a24705e740
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-2077394216/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-2614640865/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-2077394216/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-10-20 10:15:51.183959026 +0000
+++ /tmp/MERGED-2614640865/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-10-20 10:15:51.183959026 +0000
@@ -5,7 +5,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 608a3c17653eb6730fb8b7ac1dbbed1b61c74ee0
+    app.kubernetes.io/version: 458492394c2ad35964ff535cdb1756a24705e740
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-2077394216/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-2614640865/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-2077394216/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2023-10-20 10:15:51.375973666 +0000
+++ /tmp/MERGED-2614640865/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2023-10-20 10:15:51.375973666 +0000
@@ -5,7 +5,7 @@
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 608a3c17653eb6730fb8b7ac1dbbed1b61c74ee0
+    app.kubernetes.io/version: 458492394c2ad35964ff535cdb1756a24705e740
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
diff -u -N /tmp/LIVE-2077394216/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-2614640865/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-2077394216/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2023-10-20 10:15:51.575988915 +0000
+++ /tmp/MERGED-2614640865/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2023-10-20 10:15:51.575988915 +0000
@@ -5,7 +5,7 @@
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 608a3c17653eb6730fb8b7ac1dbbed1b61c74ee0
+    app.kubernetes.io/version: 458492394c2ad35964ff535cdb1756a24705e740
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iccicci iccicci iccicci approved these changes

@mkazlauskas mkazlauskas mkazlauskas approved these changes

@marcin-mazurek marcin-mazurek Awaiting requested review from marcin-mazurek

Assignees

@DominikGuzei DominikGuzei

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DominikGuzei @iccicci @mkazlauskas