Skip to content

LW-9018 fix unit tests #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 14, 2023
Merged

LW-9018 fix unit tests #979

merged 2 commits into from
Nov 14, 2023

Conversation

mirceahasegan
Copy link
Contributor

Context

Proposed Solution

Important Changes Introduced

@mirceahasegan mirceahasegan requested review from mkazlauskas, mchappell and a team November 8, 2023 16:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023 •
edited
Loading

Standard DiffPost

This PR would generate the following kubectl diff:

Preview 
diff -u -N /tmp/LIVE-239184714/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-1346841302/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-239184714/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2023-11-14 16:38:52.572196214 +0000
+++ /tmp/MERGED-1346841302/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2023-11-14 16:38:52.572196214 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "64"
   creationTimestamp: "2023-08-11T18:16:12Z"
-  generation: 64
+  generation: 65
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 22a6446049b35473bb781ae5abb93303fa6d535f
+    app.kubernetes.io/version: c70897ee2965f5d2c9e26f79aad05d4398990490
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
@@ -89,7 +89,7 @@
           value: "false"
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:wibngs65njnjvf8xw9fvv095x8lkldjr
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:6600mi3k9z55jxfad20zzacd9mi80pk5
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-239184714/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-1346841302/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-239184714/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-11-14 16:38:52.808196279 +0000
+++ /tmp/MERGED-1346841302/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-11-14 16:38:52.808196279 +0000
@@ -8,7 +8,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 22a6446049b35473bb781ae5abb93303fa6d535f
+    app.kubernetes.io/version: c70897ee2965f5d2c9e26f79aad05d4398990490
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-239184714/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector /tmp/MERGED-1346841302/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector
--- /tmp/LIVE-239184714/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2023-11-14 16:38:53.044196340 +0000
+++ /tmp/MERGED-1346841302/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2023-11-14 16:38:53.048196342 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "64"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 64
+  generation: 65
   labels:
     app: handle-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 22a6446049b35473bb781ae5abb93303fa6d535f
+    app.kubernetes.io/version: c70897ee2965f5d2c9e26f79aad05d4398990490
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-projector
@@ -73,7 +73,7 @@
               name: handle-owner-user.dev-preview-dbsync-db.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: handle
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:wibngs65njnjvf8xw9fvv095x8lkldjr
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:6600mi3k9z55jxfad20zzacd9mi80pk5
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-239184714/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-1346841302/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-239184714/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2023-11-14 16:38:53.284196404 +0000
+++ /tmp/MERGED-1346841302/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2023-11-14 16:38:53.284196404 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "31"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 31
+  generation: 32
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 22a6446049b35473bb781ae5abb93303fa6d535f
+    app.kubernetes.io/version: c70897ee2965f5d2c9e26f79aad05d4398990490
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
@@ -81,7 +81,7 @@
           value: handle
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:wibngs65njnjvf8xw9fvv095x8lkldjr
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:6600mi3k9z55jxfad20zzacd9mi80pk5
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-239184714/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker /tmp/MERGED-1346841302/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker
--- /tmp/LIVE-239184714/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2023-11-14 16:38:53.524196467 +0000
+++ /tmp/MERGED-1346841302/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2023-11-14 16:38:53.524196467 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "64"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 64
+  generation: 65
   labels:
     app: pg-boss-worker
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 22a6446049b35473bb781ae5abb93303fa6d535f
+    app.kubernetes.io/version: c70897ee2965f5d2c9e26f79aad05d4398990490
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-pg-boss-worker
@@ -92,10 +92,10 @@
               key: username
               name: stakepool-owner-user.dev-preview-dbsync-db.credentials.postgresql.acid.zalan.do
         - name: QUEUES
-          value: pool-delist-schedule,pool-metadata,pool-metrics,pool-rewards
+          value: pool-metadata,pool-metrics
         - name: STAKE_POOL_PROVIDER_URL
           value: http://dev-preview-cardanojs-backend.dev-preview.svc.cluster.local
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:wibngs65njnjvf8xw9fvv095x8lkldjr
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:6600mi3k9z55jxfad20zzacd9mi80pk5
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-239184714/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector /tmp/MERGED-1346841302/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector
--- /tmp/LIVE-239184714/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2023-11-14 16:38:53.760196527 +0000
+++ /tmp/MERGED-1346841302/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2023-11-14 16:38:53.760196527 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "64"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 64
+  generation: 65
   labels:
     app: stake-pool-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 22a6446049b35473bb781ae5abb93303fa6d535f
+    app.kubernetes.io/version: c70897ee2965f5d2c9e26f79aad05d4398990490
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-projector
@@ -72,8 +72,8 @@
               key: username
               name: stakepool-owner-user.dev-preview-dbsync-db.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
-          value: stake-pool,stake-pool-metadata-job,stake-pool-metrics-job,stake-pool-rewards-job
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:wibngs65njnjvf8xw9fvv095x8lkldjr
+          value: stake-pool,stake-pool-metadata-job,stake-pool-metrics-job
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:6600mi3k9z55jxfad20zzacd9mi80pk5
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-239184714/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-1346841302/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-239184714/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2023-11-14 16:38:54.004196596 +0000
+++ /tmp/MERGED-1346841302/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2023-11-14 16:38:54.004196596 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "61"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 61
+  generation: 62
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 22a6446049b35473bb781ae5abb93303fa6d535f
+    app.kubernetes.io/version: c70897ee2965f5d2c9e26f79aad05d4398990490
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider
@@ -83,7 +83,7 @@
           value: http://dev-preview-cardano-stack-metadata.dev-preview.svc.cluster.local
         - name: USE_TYPEORM_STAKE_POOL_PROVIDER
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:wibngs65njnjvf8xw9fvv095x8lkldjr
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:6600mi3k9z55jxfad20zzacd9mi80pk5
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-239184714/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor /tmp/MERGED-1346841302/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor
--- /tmp/LIVE-239184714/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2023-11-14 16:38:54.288196669 +0000
+++ /tmp/MERGED-1346841302/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2023-11-14 16:38:54.288196669 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 22a6446049b35473bb781ae5abb93303fa6d535f
+    app.kubernetes.io/version: c70897ee2965f5d2c9e26f79aad05d4398990490
     instance: primary
   name: lace-backend-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-239184714/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor /tmp/MERGED-1346841302/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor
--- /tmp/LIVE-239184714/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2023-11-14 16:38:54.704196778 +0000
+++ /tmp/MERGED-1346841302/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2023-11-14 16:38:54.704196778 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 22a6446049b35473bb781ae5abb93303fa6d535f
+    app.kubernetes.io/version: c70897ee2965f5d2c9e26f79aad05d4398990490
     instance: primary
   name: lace-handle-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-239184714/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor /tmp/MERGED-1346841302/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor
--- /tmp/LIVE-239184714/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2023-11-14 16:38:54.940196840 +0000
+++ /tmp/MERGED-1346841302/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2023-11-14 16:38:54.940196840 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 22a6446049b35473bb781ae5abb93303fa6d535f
+    app.kubernetes.io/version: c70897ee2965f5d2c9e26f79aad05d4398990490
     instance: primary
   name: lace-stake-pool-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-239184714/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-1346841302/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-239184714/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2023-11-14 16:38:55.200196912 +0000
+++ /tmp/MERGED-1346841302/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2023-11-14 16:38:55.200196912 +0000
@@ -19,7 +19,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 22a6446049b35473bb781ae5abb93303fa6d535f
+    app.kubernetes.io/version: c70897ee2965f5d2c9e26f79aad05d4398990490
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-239184714/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-1346841302/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-239184714/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-11-14 16:38:55.448196976 +0000
+++ /tmp/MERGED-1346841302/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-11-14 16:38:55.448196976 +0000
@@ -16,7 +16,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 22a6446049b35473bb781ae5abb93303fa6d535f
+    app.kubernetes.io/version: c70897ee2965f5d2c9e26f79aad05d4398990490
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-239184714/v1.Service.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-1346841302/v1.Service.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-239184714/v1.Service.dev-preview.dev-preview-cardanojs-backend	2023-11-14 16:38:51.632195969 +0000
+++ /tmp/MERGED-1346841302/v1.Service.dev-preview.dev-preview-cardanojs-backend	2023-11-14 16:38:51.632195969 +0000
@@ -5,7 +5,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 22a6446049b35473bb781ae5abb93303fa6d535f
+    app.kubernetes.io/version: c70897ee2965f5d2c9e26f79aad05d4398990490
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-239184714/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-1346841302/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-239184714/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-11-14 16:38:51.864196029 +0000
+++ /tmp/MERGED-1346841302/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-11-14 16:38:51.864196029 +0000
@@ -5,7 +5,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 22a6446049b35473bb781ae5abb93303fa6d535f
+    app.kubernetes.io/version: c70897ee2965f5d2c9e26f79aad05d4398990490
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-239184714/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-1346841302/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-239184714/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2023-11-14 16:38:52.100196092 +0000
+++ /tmp/MERGED-1346841302/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2023-11-14 16:38:52.100196092 +0000
@@ -5,7 +5,7 @@
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 22a6446049b35473bb781ae5abb93303fa6d535f
+    app.kubernetes.io/version: c70897ee2965f5d2c9e26f79aad05d4398990490
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
diff -u -N /tmp/LIVE-239184714/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-1346841302/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-239184714/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2023-11-14 16:38:52.328196151 +0000
+++ /tmp/MERGED-1346841302/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2023-11-14 16:38:52.328196151 +0000
@@ -5,7 +5,7 @@
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 22a6446049b35473bb781ae5abb93303fa6d535f
+    app.kubernetes.io/version: c70897ee2965f5d2c9e26f79aad05d4398990490
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider

iccicci
iccicci approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@iccicci iccicci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply awesome!
Thank you very much!

@mirceahasegan mirceahasegan requested a review from a team November 9, 2023 14:09
@mirceahasegan mirceahasegan mentioned this pull request Nov 10, 2023
Merged
mkazlauskas
mkazlauskas approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@mkazlauskas mkazlauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🚀

@mirceahasegan mirceahasegan force-pushed the test/lw-9018-fix-unit-tests branch from 9ce7376 to 958240e Compare November 14, 2023 10:18
@mirceahasegan
fix(util): serialize error with data
a7357a3 
Correctly serialize and deserialize errors with innerError and data.
This also reverts the initial fix from commit
447b75d
@mirceahasegan mirceahasegan force-pushed the test/lw-9018-fix-unit-tests branch from 958240e to a7357a3 Compare November 14, 2023 16:31
@mirceahasegan mirceahasegan merged commit 14896cf into conway-era Nov 14, 2023
@mirceahasegan mirceahasegan deleted the test/lw-9018-fix-unit-tests branch November 14, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iccicci iccicci iccicci approved these changes

@mkazlauskas mkazlauskas mkazlauskas approved these changes

@mchappell mchappell Awaiting requested review from mchappell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mirceahasegan @iccicci @mkazlauskas