Skip to content

Fix/lw 8951 reject tx submit errors #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 15, 2023
Merged

Fix/lw 8951 reject tx submit errors #987

merged 2 commits into from
Nov 15, 2023

Conversation

mirceahasegan
Copy link
Contributor

Context

cardano-submit-api tx provider does not emit innerError with code and data like ogmios does.
When innerError is missing or is not parsable in to a known txSubmitError, the error is reported as ProviderFailure.Unknown.
Furthermore, SmartTxSubmitProvider is retrying Unknown errors, but shouldn't.

Proposed Solution

TxSubmit errors without innerError will be mapped to a ProviderFailure based on the response reason.
Update SmartTxSubmitProvider to retry only Unhealthy or ConnectionFailure unreachable errors

Important Changes Introduced

@mirceahasegan mirceahasegan requested a review from a team November 14, 2023 16:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2023 •
edited
Loading

Standard DiffPost

This PR would generate the following kubectl diff:

Preview 
diff -u -N /tmp/LIVE-184726840/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-2353378044/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-184726840/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2023-11-14 19:00:51.290519836 +0000
+++ /tmp/MERGED-2353378044/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2023-11-14 19:00:51.290519836 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "64"
   creationTimestamp: "2023-08-11T18:16:12Z"
-  generation: 64
+  generation: 65
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 22a6446049b35473bb781ae5abb93303fa6d535f
+    app.kubernetes.io/version: 7a58026bc0f914aaf613b581017c4caa44103da8
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
@@ -89,7 +89,7 @@
           value: "false"
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:wibngs65njnjvf8xw9fvv095x8lkldjr
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:v6msgixhy8kz6yjjs4nba3kczp0g8xfi
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-184726840/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-2353378044/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-184726840/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-11-14 19:00:51.542521519 +0000
+++ /tmp/MERGED-2353378044/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-11-14 19:00:51.542521519 +0000
@@ -8,7 +8,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 22a6446049b35473bb781ae5abb93303fa6d535f
+    app.kubernetes.io/version: 7a58026bc0f914aaf613b581017c4caa44103da8
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-184726840/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector /tmp/MERGED-2353378044/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector
--- /tmp/LIVE-184726840/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2023-11-14 19:00:52.006524616 +0000
+++ /tmp/MERGED-2353378044/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2023-11-14 19:00:52.006524616 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "64"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 64
+  generation: 65
   labels:
     app: handle-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 22a6446049b35473bb781ae5abb93303fa6d535f
+    app.kubernetes.io/version: 7a58026bc0f914aaf613b581017c4caa44103da8
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-projector
@@ -73,7 +73,7 @@
               name: handle-owner-user.dev-preview-dbsync-db.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: handle
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:wibngs65njnjvf8xw9fvv095x8lkldjr
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:v6msgixhy8kz6yjjs4nba3kczp0g8xfi
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-184726840/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-2353378044/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-184726840/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2023-11-14 19:00:52.338526832 +0000
+++ /tmp/MERGED-2353378044/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2023-11-14 19:00:52.338526832 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "31"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 31
+  generation: 32
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 22a6446049b35473bb781ae5abb93303fa6d535f
+    app.kubernetes.io/version: 7a58026bc0f914aaf613b581017c4caa44103da8
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
@@ -81,7 +81,7 @@
           value: handle
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:wibngs65njnjvf8xw9fvv095x8lkldjr
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:v6msgixhy8kz6yjjs4nba3kczp0g8xfi
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-184726840/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker /tmp/MERGED-2353378044/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker
--- /tmp/LIVE-184726840/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2023-11-14 19:00:52.610528649 +0000
+++ /tmp/MERGED-2353378044/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2023-11-14 19:00:52.610528649 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "64"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 64
+  generation: 65
   labels:
     app: pg-boss-worker
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 22a6446049b35473bb781ae5abb93303fa6d535f
+    app.kubernetes.io/version: 7a58026bc0f914aaf613b581017c4caa44103da8
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-pg-boss-worker
@@ -92,10 +92,10 @@
               key: username
               name: stakepool-owner-user.dev-preview-dbsync-db.credentials.postgresql.acid.zalan.do
         - name: QUEUES
-          value: pool-delist-schedule,pool-metadata,pool-metrics,pool-rewards
+          value: pool-metadata,pool-metrics
         - name: STAKE_POOL_PROVIDER_URL
           value: http://dev-preview-cardanojs-backend.dev-preview.svc.cluster.local
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:wibngs65njnjvf8xw9fvv095x8lkldjr
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:v6msgixhy8kz6yjjs4nba3kczp0g8xfi
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-184726840/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector /tmp/MERGED-2353378044/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector
--- /tmp/LIVE-184726840/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2023-11-14 19:00:52.822530066 +0000
+++ /tmp/MERGED-2353378044/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2023-11-14 19:00:52.822530066 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "64"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 64
+  generation: 65
   labels:
     app: stake-pool-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 22a6446049b35473bb781ae5abb93303fa6d535f
+    app.kubernetes.io/version: 7a58026bc0f914aaf613b581017c4caa44103da8
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-projector
@@ -72,8 +72,8 @@
               key: username
               name: stakepool-owner-user.dev-preview-dbsync-db.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
-          value: stake-pool,stake-pool-metadata-job,stake-pool-metrics-job,stake-pool-rewards-job
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:wibngs65njnjvf8xw9fvv095x8lkldjr
+          value: stake-pool,stake-pool-metadata-job,stake-pool-metrics-job
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:v6msgixhy8kz6yjjs4nba3kczp0g8xfi
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-184726840/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-2353378044/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-184726840/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2023-11-14 19:00:53.030531455 +0000
+++ /tmp/MERGED-2353378044/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2023-11-14 19:00:53.030531455 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "61"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 61
+  generation: 62
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 22a6446049b35473bb781ae5abb93303fa6d535f
+    app.kubernetes.io/version: 7a58026bc0f914aaf613b581017c4caa44103da8
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider
@@ -83,7 +83,7 @@
           value: http://dev-preview-cardano-stack-metadata.dev-preview.svc.cluster.local
         - name: USE_TYPEORM_STAKE_POOL_PROVIDER
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:wibngs65njnjvf8xw9fvv095x8lkldjr
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:v6msgixhy8kz6yjjs4nba3kczp0g8xfi
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-184726840/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor /tmp/MERGED-2353378044/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor
--- /tmp/LIVE-184726840/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2023-11-14 19:00:53.250532924 +0000
+++ /tmp/MERGED-2353378044/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2023-11-14 19:00:53.250532924 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 22a6446049b35473bb781ae5abb93303fa6d535f
+    app.kubernetes.io/version: 7a58026bc0f914aaf613b581017c4caa44103da8
     instance: primary
   name: lace-backend-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-184726840/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor /tmp/MERGED-2353378044/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor
--- /tmp/LIVE-184726840/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2023-11-14 19:00:53.482534474 +0000
+++ /tmp/MERGED-2353378044/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2023-11-14 19:00:53.482534474 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 22a6446049b35473bb781ae5abb93303fa6d535f
+    app.kubernetes.io/version: 7a58026bc0f914aaf613b581017c4caa44103da8
     instance: primary
   name: lace-handle-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-184726840/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor /tmp/MERGED-2353378044/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor
--- /tmp/LIVE-184726840/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2023-11-14 19:00:53.698535918 +0000
+++ /tmp/MERGED-2353378044/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2023-11-14 19:00:53.698535918 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 22a6446049b35473bb781ae5abb93303fa6d535f
+    app.kubernetes.io/version: 7a58026bc0f914aaf613b581017c4caa44103da8
     instance: primary
   name: lace-stake-pool-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-184726840/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-2353378044/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-184726840/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2023-11-14 19:00:53.930537468 +0000
+++ /tmp/MERGED-2353378044/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2023-11-14 19:00:53.930537468 +0000
@@ -19,7 +19,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 22a6446049b35473bb781ae5abb93303fa6d535f
+    app.kubernetes.io/version: 7a58026bc0f914aaf613b581017c4caa44103da8
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-184726840/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-2353378044/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-184726840/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-11-14 19:00:54.130538805 +0000
+++ /tmp/MERGED-2353378044/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-11-14 19:00:54.130538805 +0000
@@ -16,7 +16,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 22a6446049b35473bb781ae5abb93303fa6d535f
+    app.kubernetes.io/version: 7a58026bc0f914aaf613b581017c4caa44103da8
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-184726840/v1.Service.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-2353378044/v1.Service.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-184726840/v1.Service.dev-preview.dev-preview-cardanojs-backend	2023-11-14 19:00:50.270513024 +0000
+++ /tmp/MERGED-2353378044/v1.Service.dev-preview.dev-preview-cardanojs-backend	2023-11-14 19:00:50.270513024 +0000
@@ -5,7 +5,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 22a6446049b35473bb781ae5abb93303fa6d535f
+    app.kubernetes.io/version: 7a58026bc0f914aaf613b581017c4caa44103da8
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-184726840/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-2353378044/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-184726840/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-11-14 19:00:50.546514866 +0000
+++ /tmp/MERGED-2353378044/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-11-14 19:00:50.546514866 +0000
@@ -5,7 +5,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 22a6446049b35473bb781ae5abb93303fa6d535f
+    app.kubernetes.io/version: 7a58026bc0f914aaf613b581017c4caa44103da8
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-184726840/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-2353378044/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-184726840/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2023-11-14 19:00:50.798516550 +0000
+++ /tmp/MERGED-2353378044/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2023-11-14 19:00:50.798516550 +0000
@@ -5,7 +5,7 @@
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 22a6446049b35473bb781ae5abb93303fa6d535f
+    app.kubernetes.io/version: 7a58026bc0f914aaf613b581017c4caa44103da8
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
diff -u -N /tmp/LIVE-184726840/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-2353378044/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-184726840/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2023-11-14 19:00:51.034518126 +0000
+++ /tmp/MERGED-2353378044/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2023-11-14 19:00:51.034518126 +0000
@@ -5,7 +5,7 @@
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 22a6446049b35473bb781ae5abb93303fa6d535f
+    app.kubernetes.io/version: 7a58026bc0f914aaf613b581017c4caa44103da8
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider

@mirceahasegan mirceahasegan force-pushed the fix/lw-8951-reject-tx-submit-errors branch from 5a5e899 to 76a2273 Compare November 14, 2023 18:49
iccicci
iccicci approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@iccicci iccicci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AngelCastilloB AngelCastilloB self-requested a review November 15, 2023 08:48
AngelCastilloB
AngelCastilloB approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@AngelCastilloB AngelCastilloB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mirceahasegan mirceahasegan merged commit 9ba4063 into conway-era Nov 15, 2023
@mirceahasegan mirceahasegan deleted the fix/lw-8951-reject-tx-submit-errors branch November 15, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iccicci iccicci iccicci approved these changes

@AngelCastilloB AngelCastilloB AngelCastilloB approved these changes

@mkazlauskas mkazlauskas Awaiting requested review from mkazlauskas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mirceahasegan @iccicci @AngelCastilloB