LW-6934 - Add subhandle support in handle projection #993

VanessaPC · 2023-11-17T09:23:41Z

Context

We are expanding the handle projection to accommodate for parent handles and subhandles.
The subhandle types accommodate for two types:

virtual subhandles : https://preview.cexplorer.io/asset/asset1tq39gyh33j492lcwvgjg8w53vnffcqjvksn9sz
nft subhandles : https://preview.cexplorer.io/asset/asset1a38l5yqdlnw98qmdmhvavsh6a64xx2esh0srj5/preview#data

Proposed Solution

Expand the mappers to resolve subhandles
extend the entity to add columns for them
update the db sync to take now the data
update storeHandles to store the subhandles
update TypeOrmHandleProvider to resolve the parentHandle

Important Changes Introduced

packages/projection/src/operators/Mappers/withHandles.ts

github-actions · 2023-11-20T08:45:57Z

Standard DiffPost

This PR would generate the following kubectl diff:

Preview

diff -u -N /tmp/LIVE-2701408287/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-2908445310/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-2701408287/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2023-12-13 13:57:14.097656107 +0000
+++ /tmp/MERGED-2908445310/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-backend	2023-12-13 13:57:14.097656107 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "87"
   creationTimestamp: "2023-08-11T18:16:12Z"
-  generation: 87
+  generation: 88
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 03e503ddd333c08ec2346437c12774b7450606cd
+    app.kubernetes.io/version: a4c21c2e32b9c0142e25fb002df9d241a8a6a528
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
@@ -89,7 +89,7 @@
           value: "false"
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:i0ysd6p1cbvim57nf4k745c00dydjizk
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:0w0fj70bh30ny470zr08qmkw256i59ss
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2701408287/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-2908445310/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-2701408287/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-12-13 13:57:14.405654474 +0000
+++ /tmp/MERGED-2908445310/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-12-13 13:57:14.405654474 +0000
@@ -8,7 +8,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 03e503ddd333c08ec2346437c12774b7450606cd
+    app.kubernetes.io/version: a4c21c2e32b9c0142e25fb002df9d241a8a6a528
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-2701408287/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector /tmp/MERGED-2908445310/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector
--- /tmp/LIVE-2701408287/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2023-12-13 13:57:14.717652822 +0000
+++ /tmp/MERGED-2908445310/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-projector	2023-12-13 13:57:14.717652822 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "87"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 87
+  generation: 88
   labels:
     app: handle-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 03e503ddd333c08ec2346437c12774b7450606cd
+    app.kubernetes.io/version: a4c21c2e32b9c0142e25fb002df9d241a8a6a528
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-projector
@@ -73,7 +73,7 @@
               name: handle-owner-user.dev-preview-dbsync-db.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: handle
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:i0ysd6p1cbvim57nf4k745c00dydjizk
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:0w0fj70bh30ny470zr08qmkw256i59ss
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2701408287/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-2908445310/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-2701408287/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2023-12-13 13:57:15.037651129 +0000
+++ /tmp/MERGED-2908445310/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-handle-provider	2023-12-13 13:57:15.041651107 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "54"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 54
+  generation: 55
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 03e503ddd333c08ec2346437c12774b7450606cd
+    app.kubernetes.io/version: a4c21c2e32b9c0142e25fb002df9d241a8a6a528
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
@@ -81,7 +81,7 @@
           value: handle
         - name: USE_KORA_LABS
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:i0ysd6p1cbvim57nf4k745c00dydjizk
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:0w0fj70bh30ny470zr08qmkw256i59ss
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2701408287/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker /tmp/MERGED-2908445310/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker
--- /tmp/LIVE-2701408287/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2023-12-13 13:57:15.357649433 +0000
+++ /tmp/MERGED-2908445310/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-pg-boss-worker	2023-12-13 13:57:15.357649433 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "87"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 87
+  generation: 88
   labels:
     app: pg-boss-worker
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 03e503ddd333c08ec2346437c12774b7450606cd
+    app.kubernetes.io/version: a4c21c2e32b9c0142e25fb002df9d241a8a6a528
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-pg-boss-worker
@@ -95,7 +95,7 @@
           value: pool-delist-schedule,pool-metadata,pool-metrics,pool-rewards
         - name: STAKE_POOL_PROVIDER_URL
           value: http://dev-preview-cardanojs-backend.dev-preview.svc.cluster.local
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:i0ysd6p1cbvim57nf4k745c00dydjizk
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:0w0fj70bh30ny470zr08qmkw256i59ss
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2701408287/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector /tmp/MERGED-2908445310/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector
--- /tmp/LIVE-2701408287/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2023-12-13 13:57:15.669647779 +0000
+++ /tmp/MERGED-2908445310/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-projector	2023-12-13 13:57:15.669647779 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "87"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 87
+  generation: 88
   labels:
     app: stake-pool-projector
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 03e503ddd333c08ec2346437c12774b7450606cd
+    app.kubernetes.io/version: a4c21c2e32b9c0142e25fb002df9d241a8a6a528
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-projector
@@ -73,7 +73,7 @@
               name: stakepool-owner-user.dev-preview-dbsync-db.credentials.postgresql.acid.zalan.do
         - name: PROJECTION_NAMES
           value: stake-pool,stake-pool-metadata-job,stake-pool-metrics-job,stake-pool-rewards-job
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:i0ysd6p1cbvim57nf4k745c00dydjizk
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:0w0fj70bh30ny470zr08qmkw256i59ss
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2701408287/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-2908445310/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-2701408287/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2023-12-13 13:57:15.981646127 +0000
+++ /tmp/MERGED-2908445310/apps.v1.Deployment.dev-preview.dev-preview-cardanojs-stake-pool-provider	2023-12-13 13:57:15.981646127 +0000
@@ -4,11 +4,11 @@
   annotations:
     deployment.kubernetes.io/revision: "84"
   creationTimestamp: "2023-08-11T18:16:13Z"
-  generation: 84
+  generation: 85
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 03e503ddd333c08ec2346437c12774b7450606cd
+    app.kubernetes.io/version: a4c21c2e32b9c0142e25fb002df9d241a8a6a528
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider
@@ -83,7 +83,7 @@
           value: http://dev-preview-cardano-stack-metadata.dev-preview.svc.cluster.local
         - name: USE_TYPEORM_STAKE_POOL_PROVIDER
           value: "true"
-        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:i0ysd6p1cbvim57nf4k745c00dydjizk
+        image: 926093910549.dkr.ecr.us-east-1.amazonaws.com/cardano-services:0w0fj70bh30ny470zr08qmkw256i59ss
         imagePullPolicy: IfNotPresent
         livenessProbe:
           failureThreshold: 3
diff -u -N /tmp/LIVE-2701408287/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor /tmp/MERGED-2908445310/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor
--- /tmp/LIVE-2701408287/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2023-12-13 13:57:16.293644473 +0000
+++ /tmp/MERGED-2908445310/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-backend-monitor	2023-12-13 13:57:16.293644473 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 03e503ddd333c08ec2346437c12774b7450606cd
+    app.kubernetes.io/version: a4c21c2e32b9c0142e25fb002df9d241a8a6a528
     instance: primary
   name: lace-backend-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-2701408287/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor /tmp/MERGED-2908445310/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor
--- /tmp/LIVE-2701408287/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2023-12-13 13:57:16.605642820 +0000
+++ /tmp/MERGED-2908445310/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-handle-provider-monitor	2023-12-13 13:57:16.605642820 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 03e503ddd333c08ec2346437c12774b7450606cd
+    app.kubernetes.io/version: a4c21c2e32b9c0142e25fb002df9d241a8a6a528
     instance: primary
   name: lace-handle-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-2701408287/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor /tmp/MERGED-2908445310/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor
--- /tmp/LIVE-2701408287/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2023-12-13 13:57:16.917641169 +0000
+++ /tmp/MERGED-2908445310/monitoring.coreos.com.v1.ServiceMonitor.dev-preview.lace-stake-pool-provider-monitor	2023-12-13 13:57:16.917641169 +0000
@@ -5,7 +5,7 @@
   generation: 2
   labels:
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 03e503ddd333c08ec2346437c12774b7450606cd
+    app.kubernetes.io/version: a4c21c2e32b9c0142e25fb002df9d241a8a6a528
     instance: primary
   name: lace-stake-pool-provider-monitor
   namespace: dev-preview
diff -u -N /tmp/LIVE-2701408287/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-2908445310/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-2701408287/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2023-12-13 13:57:17.233639495 +0000
+++ /tmp/MERGED-2908445310/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-backend	2023-12-13 13:57:17.233639495 +0000
@@ -19,7 +19,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 03e503ddd333c08ec2346437c12774b7450606cd
+    app.kubernetes.io/version: a4c21c2e32b9c0142e25fb002df9d241a8a6a528
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-2701408287/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-2908445310/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-2701408287/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-12-13 13:57:17.541637864 +0000
+++ /tmp/MERGED-2908445310/networking.k8s.io.v1.Ingress.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-12-13 13:57:17.541637864 +0000
@@ -16,7 +16,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 03e503ddd333c08ec2346437c12774b7450606cd
+    app.kubernetes.io/version: a4c21c2e32b9c0142e25fb002df9d241a8a6a528
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-2701408287/v1.Service.dev-preview.dev-preview-cardanojs-backend /tmp/MERGED-2908445310/v1.Service.dev-preview.dev-preview-cardanojs-backend
--- /tmp/LIVE-2701408287/v1.Service.dev-preview.dev-preview-cardanojs-backend	2023-12-13 13:57:12.865662663 +0000
+++ /tmp/MERGED-2908445310/v1.Service.dev-preview.dev-preview-cardanojs-backend	2023-12-13 13:57:12.865662663 +0000
@@ -5,7 +5,7 @@
   labels:
     app: backend
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 03e503ddd333c08ec2346437c12774b7450606cd
+    app.kubernetes.io/version: a4c21c2e32b9c0142e25fb002df9d241a8a6a528
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-backend
diff -u -N /tmp/LIVE-2701408287/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy /tmp/MERGED-2908445310/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy
--- /tmp/LIVE-2701408287/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-12-13 13:57:13.177660994 +0000
+++ /tmp/MERGED-2908445310/v1.Service.dev-preview.dev-preview-cardanojs-coingecko-proxy	2023-12-13 13:57:13.177660994 +0000
@@ -5,7 +5,7 @@
   labels:
     app: coingecko-proxy
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 03e503ddd333c08ec2346437c12774b7450606cd
+    app.kubernetes.io/version: a4c21c2e32b9c0142e25fb002df9d241a8a6a528
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-coingecko-proxy
diff -u -N /tmp/LIVE-2701408287/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider /tmp/MERGED-2908445310/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider
--- /tmp/LIVE-2701408287/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2023-12-13 13:57:13.481659370 +0000
+++ /tmp/MERGED-2908445310/v1.Service.dev-preview.dev-preview-cardanojs-handle-provider	2023-12-13 13:57:13.481659370 +0000
@@ -5,7 +5,7 @@
   labels:
     app: handle-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 03e503ddd333c08ec2346437c12774b7450606cd
+    app.kubernetes.io/version: a4c21c2e32b9c0142e25fb002df9d241a8a6a528
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-handle-provider
diff -u -N /tmp/LIVE-2701408287/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider /tmp/MERGED-2908445310/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider
--- /tmp/LIVE-2701408287/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2023-12-13 13:57:13.789657739 +0000
+++ /tmp/MERGED-2908445310/v1.Service.dev-preview.dev-preview-cardanojs-stake-pool-provider	2023-12-13 13:57:13.789657739 +0000
@@ -5,7 +5,7 @@
   labels:
     app: stake-pool-provider
     app.kubernetes.io/managed-by: std-kubectl
-    app.kubernetes.io/version: 03e503ddd333c08ec2346437c12774b7450606cd
+    app.kubernetes.io/version: a4c21c2e32b9c0142e25fb002df9d241a8a6a528
     network: preview
     release: dev-preview-cardanojs
   name: dev-preview-cardanojs-stake-pool-provider

packages/projection/test/operators/Mappers/withHandles.test.ts

packages/projection/test/operators/Mappers/handleUtil.ts

packages/projection/test/operators/Mappers/withHandles.test.ts

packages/projection/src/operators/Mappers/withHandles.ts

packages/projection/test/operators/Mappers/withHandles.test.ts

packages/projection/src/operators/Mappers/withHandles.ts

packages/projection-typeorm/src/entity/Handle.entity.ts

packages/projection/test/operators/Mappers/withHandles.test.ts

packages/projection/src/operators/Mappers/withHandles.ts

packages/cardano-services/src/Projection/migrations/1700556589063-handle-parent.ts

packages/projection/src/operators/Mappers/withHandles.ts

packages/projection/test/operators/Mappers/withHandles.test.ts

packages/projection/src/operators/Mappers/withCIP67.ts

packages/projection/test/operators/Mappers/withHandles.test.ts

packages/projection-typeorm/src/operators/storeHandles.ts

packages/projection/src/operators/Mappers/withHandles.ts

packages/projection/src/operators/Mappers/withCIP67.ts

packages/core/test/Asset/util/isValidHandle.test.ts

packages/projection/src/operators/Mappers/withCIP67.ts

packages/util-dev/src/Cip19TestVectors.ts

packages/cardano-services/test/Handle/TypeOrmHandleProvider.test.ts

packages/e2e/src/util/handle-util.ts

packages/e2e/test/wallet/PersonalWallet/phase2validation.test.ts

packages/projection-typeorm/test/operators/storeHandles/subhandle.test.ts

packages/projection/src/operators/Mappers/withCIP67.ts

packages/projection/src/operators/Mappers/withHandleMetadata.ts

packages/projection/test/operators/Mappers/withCIP67.test.ts

packages/projection/test/operators/Mappers/withHandles.test.ts

mkazlauskas

Great work! There's a tsc error in tests, please fix that and squash for final reviews

packages/cardano-services/test/Asset/DbSyncAssetProvider.test.ts

…nment

iccicci

LGTM!

mkazlauskas

Great work! 💪

Please squash these commits together before merging and make it the last commit:
1e9b547
58e84b0
4b318ec
a13b73b
54a52f0
a450e03
67d7dcc
6e19e6d
a58f9a9

This commit will be the actual implementation of the feature, including changes to sql snapshots and the provider: SDK should have green build&test at each commit. It's also possible to split up the projector/test snapshots/provider changes (3 commits instead of 1), but I don't think it's worth doing that. Please combine the commit messages to describe the changes in commit message body.

…uery responses

…an be collected in withHandles mapper

- update migration with handle parent migration for parent handles - store parent handle data in db - fix mint-handles.js script that was broken due to refactor - extend withHandles mappers to extract subhandle data - fix e2e test to take more handle data - generate sql data for subhandles to be used in tests - extend TypeOrmHandleProvider to resolve parent handles

mkazlauskas

Great work! 🚀

VanessaPC changed the title ~~']dd subhandle support in handle projection~~ [DRAFT] LW-6934 - Add subhandle support in handle projection Nov 17, 2023

VanessaPC marked this pull request as draft November 17, 2023 09:24

VanessaPC commented Nov 17, 2023

View reviewed changes

packages/projection/src/operators/Mappers/withHandles.ts Outdated Show resolved Hide resolved

VanessaPC force-pushed the feat/LW-6934-subhandle-setup branch from c42061d to d387d4c Compare November 20, 2023 08:33

VanessaPC force-pushed the feat/LW-6934-subhandle-setup branch from d387d4c to a13d20a Compare November 20, 2023 08:48

VanessaPC changed the title ~~[DRAFT] LW-6934 - Add subhandle support in handle projection~~ LW-6934 - Add subhandle support in handle projection Nov 20, 2023

VanessaPC self-assigned this Nov 20, 2023

VanessaPC requested a review from mkazlauskas November 20, 2023 08:54

mkazlauskas requested changes Nov 20, 2023

View reviewed changes

VanessaPC requested a review from mkazlauskas November 20, 2023 14:26

VanessaPC marked this pull request as ready for review November 20, 2023 14:32

VanessaPC requested a review from iccicci November 20, 2023 14:52

mkazlauskas requested changes Nov 20, 2023

View reviewed changes

mkazlauskas requested changes Nov 21, 2023

View reviewed changes

VanessaPC requested a review from mkazlauskas November 21, 2023 14:06

mkazlauskas reviewed Nov 21, 2023

View reviewed changes

packages/projection/src/operators/Mappers/withHandles.ts Outdated Show resolved Hide resolved

packages/projection/test/operators/Mappers/withHandles.test.ts Outdated Show resolved Hide resolved

VanessaPC requested review from mkazlauskas, AngelCastilloB and tomislavhoracek November 22, 2023 10:13

mkazlauskas requested changes Nov 22, 2023

View reviewed changes

packages/core/test/Asset/util/isValidHandle.test.ts Outdated Show resolved Hide resolved

packages/core/test/Asset/util/isValidHandle.test.ts Outdated Show resolved Hide resolved

mkazlauskas requested changes Nov 22, 2023

View reviewed changes

packages/projection/src/operators/Mappers/withCIP67.ts Outdated Show resolved Hide resolved

VanessaPC removed request for AngelCastilloB and tomislavhoracek November 22, 2023 16:25

mkazlauskas reviewed Nov 23, 2023

View reviewed changes

packages/util-dev/src/Cip19TestVectors.ts Outdated Show resolved Hide resolved

VanessaPC marked this pull request as draft November 23, 2023 08:40

VanessaPC marked this pull request as ready for review December 7, 2023 12:48

VanessaPC requested review from pczeglik-iohk and mkazlauskas December 7, 2023 12:50

mkazlauskas requested changes Dec 8, 2023

View reviewed changes

mkazlauskas previously approved these changes Dec 11, 2023

View reviewed changes

VanessaPC dismissed mkazlauskas’s stale review via 7d9b5aa December 11, 2023 10:41

VanessaPC force-pushed the feat/LW-6934-subhandle-setup branch 3 times, most recently from 0639dfa to 7eb6e9a Compare December 11, 2023 12:35

VanessaPC commented Dec 12, 2023

View reviewed changes

packages/cardano-services/test/Asset/DbSyncAssetProvider.test.ts Show resolved Hide resolved

VanessaPC added 2 commits December 12, 2023 19:07

chore(cardano-services): configure handle policy id in preview enviro…

3435605

…nment

test(e2e): disable a flaky test, update assertion of another flaky test

2ca7847

VanessaPC force-pushed the feat/LW-6934-subhandle-setup branch 2 times, most recently from 4ae418f to 858e645 Compare December 13, 2023 09:05

iccicci approved these changes Dec 13, 2023

View reviewed changes

mkazlauskas reviewed Dec 13, 2023

View reviewed changes

VanessaPC added 4 commits December 13, 2023 13:26

test(cardano-services): disable failing tests related to asset info q…

aebe2c5

…uery responses

chore(core): update isValidHandleUtil to accept subhandles

0986ef4

feat: include minted assets in cip67 mapper to ensure minted assets c…

8e1b834

…an be collected in withHandles mapper

VanessaPC force-pushed the feat/LW-6934-subhandle-setup branch from 858e645 to 3fa3920 Compare December 13, 2023 13:28

mkazlauskas approved these changes Dec 13, 2023

View reviewed changes

VanessaPC merged commit 7fe1e6d into master Dec 13, 2023

VanessaPC deleted the feat/LW-6934-subhandle-setup branch December 13, 2023 14:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LW-6934 - Add subhandle support in handle projection #993

LW-6934 - Add subhandle support in handle projection #993

VanessaPC commented Nov 17, 2023 •

edited

Loading

github-actions bot commented Nov 20, 2023 •

edited

Loading

mkazlauskas left a comment

iccicci left a comment

mkazlauskas left a comment

mkazlauskas left a comment

LW-6934 - Add subhandle support in handle projection #993

LW-6934 - Add subhandle support in handle projection #993

Conversation

VanessaPC commented Nov 17, 2023 • edited Loading

Context

Proposed Solution

Important Changes Introduced

github-actions bot commented Nov 20, 2023 • edited Loading

Standard DiffPost

mkazlauskas left a comment

Choose a reason for hiding this comment

iccicci left a comment

Choose a reason for hiding this comment

mkazlauskas left a comment

Choose a reason for hiding this comment

mkazlauskas left a comment

Choose a reason for hiding this comment

VanessaPC commented Nov 17, 2023 •

edited

Loading

github-actions bot commented Nov 20, 2023 •

edited

Loading