Merge #4051

4051: Disable node monitoring API by default r=disassembler a=KtorZ

## Description

<!--- A brief description of this PR and the problem is trying to solve -->

Instead of using default arguments pointing to files that may or may not be present.
It's better to simply not have it by default, and activate it only when needed

## Linked issue

<!--- Put here the relevant issue from YouTrack -->



Co-authored-by: KtorZ <[email protected]>

Author: iohk-bors[bot]

lib/src/Pos/Client/CLI/NodeOptions.hs

@@ -25,15 +25,14 @@ import           Data.Version (showVersion)
 import           NeatInterpolation (text)
 import           Options.Applicative (Parser, auto, execParser, footerDoc,
                      fullDesc, header, help, helper, info, infoOption, long,
-                     metavar, option, progDesc, showDefault, strOption, switch,
-                     value)
+                     metavar, option, progDesc, strOption, switch, value)
 import           Text.PrettyPrint.ANSI.Leijen (Doc)
 
 import           Paths_cardano_sl (version)
 
 import           Pos.Client.CLI.Options (CommonArgs (..), commonArgsParser,
                      optionalJSONPath, templateParser)
-import           Pos.Core.NetworkAddress (NetworkAddress, addrParser, localhost)
+import           Pos.Core.NetworkAddress (NetworkAddress, addrParser)
 import           Pos.Infra.HealthCheck.Route53 (route53HealthCheckOption)
 import           Pos.Infra.InjectFail (FInjectsSpec, parseFInjectsSpec)
 import           Pos.Infra.Network.CLI (NetworkConfigOpts, networkConfigOption)
@@ -162,7 +161,7 @@ nodeArgsParser = NodeArgs <$> behaviorParser
             metavar "FILE" <>
             help "Path to the behavior config"
 
-data NodeWithApiArgs = NodeWithApiArgs CommonNodeArgs NodeArgs NodeApiArgs
+data NodeWithApiArgs = NodeWithApiArgs CommonNodeArgs NodeArgs (Maybe NodeApiArgs)
 
 nodeWithApiArgsParser :: Parser NodeWithApiArgs
 nodeWithApiArgsParser =
@@ -171,22 +170,19 @@ nodeWithApiArgsParser =
         <*> nodeArgsParser
         <*> nodeApiArgsParser
 
-nodeApiArgsParser :: Parser NodeApiArgs
-nodeApiArgsParser =
-    NodeApiArgs
-        <$> addressParser "node-api-address" (localhost, 8080)
-        <*> tlsParamsParser
-        <*> debugModeParser
-        <*> addressParser "node-doc-address" (localhost, 8180)
+nodeApiArgsParser :: Parser (Maybe NodeApiArgs)
+nodeApiArgsParser = optional $ NodeApiArgs
+    <$> addressParser "node-api-address"
+    <*> tlsParamsParser
+    <*> debugModeParser
+    <*> addressParser "node-doc-address"
   where
-    addressParser flagName defValue =
+    addressParser :: String -> Parser NetworkAddress
+    addressParser flagName =
         option (fromParsec addrParser) $
             long flagName
          <> metavar "IP:PORT"
-         <> help helpMsg
-         <> showDefault
-         <> value defValue
-    helpMsg = "IP and port for backend node API."
+         <> help "IP and port for backend node API."
     debugModeParser :: Parser Bool
     debugModeParser =
         switch (long "wallet-debug" <>
@@ -216,23 +212,20 @@ tlsParamsParser = constructTlsParams <$> certPathParser
                                 "tlscert"
                                 "FILEPATH"
                                 "Path to file with TLS certificate"
-                                <> value "scripts/tls-files/server.crt"
                                )
 
     keyPathParser :: Parser FilePath
     keyPathParser = strOption (templateParser
                                "tlskey"
                                "FILEPATH"
                                "Path to file with TLS key"
-                               <> value "scripts/tls-files/server.key"
                               )
 
     caPathParser :: Parser FilePath
     caPathParser = strOption (templateParser
                               "tlsca"
                               "FILEPATH"
                               "Path to file with TLS certificate authority"
-                              <> value "scripts/tls-files/ca.crt"
                              )
 
     noClientAuthParser :: Parser Bool

node/app/Main.hs

@@ -10,20 +10,22 @@ import           Pos.Client.CLI (NodeWithApiArgs (..), getNodeApiOptions,
                      loggingParams)
 import           Pos.Launcher (actionWithCoreNode, launchNode)
 import           Pos.Util.CompileInfo (compileInfo, withCompileInfo)
+import           Pos.Util.Wlog (logInfo)
 
 main :: IO ()
 main = withCompileInfo $ do
-    NodeWithApiArgs cArgs nArgs apiArgs <- getNodeApiOptions
+    NodeWithApiArgs cArgs nArgs mApiArgs <- getNodeApiOptions
     let lArgs = loggingParams "node" cArgs
+
+    let nodeServer = case mApiArgs of
+            Nothing ->
+                \_ _ _ _ _ _ -> logInfo "Monitoring API is disabled."
+            Just apiArgs ->
+                launchNodeServer apiArgs
+
     launchNode nArgs cArgs lArgs
         $ \genConfig walConfig txpConfig ntpConfig nodeParams sscParams nodeResources ->
             actionWithCoreNode
-                (launchNodeServer
-                    apiArgs
-                    ntpConfig
-                    nodeResources
-                    updateConfiguration
-                    compileInfo
-                    genConfig)
+                (nodeServer ntpConfig nodeResources updateConfiguration compileInfo genConfig)
                 genConfig walConfig txpConfig
                 ntpConfig nodeParams sscParams nodeResources