This repository was archived by the owner on Aug 18, 2020. It is now read-only.
Disable node monitoring API by default #4051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
disassembler
approved these changes
Jan 30, 2019
Merge conflict (retrying...) |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 30, 2019
4050: Internal Endpoints Disclaimer r=KtorZ a=KtorZ ## Description <!--- A brief description of this PR and the problem is trying to solve --> As a follow-up from the discussion in cardano-foundation/cardano-wallet#151 (comment), we will add a proper disclaimer in the documentation about the internal endpoints. ## Linked issue <!--- Put here the relevant issue from YouTrack --> cardano-foundation/cardano-wallet#228 4051: Disable node monitoring API by default r=KtorZ a=KtorZ ## Description <!--- A brief description of this PR and the problem is trying to solve --> Instead of using default arguments pointing to files that may or may not be present. It's better to simply not have it by default, and activate it only when needed ## Linked issue <!--- Put here the relevant issue from YouTrack --> Co-authored-by: KtorZ <[email protected]>
Build failed (retrying...) |
|
bors r- |
Canceled |
|
bors r+ p=10 |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 30, 2019
4051: Disable node monitoring API by default r=disassembler a=KtorZ ## Description <!--- A brief description of this PR and the problem is trying to solve --> Instead of using default arguments pointing to files that may or may not be present. It's better to simply not have it by default, and activate it only when needed ## Linked issue <!--- Put here the relevant issue from YouTrack --> Co-authored-by: KtorZ <[email protected]>
Build failed |
KtorZ
force-pushed
the
KtorZ/node-monitoring-disable-by-default
branch
from
cd8b177 to
8eeed83
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 31, 2019
4051: Disable node monitoring API by default r=KtorZ a=KtorZ ## Description <!--- A brief description of this PR and the problem is trying to solve --> Instead of using default arguments pointing to files that may or may not be present. It's better to simply not have it by default, and activate it only when needed ## Linked issue <!--- Put here the relevant issue from YouTrack --> Co-authored-by: KtorZ <[email protected]>
Timed out |
KtorZ
force-pushed
the
KtorZ/node-monitoring-disable-by-default
branch
from
8eeed83 to
89a12af
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 31, 2019
4051: Disable node monitoring API by default r=KtorZ a=KtorZ ## Description <!--- A brief description of this PR and the problem is trying to solve --> Instead of using default arguments pointing to files that may or may not be present. It's better to simply not have it by default, and activate it only when needed ## Linked issue <!--- Put here the relevant issue from YouTrack --> Co-authored-by: KtorZ <[email protected]>
Timed out |
|
😶 🔫 |
|
bors r+ |
1 similar comment
|
bors r+ |
Merge conflict |
|
bors r+ |
Merge conflict |
Instead of using default arguments pointing to files that may or may not be present. It's better to simply not have it by default, and activate it only when needed
KtorZ
force-pushed
the
KtorZ/node-monitoring-disable-by-default
branch
from
89a12af to
61d350d
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 1, 2019
4051: Disable node monitoring API by default r=KtorZ a=KtorZ ## Description <!--- A brief description of this PR and the problem is trying to solve --> Instead of using default arguments pointing to files that may or may not be present. It's better to simply not have it by default, and activate it only when needed ## Linked issue <!--- Put here the relevant issue from YouTrack --> Co-authored-by: KtorZ <[email protected]>
Build succeeded |
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of using default arguments pointing to files that may or may not be present.
It's better to simply not have it by default, and activate it only when needed
Linked issue
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)
How to merge
Send the message
bors r+to merge this PR. For more information, seedocs/how-to/bors.md.