Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

[DEVOPS-879] demo flag client auth disable #3074

Merged
merged 1 commit into from
Jul 3, 2018

Conversation

disassembler
Copy link
Contributor

Description

Adds a flag for Daedalus team to disable client cert auth with demo.sh.

Linked issue

https://iohk.myjetbrains.com/youtrack/issue/DEVOPS-879

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

@disassembler disassembler changed the title Devops 879 demo flag client auth disable [Devops 879] demo flag client auth disable Jun 8, 2018
@disassembler disassembler force-pushed the devops-879-demo-flag-client-auth-disable branch from f827ad1 to 0bb4bb5 Compare June 8, 2018 13:04
@disassembler disassembler changed the title [Devops 879] demo flag client auth disable [Devops-879] demo flag client auth disable Jun 8, 2018
@disassembler disassembler changed the title [Devops-879] demo flag client auth disable [DEVOPS-879] demo flag client auth disable Jun 8, 2018
@disassembler disassembler requested review from cleverca22 and KtorZ and removed request for erikd, denisshevchenko, parsonsmatt and adinapoli-iohk June 8, 2018 13:05
@disassembler disassembler force-pushed the devops-879-demo-flag-client-auth-disable branch from 0bb4bb5 to 01c2052 Compare July 3, 2018 15:17
@disassembler disassembler merged commit a2009ab into develop Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants