Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

[CBR-96] Remove orphaned Bi instances #3127

Merged
merged 2 commits into from
Jun 26, 2018
Merged

Conversation

coot
Copy link
Contributor

@coot coot commented Jun 25, 2018

Description

This PR removes orphened Bi instances from core. This is split from my work on CBR-96.

Linked issue

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

@coot coot requested a review from erikd June 25, 2018 11:57
@erikd
Copy link
Member

erikd commented Jun 25, 2018

From the build logs:

src/Pos/Binary.hs:12:1: error:
    Could not find module ‘Pos.Binary.Merkle’
    Perhaps you meant Pos.Binary.Core (from cardano-sl-core-1.3.0)
    Use -v to see a list of the files searched for.
   |
12 | import Pos.Binary.Merkle ()

Copy link
Member

@erikd erikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Glad to see some redundant constraints being removed as well.

@erikd erikd merged commit 567c9af into develop Jun 26, 2018
@erikd erikd deleted the coot/cbr-96-orphaned-instances branch June 26, 2018 02:29
@coot
Copy link
Contributor Author

coot commented Jun 26, 2018

Thanks @erikd!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants