Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

[DEVOPS-936] Hydra CI job for stylish-haskell #3166

Merged
merged 2 commits into from
Jul 3, 2018

Conversation

disassembler
Copy link
Contributor

Description

Hydra CI job to alert if a commit breaks stylish-haskell standards.

Linked issue

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

@disassembler disassembler force-pushed the devops-936-stylish-haskell branch from 7580f53 to 2945b4c Compare June 30, 2018 01:31
@disassembler disassembler requested a review from cleverca22 June 30, 2018 01:32
@disassembler disassembler force-pushed the devops-936-stylish-haskell branch from 2945b4c to 374f42d Compare July 2, 2018 16:03
@disassembler disassembler requested a review from erikd as a code owner July 2, 2018 16:03
Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most excellent

@disassembler disassembler force-pushed the devops-936-stylish-haskell branch 3 times, most recently from 3f5dd5f to 99cb32a Compare July 2, 2018 21:49
@disassembler disassembler changed the title [DEVOPS-936] Hydra CI job for sylish-haskell [DEVOPS-936] Hydra CI job for stylish-haskell Jul 2, 2018
@disassembler disassembler force-pushed the devops-936-stylish-haskell branch from 99cb32a to 33b3037 Compare July 3, 2018 13:12
@disassembler disassembler requested a review from vincenthz as a code owner July 3, 2018 13:17
@disassembler disassembler force-pushed the devops-936-stylish-haskell branch 3 times, most recently from 6a33837 to 964ba3e Compare July 3, 2018 14:09
@disassembler disassembler force-pushed the devops-936-stylish-haskell branch from 964ba3e to 7d0b058 Compare July 3, 2018 14:34
@disassembler disassembler merged commit 491a3b2 into develop Jul 3, 2018
(type == "regular" && hasSuffix ".yaml" baseName) ||
(type == "directory")
);
src' = builtins.filterSource cleanSourceFilter src;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this use lib.cleanSourceWith (see example in #3174). That will work better with already filtered sources I think.

@rvl rvl deleted the devops-936-stylish-haskell branch July 4, 2018 23:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants