Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

[CDEC-423] Reunite orphan Bi instances in the delegation package #3200

Merged
merged 1 commit into from
Jul 6, 2018

Conversation

intricate
Copy link
Contributor

Description

Linked issue

https://iohk.myjetbrains.com/youtrack/issue/CDEC-423

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

@intricate intricate self-assigned this Jul 5, 2018
@intricate intricate requested review from erikd, mhuesch and Jimbo4350 July 5, 2018 22:25
@intricate intricate requested a review from akegalj as a code owner July 5, 2018 22:25
@intricate intricate force-pushed the intricate/CDEC-423 branch from e119ab2 to 8ae5bbd Compare July 6, 2018 01:24
Copy link
Contributor

@mhuesch mhuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -24,9 +24,6 @@ library
Pos.Delegation.Types
Pos.Delegation.Worker

-- Binary serialization
Pos.Binary.Delegation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistent Pos.Delegation module prefixes now... very nice!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About time, lol.

@mhuesch mhuesch merged commit 60571cd into develop Jul 6, 2018
@mhuesch mhuesch deleted the intricate/CDEC-423 branch July 6, 2018 05:18
@mhuesch
Copy link
Contributor

mhuesch commented Jul 6, 2018

Just merged this so you don't have to rebase again!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants