This repository was archived by the owner on Aug 18, 2020. It is now read-only.
[CDEC-416] Sinbin Test.Pos.Infra.Arbitrary.Slotting
#3209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhuesch
requested review from
adinapoli-iohk,
erikd and
parsonsmatt
as code owners
Since this is a module of `infra-test`, we create a new `sinbin-test` package. Imports of the sinbinned module in `update` are modified accordingly.
mhuesch
force-pushed
the
mhuesch/CDEC-416-2
branch
from
8ba1df2 to
813ba0c
Compare
|
Ignore the shellcheck failure, unless of course you'd like to fix it :) |
|
@erikd I just tried to here but the original version (on develop) actually doesn't even run for me. It just creates copies of all the cabal files, but with Are you able to run the script from develop successfully on your machine? If so you could test if my modified script works 🙂 |
|
The issue you're having with that script is almost certainly due to Mac's ancient BSD version of sed. |
erikd
approved these changes
Jul 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Free up
infra-testby movingTest.Pos.Infra.Arbitrary.Slottingtosinbin-test.Linked issue
https://iohk.myjetbrains.com/youtrack/issue/CDEC-416
Type of change
Developer checklist
Testing checklist