Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

[CDEC-429] Flesh out package-dep-graph.sh, document it in stack.yaml #3227

Merged
merged 3 commits into from
Jul 12, 2018

Conversation

mhuesch
Copy link
Contributor

@mhuesch mhuesch commented Jul 11, 2018

Description

Flesh out package-dep-graph.sh, document it in stack.yaml

Linked issue

https://iohk.myjetbrains.com/youtrack/issue/CDEC-429

Type of change

  • [~] 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • [~] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • [~] 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • [~] 🔨 New or improved tests for existing code
  • [~] ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.

Testing checklist

  • [~] I have added tests to cover my changes.
  • [~] All new and existing tests passed.
    ^ this change adds & modifies a script which generates a PNG image of the cardano-sl dependency graph. As such, I'm not sure what tests would be useful for it.

@mhuesch mhuesch requested a review from erikd as a code owner July 11, 2018 19:00
@mhuesch mhuesch self-assigned this Jul 11, 2018
Copy link
Contributor Author

@mhuesch mhuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erikd This PR includes your commit from your original PR and then adds more functionality to the script, as requested.

docs/hd.md Outdated

Please note that the purpose of this document is to provide a high-level overview
of HD wallets. For technical details please read [Formal specification for a Cardano
wallet](https://cardanodocs.com/files/formal-specification-of-the-cardano-wallet.pdf).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why this commit shows up in my PR. Perhaps GitHub is confused? I did rebase develop recently, so maybe the commit got picked up...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that seems to be d34e0dd . Best to pop that out of this PR.

erikd and others added 2 commits July 11, 2018 18:50
@mhuesch mhuesch force-pushed the mhuesch/CDEC-429 branch from 610f10a to b6d0958 Compare July 11, 2018 22:51
Copy link
Member

@erikd erikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mhuesch mhuesch force-pushed the mhuesch/CDEC-429 branch from b6d0958 to 7c24703 Compare July 11, 2018 23:23
@erikd erikd merged commit d848f07 into develop Jul 12, 2018
@mhuesch mhuesch deleted the mhuesch/CDEC-429 branch July 12, 2018 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants