This repository was archived by the owner on Aug 18, 2020. It is now read-only.
[CDEC-485] Move Block data types from core to chain package #3351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruhatch
requested review from
adinapoli-iohk,
akegalj,
denisshevchenko,
erikd,
ksaric and
parsonsmatt
as code owners
mhuesch
approved these changes
Aug 4, 2018
| Pos.Core.Block.Main.Instances | ||
| Pos.Core.Block.Main.Types | ||
| Pos.Core.Block.Union.ComponentBlock | ||
| Pos.Core.Block.Union.Types |
| , feedPM | ||
| , feedPMC |
intricate
reviewed
Aug 6, 2018
chain/src/Pos/Chain/Block/JsonLog.hs
Outdated
| , jlAdoptedBlock | ||
| ) where | ||
|
|
||
| import Formatting (sformat) |
There was a problem hiding this comment.
Not a huge deal, but this should be more like:
import Universum
import Formatting (sformat)
intricate
reviewed
Aug 6, 2018
| @@ -54,7 +54,7 @@ instance Bi MainProof where | |||
| decode <*> | |||
| decode | |||
|
|
|||
| instance SafeCopy SscProof => SafeCopy MainProof where | |||
There was a problem hiding this comment.
Was this just a redundant constraint or something?
There was a problem hiding this comment.
The old code base used these to side step orphan instance problems.
parsonsmatt
approved these changes
Aug 6, 2018
| @@ -54,7 +54,7 @@ instance Bi MainProof where | |||
| decode <*> | |||
| decode | |||
|
|
|||
| instance SafeCopy SscProof => SafeCopy MainProof where | |||
There was a problem hiding this comment.
The old code base used these to side step orphan instance problems.
erikd
approved these changes
Aug 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to reduce the size of the
corepackage and put everything related to blocks and chains in thechainpackage. This first PR clears the way for that and move thePos.Core.Blockmodules across.Linked issue
CDEC-485
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)