This repository was archived by the owner on Aug 18, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new implementation is significantly simpler than the one in the legacy
wallet. In particular, we do not bother to run coin selection. Instead, we
simply
There can be at most 1; if 0, already redeemed.
freshly generated address), for the full amount of the voucher.
I've verified this approach with a bunch of people and tried to compare it to the redemption transactions that actually currently exist on the blockchain, and it seems this is indeed the right approach. Just for reference, here is one such transaction:
https://cardanoexplorer.com/address/m2MIpUqWMTQJwK9F4LnaNstGh4BjMy2L2GDHpsuCAPA%3D
However, do note that this is untested; that will need to be done by someone else on a test cluster.
Linked issue
https://iohk.myjetbrains.com/youtrack/issue/CBR-349
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)