This repository was archived by the owner on Aug 18, 2020. It is now read-only.
Faucet rebased and squashed against develop #3541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure this code should go into develop. It should go into release/1.3.1. |
|
@jcmincke The faucet code is already in the release/1.3.1 release. This is simply the port of that code into the develop branch. Porting it separately is a cleaner more reliable way of moving code between branches than the huge, potentially unreliable "git merge"s we have been doing. |
|
@erikd Thanks, when do you think it can be merged? |
|
Well it obviously cannot be merged until it passes CI. |
|
This PR is missing my commit ce421d8 from release/1.3.1. That change helps with local manual testing of faucet. |
|
@rvl - Yes I think that commit should be included |
…velop [DEVOPS-834] Add a process that checks the wallet balance periodically [DEVOPS-834] Uncomment type sig as suggested [DEVOPS-834] Fix copyright in license [DEVOPS-834] Split queue logic from withdrawl function Also document the processWithdrawls function [DEVOPS-834] Remove faucet shell.nix, default.nix and .projectile [DEVOPS-834] Remove commented code [DEVOPS-834] withdrawl -> withdrawal [DEVOPS-834] Get test suite running [DEVOPS-834] Apply stack2nix patch from buildkite And stylish.diff from hydra [DEVOPS-834] Change executable name to cardano-faucet [DEVOPS-834] Switch to optparse-applicative for command line Add the --ekg-server commandline option [DEVOPS-834] Use a file to read the recaptcha secret from a file * Config parameter has changed to "recaptcha-secret-file" * The actual secret is now a field in FaucetEnv [DEVOPS-834] Change logging of wallet balance to DEBUG [DEVOPS-834] Handle newlines in recaptcha secret file Also adds a couple of tests for readCaptchaSecret [DEVOPS-834] Apply stylish.diff [DEVOPS-834] Add demo frontend to faucet [DEVOPS-834] Fix faucet static serving [DEVOPS-834] Apply stylish haskell fixes [DEVOPS-834] Add universium and fix indentation/sorting of deps [DEVOPS-834] Switch to universum [DEVOPS-834] Switch to safe-exceptions [DEVOPS-834] Fix for upstream API changes [DEVOPS-834] Apply stack2nix patch [DEVOPS-834] Apply stylish.diff from hydra [DEVOPS-834] Remove existing wallet json file [DEVOP-834] Add -Wall everywhere [DEVOPS-834] Use a pattern match instead of whenJust [DEVOPS-834] Remove unused decrWithdrawn function [DEVOPS-834] Remove unused DepositRequest and DepositResult [DEVOPS-834] Remove -Wall from the modules [DEVOPS-834] Fix some warnings
|
Rebased and cherry-pick the commit @rvl mentioned. |
Helps when testing locally using curl. If there is a recaptcha secret configured, it will fail the recaptcha check and return HTTP 400. (cherry picked from commit ce421d8)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3513 and #2939 which contain the same work but are hard to impossible to merge back to develop
cc @erikd