This repository was archived by the owner on Aug 18, 2020. It is now read-only.
[CBR-426] Crashes node upon wallet failure #3584
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prior to this commit, an exception in the wallet would simply log an
error message and silently die, keeping the underlying node running.
This is rather unintuitive especially in situation where we don't
necessarily have eyes on logs (e.g. running a demo cluster). When a
node uses the wallet, if the wallet crashes, the node ought to crash as
well.
That is especially true when network binding address is already taken,
which occurs fairly often during development / testing (i.e. a prior
node is still listening to :8090 and the new one fails to bound. Then,
requests are made against a running node which is not the one we
expect!!)
Linked issue
[CBR-426]
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)