This repository was archived by the owner on Aug 18, 2020. It is now read-only.
[CDEC-505] Move Pos.Core.Genesis to Pos.Chain.Genesis #3593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruhatch
force-pushed
the
ruhatch/CDEC-505
branch
from
94cde4b to
130880f
Compare
mhuesch
reviewed
Sep 13, 2018
There was a problem hiding this comment.
LGTM. I'll let @parsonsmatt give the official approval, since he's doing a more in-depth review.
| -- StaticConfig | ||
| -------------------------------------------------------------------------------- | ||
|
|
||
| data StaticConfig |
There was a problem hiding this comment.
I like this new name. GenesisConfiguration was fairly misleading because plenty of stuff in there isn't Genesis related per se. We still have that issue with GenesisSpec, I suppose. But this seems like progress.
| @@ -1,6 +1,6 @@ | |||
| {-# LANGUAGE Rank2Types #-} | |||
|
|
|||
| module Pos.Core.Configuration.GenesisHash | |||
| module Pos.Chain.Genesis.Hash | |||
| deriving instance Hashable Address => Semigroup GenesisNonAvvmBalances | ||
| deriving instance Hashable Address => Monoid GenesisNonAvvmBalances | ||
| deriving instance Semigroup GenesisNonAvvmBalances | ||
| deriving instance Monoid GenesisNonAvvmBalances |
| hasKnownFeePolicy BlockVersionData {bvdTxFeePolicy = TxFeePolicyTxSizeLinear {}} = | ||
| True | ||
| hasKnownFeePolicy _ = False | ||
| arbitraryVssCerts = mkVssCertificatesMapLossy <$> arbitrary |
| hexToBS :: Text -> ByteString | ||
| hexToBS ts = case B16.decode ts of | ||
| Left err -> error $ "decode failed: " <> show err | ||
| Right bs -> bs |
There was a problem hiding this comment.
👍
As a side note, I like *.Example module naming idiom much better than my *.ExampleHelpers. Even if the module contains helpers.
ruhatch
force-pushed
the
ruhatch/CDEC-505
branch
from
130880f to
3530b64
Compare
parsonsmatt
approved these changes
Sep 13, 2018
|
|
||
| instance Monad m => ToJSON m GenesisNonAvvmBalances where | ||
| toJSON = toJSON . getGenesisNonAvvmBalances | ||
|
|
||
| instance ReportSchemaErrors m => FromJSON m GenesisNonAvvmBalances where | ||
| instance | ||
| (Monad m, Applicative m, MonadError SchemaError m) |
There was a problem hiding this comment.
Monad and Applicatve are redundant here as MonadError implies them
| @@ -42,7 +43,10 @@ instance Monad m => ToJSON m GenesisProtocolConstants where | |||
| , ("vssMinTTL", toJSON gpcVssMinTTL) | |||
| ] | |||
|
|
|||
| instance ReportSchemaErrors m => FromJSON m GenesisProtocolConstants where | |||
| instance | |||
| (Monad m, MonadError SchemaError m) | |||
There was a problem hiding this comment.
Monad is redudant here
| @@ -39,7 +39,10 @@ instance Buildable GenesisWStakeholders where | |||
| instance Monad m => ToJSON m GenesisWStakeholders where | |||
| toJSON (GenesisWStakeholders stks) = toJSON stks | |||
|
|
|||
| instance ReportSchemaErrors m => FromJSON m GenesisWStakeholders where | |||
| instance | |||
| (Monad m, MonadError SchemaError m) | |||
ruhatch
force-pushed
the
ruhatch/CDEC-505
branch
from
3530b64 to
c3c5955
Compare
ruhatch
force-pushed
the
ruhatch/CDEC-505
branch
from
c3c5955 to
0ba276e
Compare
KtorZ
pushed a commit
that referenced
this pull request
Nov 9, 2018
[CDEC-505] Move Pos.Core.Genesis to Pos.Chain.Genesis
KtorZ
pushed a commit
to input-output-hk/cardano-wallet-legacy
that referenced
this pull request
Nov 9, 2018
…hk/ruhatch/CDEC-505 [CDEC-505] Move Pos.Core.Genesis to Pos.Chain.Genesis
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This moves the
Pos.Core.Genesismodule group into thechainpackage. This is also involves movingCore.Configtype toGenesis.Config, so touches all the site where thatConfigwas propagated. This is laying the foundation for aChain.Configtype that will combineGenesis.Config,Txp.Config, etc.Linked issue
CDEC-505
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)