This repository was archived by the owner on Aug 18, 2020. It is now read-only.
[DEVOPS-1100] Catch errors in check-hydra.sh and exit appropriately #3762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvl
suggested changes
Oct 18, 2018
There was a problem hiding this comment.
Looks like it works, although shellcheck doesn't approve yet.
You could rebase this on latest master and fix the eval (remove attributes for cardano-report-server-static cardano-report-server cardano-sl-explorer-frontend from inherit block).
Then it will be good.
disassembler
force-pushed
the
devops-1100-hydra-eval-catch-errors
branch
6 times, most recently
from
4aea21d to
41590b3
Compare
rvl
approved these changes
Oct 18, 2018
scripts/ci/check-hydra.sh
Outdated
| EVAL_EXIT_CODE="$?" | ||
| EVAL_TIME=$(cat eval-time.txt) | ||
| jq -r '.' < eval.json | ||
| jq -r 'map_values(.error)|to_entries[]|select(.value)|@text "\(.key): \(.value)"' < eval.json |
There was a problem hiding this comment.
If we output to stderr (> /dev/stderr), will buildkite show it in red?
disassembler
force-pushed
the
devops-1100-hydra-eval-catch-errors
branch
4 times, most recently
from
37e9a6a to
cecb106
Compare
cleverca22
approved these changes
Oct 18, 2018
scripts/ci/check-hydra.sh
Outdated
|
|
||
| nix-build https://github.com/nixos/nixpkgs/archive/4fb198892d298452023ab176e7067da58d30772e.tar.gz -A hydra | ||
| echo '~~~ Evaluating release.nix' | ||
| ./result/bin/hydra-eval-jobs -I . release.nix | ||
| env time --format '%e' -o eval-time.txt ./result/bin/hydra-eval-jobs -I . release.nix > eval.json |
There was a problem hiding this comment.
i think you want command not env
disassembler
force-pushed
the
devops-1100-hydra-eval-catch-errors
branch
from
cecb106 to
51ee77a
Compare
disassembler
force-pushed
the
devops-1100-hydra-eval-catch-errors
branch
from
51ee77a to
2a7fa1c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses jq to parse output of hydra-eval-jobs. If hydra-eval-jobs exits failure it throws an error. If any attributes have an error key, it exits failure and prints all failing derivations.
This also fixes evals for hydra.
Linked issue
https://iohk.myjetbrains.com/youtrack/issue/DEVOPS-1100
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)