This repository was archived by the owner on Aug 18, 2020. It is now read-only.
[CBR-468] Add sliding window tx requests #3766
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr makes the getTransactions endpoint to work on a loop, untill it fetches all wanted results. Untill now, if a TxMeta entry failed to be transformed into a V1.Transaction, the request failed. Now we are more lenient: we ignore such TxMeta. This means we can have less entries than wanted. That's why we keep going back to SQlite for more TxMeta entries untill we have a full page or TxMeta are over.
TODO: needs to add tests.
Linked issue
https://iohk.myjetbrains.com/youtrack/issue/CBR-468
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)