Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

[CO-422] Making branch compile and cherry-picking of CO-427 #3809

Closed

Conversation

paweljakubas
Copy link
Contributor

@paweljakubas paweljakubas commented Nov 1, 2018

Description

  1. Make branch compiling
  2. Resolving cherry-picking conflicts with some further refactoring decoupling from old wallet
  • relocate eskToWalletDecrCredentials to wallet-new/src/Cardano/Wallet/Kernel/Decrypt.hs and drop importing Pos.Wallet.Web.Tracking.Decrypt (eskToWalletDecrCredentials)

Linked issue

https://iohk.myjetbrains.com/youtrack/issue/CO-422

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

@KtorZ
Copy link
Contributor

KtorZ commented Nov 2, 2018

I have rebased TheGreatCleanup using your changes; thanks @paweljakubas. We'll have to get CO-372/TheGreatCleanup merged into develop ASAP

@KtorZ KtorZ closed this Nov 2, 2018
@paweljakubas paweljakubas deleted the paweljakubas/CO-422/clean-core-coin branch November 5, 2018 19:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants