[RCD-52] cardano-launcher | win64: kill self via PID, not process name #3926
Conversation
deepfire
force-pushed
the
rcd-52-indiscriminate-killing
branch
from
76ede80 to
bceb3d5
Compare
| writeFile (toString runnerPath) $ unlines | ||
| [ "TaskKill /IM cardano-launcher.exe /F" | ||
| [ "TaskKill /PID "<>show selfPid<>" /F" |
There was a problem hiding this comment.
Not a big fan of this to be honest, and the pragma on top the file... And, what the comment truly says is that, if someone ever needs the windows update runner, it means they've ran the launcher on windows first, and thus, that those lines have been ran on windows? Is that correct?
I mean, this code still runs on linux and darwin machines, right? It's just that we make no use of the "update runner"...
There was a problem hiding this comment.
@KtorZ, the runnerPath = udWindowsPath ud :: Maybe FilePath governs whether writeWindowsUpdaterRunner will be run, and is naturally Nothing on non-Windows. We can fix the type defaulting, of course, if that's critical.
There was a problem hiding this comment.
To clarify, in other circumstances I'd not resort to -Wno-type-default, but I needed a sure-fire way to get past the thing quick -- and I don't have ready access to a Windows machine..
..and this is a release blocker..
There was a problem hiding this comment.
Yeah, got you (hence why I haven't blocked anything on this PR). I was just wondering. One way to avoid the warning would be to go for a string right away show <$> Process.getCurrentProcessId, but that's really minor.
|
@alan-mcnicholas confirmed the fix was a success! |
|
bors r+ |
3926: [RCD-52] cardano-launcher | win64: kill self via PID, not process name r=deepfire a=deepfire Co-authored-by: Kosyrev Serge <[email protected]>
|
Merged, to expedite Daedalus build. |
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)
How to merge
Send the message
bors r+to merge this PR. For more information, seedocs/how-to/bors.md.