This repository was archived by the owner on Aug 18, 2020. It is now read-only.
CBR-497: Adapt epoch consolidation for OBFT #3966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original epoch consolidation code only worked for Ouroborous classic epochs which had an epoch boundary block (EBB) between each epoch. OBFT has epochs just like classic, but does not have EBBs. This commit modifies the existing epoch consolidation code so that it works on both classic and OBFT epochs.
intricate
approved these changes
Dec 17, 2018
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 17, 2018
3966: CBR-497: Adapt epoch consolidation for OBFT r=erikd a=erikd ## Description The original epoch consolidation code only worked for Ouroborous classic epochs which had an epoch boundary block (EBB) between each epoch. OBFT has epochs just like classic, but does not have EBBs. This commit modifies the existing epoch consolidation code so that it works on both classic and OBFT epochs. ## Linked issue https://iohk.myjetbrains.com/youtrack/issue/CBR-497 ## QA Steps Sync the whole mainnet block chain (which is Ouroboros Classic/Original). Currently not able to test OBFT. Co-authored-by: Erik de Castro Lopo <[email protected]> Co-authored-by: Luke Nadur <[email protected]>
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The original epoch consolidation code only worked for Ouroborous
classic epochs which had an epoch boundary block (EBB) between
each epoch. OBFT has epochs just like classic, but does not have
EBBs. This commit modifies the existing epoch consolidation code
so that it works on both classic and OBFT epochs.
Linked issue
https://iohk.myjetbrains.com/youtrack/issue/CBR-497
QA Steps
Sync the whole mainnet block chain (which is Ouroboros Classic/Original). Currently not able to test OBFT.