This repository was archived by the owner on Aug 18, 2020. It is now read-only.
Special case 404 errors with empty bodies #3995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
parsonsmatt
force-pushed
the
matt/special-case-404
branch
from
d8e003b to
27e655b
Compare
KtorZ
approved these changes
Jan 8, 2019
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 8, 2019
3995: Special case 404 errors with empty bodies r=KtorZ a=parsonsmatt ## Description The PR adding `nextUpdate` testing to the cardano-wallet repo ([here](cardano-foundation/cardano-wallet#210)) demonstrated a bug in the way the Node client was handling 404 errors. As these typically don't have response bodies, it was failing them in a way that was really awkward to check. This PR provides a special case that should make the program work better. ## Linked issue <!--- Put here the relevant issue from YouTrack --> Co-authored-by: parsonsmatt <[email protected]>
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR adding
nextUpdatetesting to the cardano-wallet repo (here) demonstrated a bug in the way the Node client was handling 404 errors. As these typically don't have response bodies, it was failing them in a way that was really awkward to check.This PR provides a special case that should make the program work better.
Linked issue
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)
How to merge
Send the message
bors r+to merge this PR. For more information, seedocs/how-to/bors.md.