This repository was archived by the owner on Aug 18, 2020. It is now read-only.
[CBR-481/482] Add ObftConsensusStrictness data type #4018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhuesch
approved these changes
Jan 18, 2019
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 21, 2019
4018: [CBR-481/482] Add ObftConsensusStrictness data type r=intricate a=intricate ## Description Adds a data type, `ObftConsensusStrictness` which will be utilized in `OBFT` block validation. - `ObftStrict` implies that we will validate blocks strictly according to the round-robin slot leader schedule. - `ObftLenient` implies that we will follow the more lax rules under which any valid slot leader is able to mint a block given that `blocksMintedByLeaderInLastK < k * t` where `t` is some constant such that `1/5 <= t <= 1/4`. ## Linked issues https://iohk.myjetbrains.com/youtrack/issue/CBR-481 https://iohk.myjetbrains.com/youtrack/issue/CBR-482 Co-authored-by: Luke Nadur <[email protected]>
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a data type,
ObftConsensusStrictnesswhich will be utilized inOBFTblock validation.ObftStrictimplies that we will validate blocks strictly according to the round-robin slot leader schedule.ObftLenientimplies that we will follow the more lax rules under which any valid slot leader is able to mint a block given thatblocksMintedByLeaderInLastK < k * twheretis some constant such that1/5 <= t <= 1/4.Linked issues
https://iohk.myjetbrains.com/youtrack/issue/CBR-481
https://iohk.myjetbrains.com/youtrack/issue/CBR-482
Type of change
Developer checklist
Testing checklist