Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

[CBR-490] Disable SSC during OBFT #4026

Merged
merged 2 commits into from
Jan 23, 2019

Conversation

intricate
Copy link
Contributor

Description

Disables SSC workers and listeners (ignore SSC-related messages) during OBFT.

Linked issues

https://iohk.myjetbrains.com/youtrack/issue/CBR-490

Type of change

  • [~] 🐞 Bug fix (non-breaking change which fixes an issue)
  • [~] 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • [~] 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • [~] 🔨 New or improved tests for existing code
  • [~] ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • [~] If my code deals with exceptions, it follows the guidelines.
  • [~] I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • [~] CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • [~] I have added tests to cover my changes.
  • All new and existing tests passed.

@intricate intricate self-assigned this Jan 22, 2019
@intricate intricate requested review from erikd and mhuesch January 22, 2019 15:40
@mhuesch mhuesch force-pushed the intricate+mhuesch/disable-ssc-obft branch from 3504598 to 6c4cce2 Compare January 22, 2019 21:36
Michael Hueschen and others added 2 commits January 22, 2019 17:00
Use the `scParticipateSsc` field TVar, setting it to False when
we enter OBFT era.
@mhuesch mhuesch force-pushed the intricate+mhuesch/disable-ssc-obft branch from 6c4cce2 to c1953e0 Compare January 22, 2019 22:05
Copy link
Contributor

@mhuesch mhuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

era <- consensusEraBVD <$> (getAdoptedBVData logic)
case era of
OBFT _ -> pure d
_ -> action
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🙌

@intricate intricate force-pushed the intricate+mhuesch/disable-ssc-obft branch from dbdb8a7 to c1953e0 Compare January 23, 2019 03:18
@intricate
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Jan 23, 2019
4026: [CBR-490] Disable SSC during OBFT r=intricate a=intricate

## Description

Disables SSC workers and listeners (ignore SSC-related messages) during `OBFT`.

## Linked issues

https://iohk.myjetbrains.com/youtrack/issue/CBR-490



Co-authored-by: Michael Hueschen <[email protected]>
Co-authored-by: Luke Nadur <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jan 23, 2019

@iohk-bors iohk-bors bot merged commit c1953e0 into develop Jan 23, 2019
@iohk-bors iohk-bors bot deleted the intricate+mhuesch/disable-ssc-obft branch January 23, 2019 04:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants