This repository was archived by the owner on Aug 18, 2020. It is now read-only.
[CBR-481/482] Add functionality for determining slot leaders during OBFT #4029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function selects the current slot leaders by obtaining the genesis stakeholders, then tracing them through the delegation mapping. If a genesis stakeholder delegated to another stakeholder, we return the delegatee's id. If the genesis stakeholder did not delegate, we return their id.
intricate
force-pushed
the
intricate+mhuesch/obft-leaders
branch
from
06c67bd to
30669ab
Compare
intricate
force-pushed
the
intricate+mhuesch/obft-leaders
branch
from
30669ab to
c61f195
Compare
erikd
approved these changes
Jan 31, 2019
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 31, 2019
4029: [CBR-481/482] Add functionality for determining slot leaders during OBFT r=erikd a=intricate ## Description Adds functionality for determining slot leaders and richmen during the OBFT era. Also adds a test `ObftRoundRobinSpec` which introduces a couple of property tests pertaining to the OBFT round-robin slot leader schedule. _Note: This PR does not actually modify block generation or validation code. It only introduces the functions which will be utilized in upcoming PRs._ ## Linked issues https://iohk.myjetbrains.com/youtrack/issue/CBR-481 https://iohk.myjetbrains.com/youtrack/issue/CBR-482 Co-authored-by: Michael Hueschen <[email protected]> Co-authored-by: Luke Nadur <[email protected]>
Timed out |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 31, 2019
4029: [CBR-481/482] Add functionality for determining slot leaders during OBFT r=intricate a=intricate ## Description Adds functionality for determining slot leaders and richmen during the OBFT era. Also adds a test `ObftRoundRobinSpec` which introduces a couple of property tests pertaining to the OBFT round-robin slot leader schedule. _Note: This PR does not actually modify block generation or validation code. It only introduces the functions which will be utilized in upcoming PRs._ ## Linked issues https://iohk.myjetbrains.com/youtrack/issue/CBR-481 https://iohk.myjetbrains.com/youtrack/issue/CBR-482 4050: Internal Endpoints Disclaimer r=KtorZ a=KtorZ ## Description <!--- A brief description of this PR and the problem is trying to solve --> As a follow-up from the discussion in cardano-foundation/cardano-wallet#151 (comment), we will add a proper disclaimer in the documentation about the internal endpoints. ## Linked issue <!--- Put here the relevant issue from YouTrack --> cardano-foundation/cardano-wallet#228 Co-authored-by: Michael Hueschen <[email protected]> Co-authored-by: Luke Nadur <[email protected]> Co-authored-by: KtorZ <[email protected]>
Timed out (retrying...) |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 31, 2019
4029: [CBR-481/482] Add functionality for determining slot leaders during OBFT r=intricate a=intricate ## Description Adds functionality for determining slot leaders and richmen during the OBFT era. Also adds a test `ObftRoundRobinSpec` which introduces a couple of property tests pertaining to the OBFT round-robin slot leader schedule. _Note: This PR does not actually modify block generation or validation code. It only introduces the functions which will be utilized in upcoming PRs._ ## Linked issues https://iohk.myjetbrains.com/youtrack/issue/CBR-481 https://iohk.myjetbrains.com/youtrack/issue/CBR-482 Co-authored-by: Michael Hueschen <[email protected]> Co-authored-by: Luke Nadur <[email protected]>
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds functionality for determining slot leaders and richmen during the OBFT era. Also adds a test
ObftRoundRobinSpecwhich introduces a couple of property tests pertaining to the OBFT round-robin slot leader schedule.Note: This PR does not actually modify block generation or validation code. It only introduces the functions which will be utilized in upcoming PRs.
Linked issues
https://iohk.myjetbrains.com/youtrack/issue/CBR-481
https://iohk.myjetbrains.com/youtrack/issue/CBR-482
Type of change
Developer checklist
Testing checklist