This repository was archived by the owner on Aug 18, 2020. It is now read-only.
[CBR-503] Refactor script-runner testcases; fix testHFM
#4073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhuesch
force-pushed
the
mhuesch/fix_script-runner_testHFM
branch
3 times, most recently
from
8b5321c to
06b6c36
Compare
I had repeated myself in `testHardForkMechanism`, by copying the body of `test4`. Due to (what seems like) a botched rebase, my CBR-503 PR was broken, and because of the duplication, I didn't catch it in review. This commit factors out the shared logic, and does checking (`confSetBvAndSv`) to make sure proposals are sane. I also fix `testHFM` by making the BlockVersions and SoftwareVersions agree.
mhuesch
force-pushed
the
mhuesch/fix_script-runner_testHFM
branch
from
06b6c36 to
8ea5007
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 12, 2019
4073: [CBR-503] Refactor `script-runner` testcases; fix testHFM r=intricate a=mhuesch ## Description I had repeated myself in `testHardForkMechanism`, by copying the body of `test4`. Due to (what seems like) a botched rebase, my CBR-503 PR was broken, and because of the duplication, I didn't catch it in review. This commit factors out the shared logic, and does checking (`confSetBvAndSv`) to make sure proposals are sane. I also fix `testHFM` by making the BlockVersions and SoftwareVersions agree. ## Linked issue https://iohk.myjetbrains.com/youtrack/issue/CBR-503 Co-authored-by: Michael Hueschen <[email protected]>
Build failed |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 12, 2019
4073: [CBR-503] Refactor `script-runner` testcases; fix testHFM r=mhuesch a=mhuesch ## Description I had repeated myself in `testHardForkMechanism`, by copying the body of `test4`. Due to (what seems like) a botched rebase, my CBR-503 PR was broken, and because of the duplication, I didn't catch it in review. This commit factors out the shared logic, and does checking (`confSetBvAndSv`) to make sure proposals are sane. I also fix `testHFM` by making the BlockVersions and SoftwareVersions agree. ## Linked issue https://iohk.myjetbrains.com/youtrack/issue/CBR-503 Co-authored-by: Michael Hueschen <[email protected]>
Build failed |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 12, 2019
4073: [CBR-503] Refactor `script-runner` testcases; fix testHFM r=mhuesch a=mhuesch ## Description I had repeated myself in `testHardForkMechanism`, by copying the body of `test4`. Due to (what seems like) a botched rebase, my CBR-503 PR was broken, and because of the duplication, I didn't catch it in review. This commit factors out the shared logic, and does checking (`confSetBvAndSv`) to make sure proposals are sane. I also fix `testHFM` by making the BlockVersions and SoftwareVersions agree. ## Linked issue https://iohk.myjetbrains.com/youtrack/issue/CBR-503 Co-authored-by: Michael Hueschen <[email protected]>
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I had repeated myself in
testHardForkMechanism, by copying thebody of
test4. Due to (what seems like) a botched rebase, myCBR-503 PR was broken, and because of the duplication, I didn't
catch it in review. This commit factors out the shared logic, and
does checking (
confSetBvAndSv) to make sure proposals are sane.I also fix
testHFMby making the BlockVersions and SoftwareVersionsagree.
Linked issue
https://iohk.myjetbrains.com/youtrack/issue/CBR-503
Type of change
Developer checklist
Testing checklist
QA Steps
See
script-runner/README.mdHow to merge
Send the message
bors r+to merge this PR. For more information, seedocs/how-to/bors.md.