This repository was archived by the owner on Aug 18, 2020. It is now read-only.
Backporting of proper error kernel-to-API mapping during batch addresses import #4084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paweljakubas
force-pushed
the
paweljakubas/import-addresses-kernel-mapping
branch
from
fa2c6e5 to
9dd3d48
Compare
paweljakubas
changed the title
Changelog entry Change from CO-448 to CO-447
paweljakubas
force-pushed
the
paweljakubas/import-addresses-kernel-mapping
branch
from
9dd3d48 to
b8b36d9
Compare
KtorZ
approved these changes
Feb 20, 2019
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 20, 2019
4084: Backporting of proper error kernel-to-API mapping during batch addresses import r=KtorZ a=paweljakubas ## Description <!--- A brief description of this PR and the problem is trying to solve --> This is the last bit of backporting of batch import of addresses through APIs. Here, proper mapping of kernel addresses to API errors is enforced ## Linked issue <!--- Put here the relevant issue from YouTrack --> Part of https://iohk.myjetbrains.com/youtrack/issue/CO-447 , namely cardano-foundation/cardano-wallet#327 Co-authored-by: Pawel Jakubas <[email protected]>
Build succeeded |
iohk-bors
bot
deleted the
paweljakubas/import-addresses-kernel-mapping
branch
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the last bit of backporting of batch import of addresses through APIs. Here, proper mapping of kernel addresses to API errors is enforced
Linked issue
Part of https://iohk.myjetbrains.com/youtrack/issue/CO-447 , namely
cardano-foundation/cardano-wallet#327
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)
How to merge
Send the message
bors r+to merge this PR. For more information, seedocs/how-to/bors.md.