This repository was archived by the owner on Mar 1, 2019. It is now read-only.
258 manual testing #308
Merged
258 manual testing #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-iohk
commented
Feb 5, 2019
| @@ -27,6 +27,7 @@ cabal.project.local~ | |||
| ### Cardano ### | |||
|
|
|||
| test_keystore.* | |||
| state-staging | |||
There was a problem hiding this comment.
I have added this as the recently updated procedure of starting a node with cardano-wallet creates state-staging directory. (https://github.com/input-output-hk/cardano-wallet/wiki/Building-Running-and-Testing-a-wallet-node)
4 tasks
piotr-iohk
force-pushed
the
258_manual_testing
branch
from
48f8d8b to
6555000
Compare
KtorZ
suggested changes
Feb 6, 2019
…odify and add new scripts to aid manual steps
piotr-iohk
commented
Feb 6, 2019
| # -a --account=INT An optional parent account index [default: 2147483648] | ||
| # -n --number=INT number of addresses to generate [default: 10] | ||
| # -p --port=INT Port the server is listening to [default: 8090] | ||
| # -c --client=FILEPATH TLS client certificate expected by the server [default: ../../../state-staging/tls/client/client.pem] |
There was a problem hiding this comment.
I have changed default TLS client path to be in-line with https://github.com/input-output-hk/cardano-wallet/wiki/Building-Running-and-Testing-a-wallet-node, as most likely scenario for those scripts to be used IMHO would be when you start a node using that particular guide.
KtorZ
reviewed
Feb 7, 2019
| #!/bin/bash | ||
| # | ||
| # Usage: | ||
| # wallet (create | restore) [options] MNEMONICS... |
KtorZ
approved these changes
Feb 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#
Overview
curlrequest for doing batch import of those addressesComments
I have added and executed scenarios -> https://github.com/input-output-hk/cardano-wallet/blob/258_manual_testing/test/manual/258/scenarios.md
Some notes:
failuresthat I have encountered (i.e. addresses not imported) where expected. They where either for addresses that were already on the wallet or addresses that belonged to different wallet.