Skip to content

[DDW-1116] Use cardano-node with UTxO HD enabled #3005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

michalrus
Copy link
Member

@michalrus michalrus commented Jun 29, 2022

This PR uses the UTxO HD branch of cardano-node by @jasagredo.

Please note: for now, you need to manually remove the ledger/ directory in your chain/ directory, if you want to reuse an already synced blockchain

Todos

n/a

Screenshots

n/a

Testing Checklist


Review Checklist

Basics

  • PR assigned to the PR author(s)
  • input-output-hk/daedalus-dev and input-output-hk/daedalus-qa assigned as PR reviewers
  • If there are UI changes, Alexander Rukin assigned as an additional reviewer
  • All visual regression testing has been reviewed (assign run Chromatic label to PR to trigger the run)
  • PR has appropriate labels (release-vNext, feature/bug/chore, WIP)
  • PR link is added to a Jira ticket, ticket moved to In Review
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR contains screenshots (in case of UI changes)
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with typescript types
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Update Slack QA thread by marking it with a green checkmark

@michalrus michalrus self-assigned this Jun 29, 2022
@michalrus michalrus requested review from a team June 30, 2022 10:20
@miorsufianiohk miorsufianiohk self-requested a review July 4, 2022 09:08
@iohk-bors iohk-bors bot deleted the branch develop July 4, 2022 11:17
@iohk-bors iohk-bors bot closed this Jul 4, 2022
@michalrus
Copy link
Member Author

Reopening Bors mistake…

@michalrus michalrus reopened this Jul 4, 2022
@michalrus michalrus changed the base branch from chore/ddw-1110-vasil to develop July 4, 2022 11:48
@michalrus michalrus force-pushed the feature/ddw-1116-utxo-hd branch from 39088b3 to 9cc482f Compare January 26, 2023 18:04
@michalrus michalrus force-pushed the feature/ddw-1116-utxo-hd branch from 9cc482f to fe2e0f3 Compare January 26, 2023 18:05
@michalrus michalrus force-pushed the feature/ddw-1116-utxo-hd branch from a4518d1 to a881ec0 Compare January 27, 2023 13:20
@michalrus michalrus force-pushed the feature/ddw-1116-utxo-hd branch from 2342493 to 504f1e5 Compare January 27, 2023 15:28
@michalrus
Copy link
Member Author

Closing as no longer needed, we can reopen on new updates of UTxO HD

@michalrus michalrus closed this Jun 27, 2023
@michalrus michalrus deleted the feature/ddw-1116-utxo-hd branch June 29, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant