-
Notifications
You must be signed in to change notification settings - Fork 301
[DDW-1179] Update LedgerJS to 6.0.0 version #3093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-1179] Update LedgerJS to 6.0.0 version #3093
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Undocumented breaking change with str_to_path
util export explained here:
cardano-foundation/ledgerjs-hw-app-cardano#36
Thank you soo much @rhyslbw ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! Requires an additional QA review before merging 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested on Cardano app 5.0.0 and 6.0.3 with Nano S, Nano X and Nano S Plus. Great work @tomislavhoracek 👍 .
This PR introduces
@cardano-foundation/ledgerjs-hw-app-cardano
library update to version 6.0.0Jira Ticket
Useful links:
https://input-output-rnd.slack.com/archives/G010N9UFDNH/p1669826305137549
Todos
str_to_path
and use proper implementation suggested by @rhyslbw Error with utils/dist not being accessible cardano-foundation/ledgerjs-hw-app-cardano#36Screenshots
No
Testing Checklist
In the scope of this PR we should test voting breaking changes. Also, it would be nice to check regular transactions and delegation. LEDGER ONLY!
Review Checklist
Basics
input-output-hk/daedalus-dev
andinput-output-hk/daedalus-qa
assigned as PR reviewersrun Chromatic
label to PR to trigger the run)release-vNext
,feature
/bug
/chore
,WIP
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review