Skip to content

[DDW-1179] Update LedgerJS to 6.0.0 version #3093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 14, 2023

Conversation

tomislavhoracek
Copy link
Contributor

@tomislavhoracek tomislavhoracek commented Dec 27, 2022

This PR introduces @cardano-foundation/ledgerjs-hw-app-cardano library update to version 6.0.0

Jira Ticket

Useful links:
https://input-output-rnd.slack.com/archives/G010N9UFDNH/p1669826305137549

Todos

Screenshots

No

Testing Checklist

In the scope of this PR we should test voting breaking changes. Also, it would be nice to check regular transactions and delegation. LEDGER ONLY!

  • Test with current / official Ledger Cardano App
  • Update Ledger Cardano App to version v6.0.3. - This is an experimental app and you can install it using Ledger Live ( with an enabled Experimental flag under provider number 4)

Review Checklist

Basics

  • PR assigned to the PR author(s)
  • input-output-hk/daedalus-dev and input-output-hk/daedalus-qa assigned as PR reviewers
  • If there are UI changes, Alexander Rukin assigned as an additional reviewer
  • All visual regression testing has been reviewed (assign run Chromatic label to PR to trigger the run)
  • PR has appropriate labels (release-vNext, feature/bug/chore, WIP)
  • PR link is added to a Jira ticket, ticket moved to In Review
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR contains screenshots (in case of UI changes)
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with typescript types
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Update Slack QA thread by marking it with a green checkmark

@tomislavhoracek tomislavhoracek changed the title Chore/ddw 1179 update ledgerjs to v6.0.0 [DDW-1179] Update LedgerJS to 6.0.0 version Dec 27, 2022
@tomislavhoracek tomislavhoracek self-assigned this Dec 27, 2022
Copy link
Member

@rhyslbw rhyslbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undocumented breaking change with str_to_path util export explained here:
cardano-foundation/ledgerjs-hw-app-cardano#36

@tomislavhoracek
Copy link
Contributor Author

tomislavhoracek commented Feb 28, 2023

Undocumented breaking change with str_to_path util export explained here: cardano-foundation/ledgerjs-hw-app-cardano#36

Thank you soo much @rhyslbw ❤️

Copy link
Contributor

@przemyslaw-wlodek przemyslaw-wlodek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@szymonmaslowski szymonmaslowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@gabriela-ponce gabriela-ponce self-requested a review March 9, 2023 13:03
Copy link

@gabriela-ponce gabriela-ponce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Requires an additional QA review before merging 🙏

@gabriela-ponce gabriela-ponce requested a review from a team March 10, 2023 13:29
@miorsufianiohk miorsufianiohk self-requested a review March 13, 2023 09:29
Copy link

@miorsufianiohk miorsufianiohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested on Cardano app 5.0.0 and 6.0.3 with Nano S, Nano X and Nano S Plus. Great work @tomislavhoracek 👍 .

@danielmain danielmain merged commit 16e259f into develop Mar 14, 2023
@michalrus michalrus deleted the chore/ddw-1179-update-ledgerjs-to-v6.0.0 branch June 29, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants