Skip to content

Fix hls build for ghc 9.2 #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 18, 2022
Merged

Fix hls build for ghc 9.2 #1592

merged 3 commits into from
Aug 18, 2022

Conversation

hamishmack
Copy link
Collaborator

This adds flags: -haddockcomments to the default cabal.project of haskell-language-server to fix building on ghc 9.2

This adds `flags: -haddockcomments` to the default cabal.project of haskell-language-server to fix building on ghc 9.2
@michaelpj
Copy link
Collaborator

Is this an upstream issue?

@hamishmack
Copy link
Collaborator Author

I think it is covered by haskell/haskell-language-server#2982

@michaelpj
Copy link
Collaborator

I don't understand why HLS isn't broken in the same way, then.

@michaelpj
Copy link
Collaborator

Since they just have the one cabal.project without this flag, now.

@michaelpj
Copy link
Collaborator

Ah, maybe that snuck in on master only.

@hamishmack
Copy link
Collaborator Author

bors try

iohk-bors bot added a commit that referenced this pull request Aug 18, 2022
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 18, 2022

try

Build failed:

@hamishmack
Copy link
Collaborator Author

bors try

iohk-bors bot added a commit that referenced this pull request Aug 18, 2022
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 18, 2022

@hamishmack hamishmack merged commit fe7d738 into master Aug 18, 2022
@iohk-bors iohk-bors bot deleted the hkm/hls-ghc92 branch August 18, 2022 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants