Skip to content

Put v1 compatibility back and fix warning #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2020
Merged

Put v1 compatibility back and fix warning #714

merged 2 commits into from
Jun 20, 2020

Conversation

hamishmack
Copy link
Collaborator

The warning was not displayed if import did not pass args (probably the most common case).

So let's put the v1 interface back for now with a fixed warning.

@hamishmack hamishmack requested a review from angerman June 20, 2020 01:52
angerman
angerman approved these changes Jun 20, 2020
View reviewed changes
Copy link
Collaborator

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright then

@hamishmack hamishmack merged commit 22aa350 into master Jun 20, 2020
@iohk-bors iohk-bors bot deleted the hkm/fix-v1-warning branch June 20, 2020 05:38
booniepepper pushed a commit to booniepepper/haskell.nix that referenced this pull request Feb 4, 2022
@hamishmack @booniepepper
Put v1 compatibility back and fix warning (input-output-hk#714)
7580276 
* Revert "Remove backwards compatibility with V1 code (input-output-hk#710)"
* Fix issue with warning not being displayed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angerman angerman angerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamishmack @angerman