Skip to content

Use internal-nix-tools for hpack #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2020
Merged

Use internal-nix-tools for hpack #816

merged 1 commit into from
Aug 12, 2020

Conversation

hamishmack
Copy link
Collaborator

No description provided.

@hamishmack hamishmack requested a review from michaelpj August 12, 2020 03:14
michaelpj
michaelpj approved these changes Aug 12, 2020
View reviewed changes
Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering recent comments about caching, we should make sure the internal-nix-tools package set is included in roots, which I think it currently isn't.

@hamishmack hamishmack merged commit e340658 into master Aug 12, 2020
@iohk-bors iohk-bors bot deleted the hkm/internal-hpack branch August 12, 2020 09:40
This was referenced Aug 12, 2020
Closed
Closed
booniepepper pushed a commit to booniepepper/haskell.nix that referenced this pull request Feb 4, 2022
@hamishmack @booniepepper
Use internal-nix-tools for hpack (input-output-hk#816)
492cce6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpj michaelpj michaelpj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamishmack @michaelpj