Allow older ghc versions in cabalProject
#817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the `dummy-ghc-data`, `nix-tools` plan and `cabal-install` plan must be materialized for the selected `ghc`. This change relaxes that restriction and will instead use `nix-tools` and `cabal-install` built with a fixed `ghc` version (currently `ghc865`) and will calculate the `dummy-ghc-data` as an IFD. It will `__trace` a warning of the form: ``` WARNING: No materialized dummy-ghc-data for ghc-8.6.4-x86_64-darwin. ```
michaelpj
approved these changes
Aug 12, 2020
| @@ -21,8 +21,8 @@ in | |||
| , caller ? "callCabalProjectToNix" # Name of the calling funcion for better warning messages | |||
| , ghc ? null # Deprecated in favour of `compiler-nix-name` | |||
| , ghcOverride ? null # Used when we need to set ghc explicitly during bootstrapping | |||
| , nix-tools ? evalPackages.haskell-nix.nix-tools.${compiler-nix-name} # When building cabal projects we use the nix-tools | |||
| , cabal-install ? evalPackages.haskell-nix.cabal-install.${compiler-nix-name} # and cabal-install compiled with matching ghc version | |||
| , nix-tools ? evalPackages.haskell-nix.nix-tools-unchecked.${compiler-nix-name} # When building cabal projects we use the nix-tools | |||
There was a problem hiding this comment.
Why do we need the unchecked version now?
There was a problem hiding this comment.
The unchecked versions fall back on ghc865 when the materialized files are not present.
booniepepper
pushed a commit
to booniepepper/haskell.nix
that referenced
this pull request
Feb 4, 2022
Currently the `dummy-ghc-data`, `nix-tools` plan and `cabal-install` plan must be materialized for the selected `ghc`. This change relaxes that restriction and will instead use `nix-tools` and `cabal-install` built with a fixed `ghc` version (currently `ghc865`) and will calculate the `dummy-ghc-data` as an IFD. It will `__trace` a warning of the form: ``` WARNING: No materialized dummy-ghc-data for ghc-8.6.4-x86_64-darwin. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
dummy-ghc-data,nix-toolsplan andcabal-installplan must be materialized for the selected
ghc. This changerelaxes that restriction and will instead use
nix-toolsandcabal-installbuilt with a fixedghcversion (currentlyghc865)and will calculate the
dummy-ghc-dataas an IFD.It will
__tracea warning of the form: