-
Notifications
You must be signed in to change notification settings - Fork 2
refactor(wasm): Refactor wasm component adapter and wasi/wit code #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why to keep wasi/wit
files in two places ?
Maybe it make sense to get rid of one copy of them ?
|
||
|
||
# check-spelling Check spelling in this repo inside a container. | ||
spell-list-words: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of this target ? How it is different with the check-spelling
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a utility test target which just lists out all words which fail spelling for a particular path.
It's how I created a custom dictionary that only effects the wasm code.
I left it in because its useful, and is not used unless specifically called but a user.
@@ -0,0 +1,283 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it a correct file name ?
Should it be just a cspell.json
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thats the correct name.
I want to make a distinction between this file which just adds some extra config to the main cspell.json
file.
Which is what it does.
We don't. I fixed the import path to use a relative reference and fixed the COPY in earthly to put the files at the right point in the build. |
…thers need re-writing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* update wasm building process * fix some check issues * fix byte-array-literals lints * fix build script lints * fix fmt * fix lints * add licensing * remove verify crate * move byte-array-literals to another dir * update * fix * update hermes Earthfile * update version * fix * fix * add Readme * fix README.md * fix * update build * disable benches * wip * wip * update rust-toolchain files * update Readme * wip * remove Cargo.lock * fix lints * fix spelling * wip * update readme * rename dir * rebuild wasi-preview1-component-adapter project structure * fix vs recommended file * update * fix linting * move wasi-preview-component-adapter from hermes dir to the root * update APACHE license * wip * refactor(wasm): Refactor wasm component adapter and wasi/wit code (#72) * refactor(wasm): Refactor wasm component adapter and wasi/wit code * fix(wasm): Fix code format * fix(wasm): Update standard WASI .wit files to latest version * fix(wasm): Cleanup WASM wit definitions and remove things not compatible with Hermes. * fix(wasm): Fix code format * fix(spelling): Fix spelling check for wasm code * feat(spelling): Add target to help build words lists * fix(wasm): Fix code format * fix(wasm): Use relative path to wit files so we don;t need symlink * feat(wasm): Rewrite cron module and introduce basic hermes modules. Others need re-writing * fix(spelling): Fix spellcheck errors --------- Co-authored-by: Steven Johnson <[email protected]>
Refactor to move wasi outside the wasi component adapter crate.
Rename the component adapter crate so it can not be confused with the official one.
Remove the ability to build a command version as hermes does not support it.